Skip to content

feat(semantic): extend MemberWriteTarget to cover all property modification patterns#21205

Merged
graphite-app[bot] merged 1 commit intomainfrom
feat/semantic-extend-member-write-target
Apr 11, 2026
Merged

feat(semantic): extend MemberWriteTarget to cover all property modification patterns#21205
graphite-app[bot] merged 1 commit intomainfrom
feat/semantic-extend-member-write-target

Conversation

@Dunqing
Copy link
Copy Markdown
Member

@Dunqing Dunqing commented Apr 9, 2026

Summary

  • Extend MemberWriteTarget flag to cover compound assignments (+=), update expressions (++/--), and delete — previously only simple = assignments were covered
  • Add visit_unary_expression override to set Write for delete on member expressions
  • Change is_write_only() to is_write() in visit_member_expression so all write contexts trigger the flag
  • Fix MemberWriteTarget leaking into conditional test positions ((a ? x : y).foo = 1 was incorrectly marking a)
  • Add snapshot test covering compound assignments, delete, and conditional expressions
  • Update doc comments to reflect broader scope

Test plan

  • New snapshot test member-write-target.js covering compound assignments, delete, conditional test/consequent/alternate
  • Existing semantic snapshot tests updated
  • just ready passes

🤖 Generated with Claude Code

Copy link
Copy Markdown
Member Author

Dunqing commented Apr 9, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added A-semantic Area - Semantic C-enhancement Category - New feature or request labels Apr 9, 2026
@Dunqing Dunqing marked this pull request as ready for review April 9, 2026 05:15
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 9, 2026

Merging this PR will not alter performance

✅ 48 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing feat/semantic-extend-member-write-target (3560adb) with main (bdac624)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Dunqing Dunqing force-pushed the feat/semantic-extend-member-write-target branch from a56bb73 to 327c2a5 Compare April 10, 2026 02:57
@Dunqing
Copy link
Copy Markdown
Member Author

Dunqing commented Apr 10, 2026

This PR adds support for a.foo += 1, ++a.foo / a.foo--, and delete a.foo, which also unblocks Rolldown from fully replacing their own flag with Ours.

@Dunqing Dunqing requested a review from Boshen April 10, 2026 03:00
@Dunqing Dunqing force-pushed the feat/semantic-extend-member-write-target branch 3 times, most recently from 30c2301 to 3560adb Compare April 10, 2026 03:24
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Apr 11, 2026
Copy link
Copy Markdown
Member

Boshen commented Apr 11, 2026

Merge activity

…fication patterns (#21205)

## Summary

- Extend `MemberWriteTarget` flag to cover compound assignments (`+=`), update expressions (`++/--`), and `delete` — previously only simple `=` assignments were covered
- Add `visit_unary_expression` override to set `Write` for `delete` on member expressions
- Change `is_write_only()` to `is_write()` in `visit_member_expression` so all write contexts trigger the flag
- Fix `MemberWriteTarget` leaking into conditional test positions (`(a ? x : y).foo = 1` was incorrectly marking `a`)
- Add snapshot test covering compound assignments, delete, and conditional expressions
- Update doc comments to reflect broader scope

## Test plan

- [x] New snapshot test `member-write-target.js` covering compound assignments, delete, conditional test/consequent/alternate
- [x] Existing semantic snapshot tests updated
- [x] `just ready` passes

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@graphite-app graphite-app Bot force-pushed the feat/semantic-extend-member-write-target branch from 3560adb to 6dd061c Compare April 11, 2026 14:31
@graphite-app graphite-app Bot merged commit 6dd061c into main Apr 11, 2026
26 checks passed
@graphite-app graphite-app Bot deleted the feat/semantic-extend-member-write-target branch April 11, 2026 14:36
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Apr 11, 2026
graphite-app Bot pushed a commit that referenced this pull request Apr 13, 2026
…et` flag (#21206)

## Summary

- Replace the 97-line `is_modifying_property()` ancestor-walking function with a single `reference.flags().is_member_write_target()` check
- Now that `MemberWriteTarget` covers all property modification patterns (simple `=`, compound `+=`, update `++/--`, `delete`), the manual ancestor walk is no longer needed

Depends on #21205.

## Test plan

- [x] Existing `no-param-reassign` tests pass unchanged
- [x] `just ready` passes

🤖 Generated with [Claude Code](https://claude.com/claude-code)
camc314 pushed a commit that referenced this pull request Apr 13, 2026
### 💥 BREAKING CHANGES

- 36cdc31 str: [**BREAKING**] Remove identity `FromIn` impl for `Ident`
(#21251) (overlookmotel)
- 382958a span: [**BREAKING**] Remove re-exports of string types from
`oxc_span` crate (#21246) (overlookmotel)
- c4aedfa str: [**BREAKING**] Add `static_ident!` macro (#21245)
(overlookmotel)

### 🚀 Features

- e7e1aea transformer/typescript: Add `optimize_enums` option for
regular enum inlining (#20539) (Dunqing)
- 679f57f transformer/typescript: Implement const enum inlining and
declaration removal (#20508) (Dunqing)
- 6dd061c semantic: Extend `MemberWriteTarget` to cover all property
modification patterns (#21205) (Dunqing)
- f134e24 minifier: Support `property_write_side_effects` option to drop
unused property assignments (#20773) (Dunqing)
- 75663c0 semantic: Add enum member value evaluation for const enum
support (#20602) (Dunqing)
- 3cfe8ed semantic: Add `MemberWriteTarget` flag to `ReferenceFlags`
(#20772) (Dunqing)

### 🐛 Bug Fixes

- af1a586 transformer/class-properties: Use correct property name when
converting parameter properties (#21268) (Amal Jossy)
- b43250a allocator: Move allocation tracking into `Bump` (#21342)
(overlookmotel)
- 36f505f allocator: `StringBuilder` use `Allocator::alloc_layout`
(#21340) (overlookmotel)
- 7a08a6f allocator: Fix allocation counting in
`Allocator::alloc_concat_strs_array` (#21336) (overlookmotel)
- 2338e28 ecmascript: Treat `this` as potentially having side effects
(#21297) (sapphi-red)
- bd8bd39 allocator: Remove unsafe hacks from `from_raw_parts` methods
(#21283) (overlookmotel)
- 8f4c340 allocator: Remove dangerous pointer const to mut cast (#21279)
(overlookmotel)
- aa9259f parser: Add missing error code for optional param diagnostic
(#21258) (camc314)
- 04b3c2f str: Fix unsound casting const pointers to mut pointers
(#21242) (overlookmotel)
- ceadf6c str: Make `Ident::from_raw` an unsafe function (#21241)
(overlookmotel)
- eab13b3 transformer/decorators: Avoid accessor storage name collisions
(#21106) (Dunqing)
- 07e8a30 transformer/react-refresh: Handle parenthesized variable
initializers (#21047) (camc314)

### ⚡ Performance

- c3ca6f6 allocator: `StringBuilder::from_strs_array_in` check for 0
length earlier (#21338) (overlookmotel)
- c2422bb allocator: `Allocator::alloc_concat_strs_array` check for 0
length earlier (#21337) (overlookmotel)
- 04b0fdc allocator: Mark `Allocator::alloc_layout` as
`#[inline(always)]` (#21335) (overlookmotel)
- 17aee9e allocator: Use `offset_from_unsigned` in
`ChunkFooter::as_raw_parts` (#21280) (overlookmotel)
- 61adedd minifier: Fix O(n²) perf on very many var decls (#21062)
(Gunnlaugur Thor Briem)
- addcd02 napi/parser, linter/plugins: Raw transfer deserializer for
`Vec`s use shift instead of multiply where possible (#21142)
(overlookmotel)
- 3068ded napi/parser, linter/plugins: Shift before add when calculating
positions in raw transfer deserializer (#21141) (overlookmotel)
- eb400b8 napi/parser, linter/plugins: Remove `uint32` buffer view
(#21140) (overlookmotel)
- 2675085 napi/parser: Lazy deserialization use only `Int32Array`
(#21139) (overlookmotel)
- 5b35a53 napi/parser: Deserializing tokens use only `int32` array
(#21138) (overlookmotel)
- f163d10 parser: Tokens raw deserialization use `Int32Array` (#21137)
(overlookmotel)
- 7a86613 linter/plugins: Use `Int32Array`s for tokens and comments
buffers (#21136) (overlookmotel)
- 8c51121 napi/parser, linter/plugins: Raw transfer deserialize `Span`
fields as `i32`s (#21135) (overlookmotel)
- bc1bcdd napi/parser, linter/plugins: Inline trivial raw transfer field
deserializers into node object definitions (#21134) (overlookmotel)
- c0278ab napi/parser, linter/plugins: Use `Int32Array` in raw transfer
deserializer (#21132) (overlookmotel)
- 43482c7 linter/plugins: Use `>>` not `>>>` in binary search loops
(#21129) (overlookmotel)

### 📚 Documentation

- f5e1845 allocator: Upgrade headers in doc comments for `Bump` (#21263)
(overlookmotel)
- 2870174 allocator: Upper case `SAFETY` in comments (#21253)
(overlookmotel)
- 01bc269 str: Reformat `Ident` doc comments (#21240) (overlookmotel)
- dd47359 allocator: Add doc comments for panics and errors (#21230)
(overlookmotel)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-semantic Area - Semantic C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants