Skip to content

test(napi/parser): fix benchmarks#21128

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/04-07-test_napi_parser_fix_benchmarks
Apr 7, 2026
Merged

test(napi/parser): fix benchmarks#21128
graphite-app[bot] merged 1 commit intomainfrom
om/04-07-test_napi_parser_fix_benchmarks

Conversation

@overlookmotel
Copy link
Copy Markdown
Member

@overlookmotel overlookmotel commented Apr 7, 2026

Raw transfer benchmark had got broken. Fix it.

Copy link
Copy Markdown
Member Author

overlookmotel commented Apr 7, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added the A-parser Area - Parser label Apr 7, 2026
@github-actions github-actions Bot added the C-test Category - Testing. Code is missing test cases, or a PR is adding them label Apr 7, 2026
@overlookmotel overlookmotel marked this pull request as ready for review April 7, 2026 15:42
Copilot AI review requested due to automatic review settings April 7, 2026 15:42
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the NAPI parser benchmark script after the raw transfer benchmark stopped working due to outdated imports/paths.

Changes:

  • Update async parser import to match the current src-js/index.js export (parse).
  • Fix internal import paths to point at ./src-js/generated/* instead of ./generated/*.

@overlookmotel overlookmotel self-assigned this Apr 7, 2026
@graphite-app graphite-app Bot added the 0-merge Merge with Graphite Merge Queue label Apr 7, 2026
@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app Bot commented Apr 7, 2026

Merge activity

Raw transfer benchmark had got broken. Fix it.
@graphite-app graphite-app Bot force-pushed the om/04-07-test_napi_parser_fix_benchmarks branch from b341688 to 990b73a Compare April 7, 2026 17:10
@graphite-app graphite-app Bot merged commit 990b73a into main Apr 7, 2026
23 of 24 checks passed
@graphite-app graphite-app Bot deleted the om/04-07-test_napi_parser_fix_benchmarks branch April 7, 2026 17:14
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Apr 7, 2026
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@overlookmotel could this file be converted to TS so it gets typechecked to prevent it breaking again in future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants