Skip to content

Skip MinimumSwitchCases transformation when type info is missing#808

Merged
jkschneider merged 1 commit intomainfrom
jkschneider/minimum-switch-missing-types
Jan 26, 2026
Merged

Skip MinimumSwitchCases transformation when type info is missing#808
jkschneider merged 1 commit intomainfrom
jkschneider/minimum-switch-missing-types

Conversation

@jkschneider
Copy link
Copy Markdown
Member

@jkschneider jkschneider commented Jan 26, 2026 •
edited by moderne-meeseeks bot
Loading

Summary

  • Add guard to skip transformation when identifier case patterns lack type info
  • Enhance switchesOnEnum() to check case pattern types when selector type is unknown
  • Add test cases for static constants and missing type info scenarios

Problem

When converting switch statements to if statements, identifier case patterns (like enum constants or static fields) need to be properly qualified. With incomplete classpath (missing type info), the recipe would produce broken code:

// Before
switch (event.getHideButton()) {
    case YES:
        doSomething();
        break;
}

// After (broken - YES is unresolved)
if (event.getHideButton() == YES) {
    doSomething();
}

// Expected
if (event.getHideButton() == Dialog.PredefinedButton.YES) {
    doSomething();
}

Solution

  1. Added hasUnresolvableIdentifierCasePattern() to detect identifier patterns without type info
  2. Skip transformation when we can't properly qualify identifiers
  3. Enhanced switchesOnEnum() to also check case pattern types, handling cases where selector type is unknown but patterns have type info

Test plan

  • Existing tests pass

  • New tests added:

    • switchOnStringWithStaticConstant - String switch with static import
    • switchOnIntWithStaticConstant - Int switch with static import
    • switchOnEnumWithNestedClass - Nested enum (customer's scenario)
    • skipsTransformationWhenTypeInfoMissing - Validates the fix

  • Fixes moderneinc/customer-requests#1536

@jkschneider
Skip MinimumSwitchCases transformation when type info is missing
03b5ac8 
When converting switch statements to if statements, identifier case patterns
(like enum constants or static fields) need to be properly qualified in the
resulting if statement. Without type information, we cannot determine the
correct qualification, which would produce broken code like `if (x == YES)`
instead of `if (x == Dialog.PredefinedButton.YES)`.

This change adds a guard to skip the transformation when case patterns are
identifiers without type info. It also enhances switchesOnEnum() to check
case pattern types when the selector type is unknown.

Fixes moderneinc/customer-requests#1536
@github-project-automation github-project-automation bot moved this to In Progress in OpenRewrite Jan 26, 2026
@jkschneider jkschneider merged commit 12d5798 into main Jan 26, 2026
2 checks passed
@jkschneider jkschneider deleted the jkschneider/minimum-switch-missing-types branch January 26, 2026 03:52
@github-project-automation github-project-automation bot moved this from In Progress to Done in OpenRewrite Jan 26, 2026
mergify bot added a commit to robfrank/linklift that referenced this pull request Feb 14, 2026
@mergify
chore(deps): bump org.openrewrite.recipe:rewrite-static-analysis from…
fae068c 
… 2.26.0 to 2.27.0 [skip ci]

Bumps [org.openrewrite.recipe:rewrite-static-analysis](https://github.com/openrewrite/rewrite-static-analysis) from 2.26.0 to 2.27.0.
Release notes

*Sourced from [org.openrewrite.recipe:rewrite-static-analysis's releases](https://github.com/openrewrite/rewrite-static-analysis/releases).*

> 2.27.0
> ------
>
> What's Changed
> --------------
>
> * Skip MinimumSwitchCases transformation when type info is missing by [`@​jkschneider`](https://github.com/jkschneider) in [openrewrite/rewrite-static-analysis#808](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/808)
> * Preserve `else-if` chains in `UnwrapElseAfterReturn` recipe by [`@​knutwannheden`](https://github.com/knutwannheden) in [openrewrite/rewrite-static-analysis#809](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/809)
> * Followup after the formatting merge by [`@​Jenson3210`](https://github.com/Jenson3210) in [openrewrite/rewrite-static-analysis#810](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/810)
> * Make declarative recipes singletons by [`@​sambsnyd`](https://github.com/sambsnyd) in [openrewrite/rewrite-static-analysis#811](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/811)
> * Fix UnnecessaryThrows to check actual close() method exceptions by [`@​timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-static-analysis#812](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/812)
> * Adjust indent in `ReplaceRedundantFormatWithPrintfTest` by [`@​greg-at-moderne`](https://github.com/greg-at-moderne) in [openrewrite/rewrite-static-analysis#815](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/815)
> * One more test case for `ExplicitLambdaArgumentTypes` by [`@​greg-at-moderne`](https://github.com/greg-at-moderne) in [openrewrite/rewrite-static-analysis#814](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/814)
>
> New Contributors
> ----------------
>
> * [`@​sambsnyd`](https://github.com/sambsnyd) made their first contribution in [openrewrite/rewrite-static-analysis#811](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/811)
>
> **Full Changelog**: <openrewrite/rewrite-static-analysis@v2.26.0...v2.27.0>


Commits

* [`21db3b9`](openrewrite/rewrite-static-analysis@21db3b9) Extract documentation examples from tests
* [`82e1520`](openrewrite/rewrite-static-analysis@82e1520) doesNotImportConflictingClassName ([#814](https://redirect.github.com/openrewrite/rewrite-static-analysis/issues/814))
* [`73b881f`](openrewrite/rewrite-static-analysis@73b881f) Adjust indent ([#815](https://redirect.github.com/openrewrite/rewrite-static-analysis/issues/815))
* [`fa551ea`](openrewrite/rewrite-static-analysis@fa551ea) Delete files
* [`a095673`](openrewrite/rewrite-static-analysis@a095673) Fix UnnecessaryThrows to check actual close() method exceptions ([#812](https://redirect.github.com/openrewrite/rewrite-static-analysis/issues/812))
* [`a32c4e3`](openrewrite/rewrite-static-analysis@a32c4e3) Make declarative recipes singletons ([#811](https://redirect.github.com/openrewrite/rewrite-static-analysis/issues/811))
* [`98e70a3`](openrewrite/rewrite-static-analysis@98e70a3) Followup after the formatting merge ([#810](https://redirect.github.com/openrewrite/rewrite-static-analysis/issues/810))
* [`8c2d7dc`](openrewrite/rewrite-static-analysis@8c2d7dc) Preserve `else-if` chains in `UnwrapElseAfterReturn` recipe ([#809](https://redirect.github.com/openrewrite/rewrite-static-analysis/issues/809))
* [`6d3fb00`](openrewrite/rewrite-static-analysis@6d3fb00) `FixStringFormatExpressions` should check for content difference
* [`12d5798`](openrewrite/rewrite-static-analysis@12d5798) Skip MinimumSwitchCases transformation when type info is missing ([#808](https://redirect.github.com/openrewrite/rewrite-static-analysis/issues/808))
* See full diff in [compare view](openrewrite/rewrite-static-analysis@v2.26.0...v2.27.0)
  
[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=org.openrewrite.recipe:rewrite-static-analysis&package-manager=maven&previous-version=2.26.0&new-version=2.27.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
  
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

OpenRewrite
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jkschneider