Skip to content

Fix UnnecessaryThrows to check actual close() method exceptions#812

Merged
timtebeek merged 1 commit intomainfrom
unnecessary-throws-twr-close
Jan 30, 2026
Merged

Fix UnnecessaryThrows to check actual close() method exceptions#812
timtebeek merged 1 commit intomainfrom
unnecessary-throws-twr-close

Conversation

@timtebeek
Copy link
Copy Markdown
Member

@timtebeek timtebeek commented Jan 30, 2026

Summary

  • Fix UnnecessaryThrows recipe incorrectly removing throws from methods using try-with-resources

  • The recipe was making blanket assumptions (Closeable=IOException, AutoCloseable=Exception) instead of checking the actual close() method signature

  • Now looks up the actual close() method on the resource type and checks its declared exceptions

  • Fixes UnnecessaryThrows does not detect exceptions thrown by try-with-resources #728

The recipe was incorrectly removing throws declarations from methods
using try-with-resources because it made blanket assumptions that all
Closeable types throw IOException and all AutoCloseable types throw
Exception.

Instead, the fix looks up the actual close() method on the resource
type and checks what exceptions it declares, using the same mechanism
already used for method invocations.

Fixes #728
@github-project-automation github-project-automation bot moved this to In Progress in OpenRewrite Jan 30, 2026
@timtebeek timtebeek merged commit a095673 into main Jan 30, 2026
2 checks passed
@timtebeek timtebeek deleted the unnecessary-throws-twr-close branch January 30, 2026 16:17
@github-project-automation github-project-automation bot moved this from In Progress to Done in OpenRewrite Jan 30, 2026
mergify bot added a commit to robfrank/linklift that referenced this pull request Feb 14, 2026
… 2.26.0 to 2.27.0 [skip ci]

Bumps [org.openrewrite.recipe:rewrite-static-analysis](https://github.com/openrewrite/rewrite-static-analysis) from 2.26.0 to 2.27.0.
Release notes

*Sourced from [org.openrewrite.recipe:rewrite-static-analysis's releases](https://github.com/openrewrite/rewrite-static-analysis/releases).*

> 2.27.0
> ------
>
> What's Changed
> --------------
>
> * Skip MinimumSwitchCases transformation when type info is missing by [`@​jkschneider`](https://github.com/jkschneider) in [openrewrite/rewrite-static-analysis#808](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/808)
> * Preserve `else-if` chains in `UnwrapElseAfterReturn` recipe by [`@​knutwannheden`](https://github.com/knutwannheden) in [openrewrite/rewrite-static-analysis#809](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/809)
> * Followup after the formatting merge by [`@​Jenson3210`](https://github.com/Jenson3210) in [openrewrite/rewrite-static-analysis#810](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/810)
> * Make declarative recipes singletons by [`@​sambsnyd`](https://github.com/sambsnyd) in [openrewrite/rewrite-static-analysis#811](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/811)
> * Fix UnnecessaryThrows to check actual close() method exceptions by [`@​timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-static-analysis#812](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/812)
> * Adjust indent in `ReplaceRedundantFormatWithPrintfTest` by [`@​greg-at-moderne`](https://github.com/greg-at-moderne) in [openrewrite/rewrite-static-analysis#815](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/815)
> * One more test case for `ExplicitLambdaArgumentTypes` by [`@​greg-at-moderne`](https://github.com/greg-at-moderne) in [openrewrite/rewrite-static-analysis#814](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/814)
>
> New Contributors
> ----------------
>
> * [`@​sambsnyd`](https://github.com/sambsnyd) made their first contribution in [openrewrite/rewrite-static-analysis#811](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/811)
>
> **Full Changelog**: <openrewrite/rewrite-static-analysis@v2.26.0...v2.27.0>


Commits

* [`21db3b9`](openrewrite/rewrite-static-analysis@21db3b9) Extract documentation examples from tests
* [`82e1520`](openrewrite/rewrite-static-analysis@82e1520) doesNotImportConflictingClassName ([#814](https://redirect.github.com/openrewrite/rewrite-static-analysis/issues/814))
* [`73b881f`](openrewrite/rewrite-static-analysis@73b881f) Adjust indent ([#815](https://redirect.github.com/openrewrite/rewrite-static-analysis/issues/815))
* [`fa551ea`](openrewrite/rewrite-static-analysis@fa551ea) Delete files
* [`a095673`](openrewrite/rewrite-static-analysis@a095673) Fix UnnecessaryThrows to check actual close() method exceptions ([#812](https://redirect.github.com/openrewrite/rewrite-static-analysis/issues/812))
* [`a32c4e3`](openrewrite/rewrite-static-analysis@a32c4e3) Make declarative recipes singletons ([#811](https://redirect.github.com/openrewrite/rewrite-static-analysis/issues/811))
* [`98e70a3`](openrewrite/rewrite-static-analysis@98e70a3) Followup after the formatting merge ([#810](https://redirect.github.com/openrewrite/rewrite-static-analysis/issues/810))
* [`8c2d7dc`](openrewrite/rewrite-static-analysis@8c2d7dc) Preserve `else-if` chains in `UnwrapElseAfterReturn` recipe ([#809](https://redirect.github.com/openrewrite/rewrite-static-analysis/issues/809))
* [`6d3fb00`](openrewrite/rewrite-static-analysis@6d3fb00) `FixStringFormatExpressions` should check for content difference
* [`12d5798`](openrewrite/rewrite-static-analysis@12d5798) Skip MinimumSwitchCases transformation when type info is missing ([#808](https://redirect.github.com/openrewrite/rewrite-static-analysis/issues/808))
* See full diff in [compare view](openrewrite/rewrite-static-analysis@v2.26.0...v2.27.0)
  
[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=org.openrewrite.recipe:rewrite-static-analysis&package-manager=maven&previous-version=2.26.0&new-version=2.27.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
  
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

UnnecessaryThrows does not detect exceptions thrown by try-with-resources

1 participant