feat(react-drawer): allow aside tag for Drawer components#31434
Merged
marcosmoura merged 15 commits intomicrosoft:masterfrom Jun 4, 2024
Merged
feat(react-drawer): allow aside tag for Drawer components#31434marcosmoura merged 15 commits intomicrosoft:masterfrom
marcosmoura merged 15 commits intomicrosoft:masterfrom
Conversation
ValentinaKozlova
approved these changes
May 21, 2024
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender | 40 | 41 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 632 | 656 | 5000 | |
| Button | mount | 319 | 305 | 5000 | |
| Field | mount | 1172 | 1156 | 5000 | |
| FluentProvider | mount | 731 | 719 | 5000 | |
| FluentProviderWithTheme | mount | 92 | 95 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 40 | 41 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 92 | 93 | 10 | |
| MakeStyles | mount | 864 | 872 | 50000 | |
| Persona | mount | 1767 | 1750 | 5000 | |
| SpinButton | mount | 1465 | 1453 | 5000 | |
| SwatchPicker | mount | 1602 | 1569 | 5000 |
Collaborator
📊 Bundle size report
Unchanged fixtures
|
* master: applying package updates applying package updates docs: Surfacing `Dropdown` and `Combobox` prop comments to docsite (microsoft#31430) (web-components) call click in button keydownHandler (microsoft#31428) Modify data and color codes for examples to fix accessibility issues (microsoft#31425) chore(deps): bump semver from 5.7.1 to 6.3.1 (microsoft#31420) applying package updates Improve gauge chart screen reader accessibility (microsoft#26682) applying package updates applying package updates
* master: (49 commits) Update focus order in sankey chart for vertical navigation (microsoft#31469) chore: use new performant 'type-check' for v9 libaries (microsoft#31454) applying package updates fix(Timepicker-compat): clearIcon not working in freeform (microsoft#31324) chore: re-enable lint rule (microsoft#31459) feat(react-tag-picker): adds text property to TagPickerOption (microsoft#31474) feat(recipes): create package with initial implementation (moved from /apps) (microsoft#31386) applying package updates applying package updates chore: revert globals changes (microsoft#31470) (web-components) Use `ElementInternals` for TextInput elements (microsoft#31201) chore:(docs) Update and migrate component implementation guide (microsoft#31398) disallow all globals in Fluent v9 (microsoft#30967) chore:(react-nav-preview) Recomposing more components and some pixel pushing (microsoft#31387) fix(pr-deploy-site): explicitly set types to not include whole @types/* globals which are causing issues with addition of @types/web (microsoft#31465) fix(recipes-react-components): explicitly set types to not include whole @types/* globals which are cauising issues with addition of @types/web (microsoft#31463) applying package updates applying package updates applying package updates Update IconDirectionContextProvider import to import from specific path (microsoft#31006) ...
marcosmoura
commented
May 28, 2024
...react-drawer/src/components/OverlayDrawer/OverlayDrawerSurface/OverlayDrawerSurface.types.ts
Show resolved
Hide resolved
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
fabricteam
reviewed
May 28, 2024
bsunderhus
approved these changes
May 28, 2024
Contributor
bsunderhus
left a comment
There was a problem hiding this comment.
Beside some small comments,
LGTM ✅.
Would be nice to investigate adding aside as a possible value to the Dialog root slot signature instead of casting, we can do that on a follow up PR.
packages/react-components/react-drawer/src/components/InlineDrawer/useInlineDrawer.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-drawer/src/components/InlineDrawer/useInlineDrawer.ts
Outdated
Show resolved
Hide resolved
...ents/react-drawer/src/components/OverlayDrawer/OverlayDrawerSurface/OverlayDrawerSurface.tsx
Show resolved
Hide resolved
packages/react-components/react-drawer/src/components/OverlayDrawer/useOverlayDrawer.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-nav-preview/src/components/NavDrawer/useNavDrawer.ts
Outdated
Show resolved
Hide resolved
mltejera
approved these changes
Jun 4, 2024
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Drawer would only allow
<div>as the root component tagNew Behavior
Drawer now allows
<aside>tag as well.Related Issue(s)