(web-components) call click in button keydownHandler#31428
Merged
radium-v merged 1 commit intomicrosoft:masterfrom May 20, 2024
Merged
(web-components) call click in button keydownHandler#31428radium-v merged 1 commit intomicrosoft:masterfrom
radium-v merged 1 commit intomicrosoft:masterfrom
Conversation
davatron5000
approved these changes
May 20, 2024
Contributor
davatron5000
left a comment
There was a problem hiding this comment.
Verified on my machine
chrisdholt
approved these changes
May 20, 2024
eljefe223
approved these changes
May 20, 2024
Collaborator
📊 Bundle size report✅ No changes found |
fabricteam
reviewed
May 20, 2024
change/@fluentui-web-components-b3fafaa6-c49f-4778-872d-2bf39a9ecab2.json
Show resolved
Hide resolved
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
May 21, 2024
* master: applying package updates applying package updates docs: Surfacing `Dropdown` and `Combobox` prop comments to docsite (microsoft#31430) (web-components) call click in button keydownHandler (microsoft#31428) Modify data and color codes for examples to fix accessibility issues (microsoft#31425) chore(deps): bump semver from 5.7.1 to 6.3.1 (microsoft#31420) applying package updates Improve gauge chart screen reader accessibility (microsoft#26682) applying package updates applying package updates
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The
keydownHandlerfunction callsthis.press(), which does the action but doesn't do it in the same way as described in the spec. Pressingspaceorenteron a button should call theclickfunction.New Behavior
The
keydownHandlercallsthis.click()when the space or enter key is pressed.