Improve gauge chart screen reader accessibility#26682
Merged
krkshitij merged 3 commits intomicrosoft:masterfrom May 20, 2024
Merged
Improve gauge chart screen reader accessibility#26682krkshitij merged 3 commits intomicrosoft:masterfrom
krkshitij merged 3 commits intomicrosoft:masterfrom
Conversation
Collaborator
📊 Bundle size report✅ No changes found |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 262900bd47ddaa279b97f229b213f8a0ad796535 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
ec79443 to
83963cd
Compare
AtishayMsft
reviewed
Aug 2, 2023
packages/react-charting/src/components/GaugeChart/GaugeChart.base.tsx
Outdated
Show resolved
Hide resolved
AtishayMsft
reviewed
Aug 2, 2023
packages/react-charting/src/components/GaugeChart/GaugeChart.base.tsx
Outdated
Show resolved
Hide resolved
Collaborator
🕵 fluentuiv8 No visual regressions between this PR and main |
Contributor
|
Kshitij can you share a video of the improved behavior. |
AtishayMsft
approved these changes
May 20, 2024
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
May 21, 2024
* master: applying package updates applying package updates docs: Surfacing `Dropdown` and `Combobox` prop comments to docsite (microsoft#31430) (web-components) call click in button keydownHandler (microsoft#31428) Modify data and color codes for examples to fix accessibility issues (microsoft#31425) chore(deps): bump semver from 5.7.1 to 6.3.1 (microsoft#31420) applying package updates Improve gauge chart screen reader accessibility (microsoft#26682) applying package updates applying package updates
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The screen reader fails to announce the current value when the meter indicator is focused.
New Behavior
The screen reader announces the current value when the meter indicator is focused.
Video.Project.5.mp4