Skip to content

fix(pr-deploy-site): explicitly set types to not include whole @types/* globals which are causing issues with addition of @types/web#31465

Merged
Hotell merged 1 commit intomicrosoft:masterfrom
Hotell:fix/type-checking-issue-fix-v3
May 23, 2024
Merged

fix(pr-deploy-site): explicitly set types to not include whole @types/* globals which are causing issues with addition of @types/web#31465
Hotell merged 1 commit intomicrosoft:masterfrom
Hotell:fix/type-checking-issue-fix-v3

Conversation

@Hotell
Copy link
Contributor

@Hotell Hotell commented May 23, 2024

Previous Behavior

New Behavior

one more explicit types set, see follows PR at the bottom

Related Issue(s)

…/* globals which are cauising issues with addition of @types/web
@github-actions github-actions bot added this to the April Project Cycle Q1 2024 milestone May 23, 2024
@Hotell Hotell marked this pull request as ready for review May 23, 2024 13:51
@Hotell Hotell requested a review from a team as a code owner May 23, 2024 13:51
@Hotell Hotell enabled auto-merge (squash) May 23, 2024 13:51
@fabricteam
Copy link
Collaborator

📊 Bundle size report

✅ No changes found

@Hotell Hotell merged commit b45f592 into microsoft:master May 23, 2024
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@Hotell Hotell deleted the fix/type-checking-issue-fix-v3 branch May 23, 2024 15:43
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request May 28, 2024
* master: (49 commits)
  Update focus order in sankey chart for vertical navigation (microsoft#31469)
  chore: use new performant 'type-check' for v9 libaries (microsoft#31454)
  applying package updates
  fix(Timepicker-compat): clearIcon not working in freeform (microsoft#31324)
  chore: re-enable lint rule (microsoft#31459)
  feat(react-tag-picker): adds text property to TagPickerOption (microsoft#31474)
  feat(recipes): create package with initial implementation (moved from /apps) (microsoft#31386)
  applying package updates
  applying package updates
  chore: revert globals changes (microsoft#31470)
  (web-components) Use `ElementInternals` for TextInput elements (microsoft#31201)
  chore:(docs) Update and migrate component implementation guide (microsoft#31398)
  disallow all globals in Fluent v9 (microsoft#30967)
  chore:(react-nav-preview) Recomposing more components and some pixel pushing (microsoft#31387)
  fix(pr-deploy-site): explicitly set types to not include whole @types/* globals which are causing issues with addition of @types/web (microsoft#31465)
  fix(recipes-react-components): explicitly set types to not include whole @types/* globals which are cauising issues with addition of @types/web (microsoft#31463)
  applying package updates
  applying package updates
  applying package updates
  Update IconDirectionContextProvider import to import from specific path (microsoft#31006)
  ...
miroslavstastny pushed a commit to miroslavstastny/fluentui that referenced this pull request Jun 14, 2024
…/* globals which are causing issues with addition of @types/web (microsoft#31465)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants