feat(containers): add support for handling images that link to the CF registry by CarmenPopoviciu · Pull Request #9596 · cloudflare/workers-sdk

CarmenPopoviciu · 2025-06-13T08:39:20Z

Fixes DEVX-1966.

the first commit adds the pulling functionality, the second just makes manual testing a bit easier. e2e testing will happen in a followup.

Tests
- TODO (before merge)
- Tests included
- Tests not necessary because: to do in followup. manually tested. (tracking testing followup in DEVX-1980)
Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
- I don't know
- Required
- Not required because:
Public documentation
- TODO (before merge)
- Cloudflare docs PR(s):
- Documentation not necessary because: outside the scope of this PR
Wrangler V3 Backport
- TODO (before merge)
- Wrangler PR:
- Not necessary because: containers is an experimental feature

changeset-bot · 2025-06-13T08:39:24Z

🦋 Changeset detected

Latest commit: de266da

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages

Name	Type
@cloudflare/containers-shared	Patch
miniflare	Patch
wrangler	Patch
@cloudflare/pages-shared	Patch
@cloudflare/vite-plugin	Patch
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

pkg-pr-new · 2025-06-13T08:41:49Z

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9596

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9596

miniflare

npm i https://pkg.pr.new/miniflare@9596

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9596

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9596

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9596

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9596

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9596

wrangler

npm i https://pkg.pr.new/wrangler@9596

commit: de266da

CarmenPopoviciu · 2025-06-13T09:39:49Z

packages/miniflare/src/plugins/containers/service/index.ts

+				if (!isCloudflareRegistryLink(options.image)) {
+					throw new Error(
+						`Image ${options.image} is a registry link but does not point to the Cloudflare container registry.\n` +
+							`All images must use ${getCloudflareContainerRegistry()}, which is the default registry for Wrangler. To use an existing image from another repository, see https://developers.cloudflare.com/containers/image-management/#using-existing-images`


@mikenomitch is this the correct url I'm using here?

packages/containers-shared/src/knobs.ts

anonrig · 2025-06-13T19:46:40Z

packages/containers-shared/src/knobs.ts

+ * (defined as per `getCloudflareContainerRegistry` above)
+ */
+export function isCloudflareRegistryLink(image: string) {
+	const cfRegistry = getCloudflareContainerRegistry();


This will create a new string everytime it gets executed. Using something like this and definining cfRegistry in global scope will remove the unnecessary string allocation.

Suggested change

const cfRegistry = getCloudflareContainerRegistry();

cfRegistry ??= getCloudflareContainerRegistry();

packages/miniflare/src/plugins/containers/service/index.ts

packages/containers-shared/src/build.ts

packages/containers-shared/src/knobs.ts

packages/wrangler/src/api/startDevWorker/ConfigController.ts

packages/containers-shared/src/utils.ts

penalosa · 2025-06-19T12:51:23Z

packages/containers-shared/src/utils.ts

+	if (output === "0" && process.platform !== "linux") {
+		throw new Error(
+			`The container "${imageTag.replace(MF_DEV_CONTAINER_PREFIX + "/", "")}" does not expose any ports.\n` +
+				"To develop containers locally on non-Linux platforms, you must expose any ports that you call with `getTCPPort()` in your Dockerfile."


Could we link to the dockerfile EXPOSE docs here?

linking to external docs feels a bit weird, and they come up if you just search expose ports dockerfile. but happy to if you feel strongly about it.

Can we add a section in our docs about this?

i think @mikenomitch was going to do that already :) - i'll add a ticket to link to those docs when they're up

penalosa · 2025-06-19T12:51:53Z

packages/wrangler/src/api/startDevWorker/ConfigController.ts

+		(c) => !isDockerfile(c.image ?? c.configuration.image)
+	);
+	if (needsPulling && !resolved.dev.remote) {
+		await fillOpenAPIConfiguration(config, isNonInteractiveOrCI());


Does this pull in auth at all? ConfigController has an auth hook that we should use

talked about this offline, will leave sorting out containers auth out of this PR.

packages/containers-shared/src/images.ts

github-actions · 2025-06-19T15:11:29Z

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main carmen/registry-link-image might be a good starting point.

Notes:

your PR branch should be named v3-backport-9596
add the skip-v3-pr label to the current PR to stop this workflow from failing

emily-shen · 2025-06-20T16:38:45Z

tracking testing followup in DEVX-1980

…seba/containers_scope_debug * 'main' of ssh://github.com/cloudflare/workers-sdk: Version Packages (cloudflare#9697) add remote bindings support to `getPlatformProxy` (cloudflare#9688) feat(containers): add support for handling images that link to the CF registry (cloudflare#9596) CC-5418: Set instance_type in wrangler (cloudflare#9633) remove warnings during config validations on `experimental_remote` fields (cloudflare#9678) add debug logs for workerd (cloudflare#9640) `wrangler containers apply` uses `observability` configuration (cloudflare#9558) Version Packages (cloudflare#9658) Temporarily skip Openapi C3 e2e tests (cloudflare#9691) Skip authed fixture on forks (cloudflare#9681)

…seba/containers_scope * 'main' of ssh://github.com/cloudflare/workers-sdk: Add CLAUDE.md for Claude Code guidance (cloudflare#9563) Version Packages (cloudflare#9697) add remote bindings support to `getPlatformProxy` (cloudflare#9688) feat(containers): add support for handling images that link to the CF registry (cloudflare#9596) CC-5418: Set instance_type in wrangler (cloudflare#9633) remove warnings during config validations on `experimental_remote` fields (cloudflare#9678) add debug logs for workerd (cloudflare#9640) `wrangler containers apply` uses `observability` configuration (cloudflare#9558) Version Packages (cloudflare#9658) Temporarily skip Openapi C3 e2e tests (cloudflare#9691) Skip authed fixture on forks (cloudflare#9681)

alycda · 2025-09-27T23:26:55Z

packages/containers-shared/src/images.ts

+			if (!isCloudflareRegistryLink(options.image)) {
+				throw new Error(
+					`Image "${options.image}" is a registry link but does not point to the Cloudflare container registry.\n` +
+						`To use an existing image from another repository, see https://developers.cloudflare.com/containers/image-management/#using-existing-images`


this url is currently 404

resolved: ece4a43

workers-devprod added this to workers-sdk Jun 13, 2025

github-project-automation bot moved this to Untriaged in workers-sdk Jun 13, 2025

CarmenPopoviciu commented Jun 13, 2025

View reviewed changes

packages/containers-shared/src/knobs.ts Show resolved Hide resolved

anonrig reviewed Jun 13, 2025

View reviewed changes

emily-shen force-pushed the carmen/registry-link-image branch from 32412fd to cd4ae0e Compare June 18, 2025 10:54

workers-devprod added the e2e Run wrangler + vite-plugin e2e tests on a PR label Jun 18, 2025

emily-shen changed the base branch from main to emily/add-tag June 18, 2025 10:56

emily-shen force-pushed the carmen/registry-link-image branch from 72862dd to 26fc672 Compare June 18, 2025 12:46

emily-shen force-pushed the emily/add-tag branch from 2c3ab13 to 53508df Compare June 18, 2025 12:58

emily-shen force-pushed the carmen/registry-link-image branch from 26fc672 to c95089e Compare June 18, 2025 12:59

emily-shen force-pushed the emily/add-tag branch from 6a865db to fec57e7 Compare June 19, 2025 10:39

emily-shen force-pushed the carmen/registry-link-image branch from c95089e to 41b9899 Compare June 19, 2025 11:19

emily-shen reviewed Jun 19, 2025

View reviewed changes

packages/containers-shared/src/build.ts Show resolved Hide resolved

packages/containers-shared/src/build.ts Show resolved Hide resolved

packages/containers-shared/src/knobs.ts Show resolved Hide resolved

emily-shen marked this pull request as ready for review June 19, 2025 11:21

emily-shen requested a review from a team as a code owner June 19, 2025 11:21

penalosa reviewed Jun 19, 2025

View reviewed changes

emily-shen force-pushed the carmen/registry-link-image branch from ba43bc1 to 7e4fac7 Compare June 19, 2025 14:42

Base automatically changed from emily/add-tag to main June 19, 2025 14:56

emily-shen added 4 commits June 19, 2025 16:10

add pull

5cd918d

update fixture for easier manual testing

59134da

changeset

40763f8

pr feedback

de266da

emily-shen force-pushed the carmen/registry-link-image branch from 7e4fac7 to de266da Compare June 19, 2025 15:10

penalosa approved these changes Jun 19, 2025

View reviewed changes

github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jun 19, 2025

emily-shen added the skip-v3-pr label Jun 19, 2025

emily-shen enabled auto-merge June 19, 2025 16:06

CarmenPopoviciu disabled auto-merge June 20, 2025 15:33

CarmenPopoviciu added the every-os label Jun 20, 2025

CarmenPopoviciu merged commit 5162c51 into main Jun 20, 2025
54 of 56 checks passed

CarmenPopoviciu deleted the carmen/registry-link-image branch June 20, 2025 16:37

github-project-automation bot moved this from Approved to Done in workers-sdk Jun 20, 2025

workers-devprod mentioned this pull request Jun 20, 2025

Version Packages #9697

Merged

alycda reviewed Sep 27, 2025

View reviewed changes

alycda mentioned this pull request Sep 27, 2025

Image Management - existing containers link is 404 #10792

Closed

	const cfRegistry = getCloudflareContainerRegistry();
	cfRegistry ??= getCloudflareContainerRegistry();

Conversation

CarmenPopoviciu commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

pkg-pr-new bot commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

emily-shen Jun 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 19, 2025

Uh oh!

Uh oh!

emily-shen commented Jun 20, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

CarmenPopoviciu commented Jun 13, 2025 •

edited

Loading

changeset-bot bot commented Jun 13, 2025 •

edited

Loading

pkg-pr-new bot commented Jun 13, 2025 •

edited

Loading

emily-shen Jun 19, 2025 •

edited

Loading