Skip to content

CC-5418: Set instance_type in wrangler#9633

Merged
CarmenPopoviciu merged 34 commits intocloudflare:mainfrom
nikitassharma:nsharma/instance-type
Jun 20, 2025
Merged

CC-5418: Set instance_type in wrangler#9633
CarmenPopoviciu merged 34 commits intocloudflare:mainfrom
nikitassharma:nsharma/instance-type

Conversation

@nikitassharma
Copy link
Member

@nikitassharma nikitassharma commented Jun 17, 2025

The cloudchamber API already supports setting an instance type. This change will allow users to specify an instance type in wrangler. The specified instance type will be used configure vCPU, memory, and disk.

Implements CC-5418.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: The docs are private
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: We don't need to backport Cloudchamber changes to v3, since it's still private beta

@nikitassharma nikitassharma requested review from a team as code owners June 17, 2025 16:05
@changeset-bot
Copy link

changeset-bot bot commented Jun 17, 2025

🦋 Changeset detected

Latest commit: 3e60673

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jun 17, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9633

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9633

miniflare

npm i https://pkg.pr.new/miniflare@9633

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9633

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9633

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9633

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9633

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9633

wrangler

npm i https://pkg.pr.new/wrangler@9633

commit: 3e60673

@nikitassharma nikitassharma force-pushed the nsharma/instance-type branch from 2032ad3 to 6d13a80 Compare June 17, 2025 16:54
@CarmenPopoviciu CarmenPopoviciu added the e2e Run wrangler + vite-plugin e2e tests on a PR label Jun 18, 2025
@nikitassharma nikitassharma force-pushed the nsharma/instance-type branch 2 times, most recently from 88c1fd8 to a1b13e0 Compare June 19, 2025 16:33
@nikitassharma nikitassharma force-pushed the nsharma/instance-type branch from a1b13e0 to e21bbe9 Compare June 20, 2025 00:20
@nikitassharma
Copy link
Member Author

nikitassharma commented Jun 20, 2025

rebased on top of #9558

reverted the rebase as I can't merge into that PR since the branch belongs to a forked repo

@nikitassharma nikitassharma force-pushed the nsharma/instance-type branch from e21bbe9 to a1b13e0 Compare June 20, 2025 00:30
CarmenPopoviciu and others added 19 commits June 20, 2025 08:44
Co-authored-by: emily-shen <69125074+emily-shen@users.noreply.github.com>
Co-authored-by: emily-shen <69125074+emily-shen@users.noreply.github.com>
Co-authored-by: emily-shen <69125074+emily-shen@users.noreply.github.com>
Co-authored-by: emily-shen <69125074+emily-shen@users.noreply.github.com>
Co-authored-by: emily-shen <69125074+emily-shen@users.noreply.github.com>
Co-authored-by: emily-shen <69125074+emily-shen@users.noreply.github.com>
Co-authored-by: emily-shen <69125074+emily-shen@users.noreply.github.com>
@nikitassharma nikitassharma force-pushed the nsharma/instance-type branch from b1ac761 to 4db73c7 Compare June 20, 2025 15:45
Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approving

@CarmenPopoviciu CarmenPopoviciu merged commit 3f478af into cloudflare:main Jun 20, 2025
34 of 36 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jun 20, 2025
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label Jun 20, 2025
@holopin-bot
Copy link

holopin-bot bot commented Jun 20, 2025

Congratulations @nikitassharma, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cmc518jm11931707l5y620vofv

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

jseba added a commit to jseba/workers-sdk that referenced this pull request Jun 20, 2025
…seba/containers_scope_debug

* 'main' of ssh://github.com/cloudflare/workers-sdk:
  Version Packages (cloudflare#9697)
  add remote bindings support to `getPlatformProxy` (cloudflare#9688)
  feat(containers): add support for handling images that link to the CF registry (cloudflare#9596)
  CC-5418: Set instance_type in wrangler (cloudflare#9633)
  remove warnings during config validations on `experimental_remote` fields (cloudflare#9678)
  add debug logs for workerd (cloudflare#9640)
  `wrangler containers apply` uses `observability` configuration (cloudflare#9558)
  Version Packages (cloudflare#9658)
  Temporarily skip Openapi C3 e2e tests (cloudflare#9691)
  Skip authed fixture on forks (cloudflare#9681)
jseba added a commit to jseba/workers-sdk that referenced this pull request Jun 21, 2025
…seba/containers_scope

* 'main' of ssh://github.com/cloudflare/workers-sdk:
  Add CLAUDE.md for Claude Code guidance (cloudflare#9563)
  Version Packages (cloudflare#9697)
  add remote bindings support to `getPlatformProxy` (cloudflare#9688)
  feat(containers): add support for handling images that link to the CF registry (cloudflare#9596)
  CC-5418: Set instance_type in wrangler (cloudflare#9633)
  remove warnings during config validations on `experimental_remote` fields (cloudflare#9678)
  add debug logs for workerd (cloudflare#9640)
  `wrangler containers apply` uses `observability` configuration (cloudflare#9558)
  Version Packages (cloudflare#9658)
  Temporarily skip Openapi C3 e2e tests (cloudflare#9691)
  Skip authed fixture on forks (cloudflare#9681)
@nikitassharma nikitassharma deleted the nsharma/instance-type branch June 24, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution [Holopin] Recognizes an open-source contribution, big or small e2e Run wrangler + vite-plugin e2e tests on a PR

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

7 participants