Skip to content

Skip authed fixture on forks#9681

Merged
CarmenPopoviciu merged 3 commits intomainfrom
penalosa-patch-13
Jun 20, 2025
Merged

Skip authed fixture on forks#9681
CarmenPopoviciu merged 3 commits intomainfrom
penalosa-patch-13

Conversation

@penalosa
Copy link
Contributor

Skip the vitest fixture for remote bindings if no credentials are available (i.e. on forks)

@changeset-bot
Copy link

changeset-bot bot commented Jun 19, 2025

⚠️ No Changeset found

Latest commit: 2f8d57b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jun 19, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jun 19, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9681

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9681

miniflare

npm i https://pkg.pr.new/miniflare@9681

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9681

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9681

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9681

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9681

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9681

wrangler

npm i https://pkg.pr.new/wrangler@9681

commit: 2f8d57b

@penalosa penalosa added the skip-pr-description-validation Skip validation of the required PR description format label Jun 19, 2025
@penalosa
Copy link
Contributor Author

@claude can you fix the formatting issues in this PR?

@claude
Copy link
Contributor

claude bot commented Jun 19, 2025

Claude finished @penalosa's task —— View job


I've fixed the formatting issues in this PR.

Todo List

  • Read the changed file to identify formatting issues
  • Fix any formatting problems found
  • Commit the fixes to the PR branch

Changes Made

Fixed formatting issues in fixtures/vitest-pool-workers-remote-bindings/run-tests.mjs:

  • Line length compliance: Split long lines that exceeded the 80-character limit configured in Prettier
  • Improved readability: Added proper line breaks and indentation for the conditional statement, template literal assignment, and function call
  • Consistent formatting: Ensured all changes follow the project's Prettier configuration (tabs, 80-char limit, proper spacing)

The changes ensure the code complies with the project's formatting standards while maintaining the same functionality.

Commit: c845fbf

- Split long lines to comply with 80 character limit
- Improve readability with proper line breaks and indentation

Co-authored-by: Somhairle MacLeòid <penalosa@users.noreply.github.com>
@dom96
Copy link
Contributor

dom96 commented Jun 19, 2025

Thank you @penalosa!

Copy link

@offensive-vk offensive-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally!

@CarmenPopoviciu CarmenPopoviciu merged commit 86eb8f9 into main Jun 20, 2025
24 of 25 checks passed
@CarmenPopoviciu CarmenPopoviciu deleted the penalosa-patch-13 branch June 20, 2025 08:28
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jun 20, 2025
emily-shen pushed a commit that referenced this pull request Jun 20, 2025
* Update run-tests.mjs

* Fix formatting issues in run-tests.mjs

- Split long lines to comply with 80 character limit
- Improve readability with proper line breaks and indentation

Co-authored-by: Somhairle MacLeòid <penalosa@users.noreply.github.com>

* fix format

---------

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Co-authored-by: Somhairle MacLeòid <penalosa@users.noreply.github.com>
jseba added a commit to jseba/workers-sdk that referenced this pull request Jun 20, 2025
…seba/containers_scope_debug

* 'main' of ssh://github.com/cloudflare/workers-sdk:
  Version Packages (cloudflare#9697)
  add remote bindings support to `getPlatformProxy` (cloudflare#9688)
  feat(containers): add support for handling images that link to the CF registry (cloudflare#9596)
  CC-5418: Set instance_type in wrangler (cloudflare#9633)
  remove warnings during config validations on `experimental_remote` fields (cloudflare#9678)
  add debug logs for workerd (cloudflare#9640)
  `wrangler containers apply` uses `observability` configuration (cloudflare#9558)
  Version Packages (cloudflare#9658)
  Temporarily skip Openapi C3 e2e tests (cloudflare#9691)
  Skip authed fixture on forks (cloudflare#9681)
jseba added a commit to jseba/workers-sdk that referenced this pull request Jun 21, 2025
…seba/containers_scope

* 'main' of ssh://github.com/cloudflare/workers-sdk:
  Add CLAUDE.md for Claude Code guidance (cloudflare#9563)
  Version Packages (cloudflare#9697)
  add remote bindings support to `getPlatformProxy` (cloudflare#9688)
  feat(containers): add support for handling images that link to the CF registry (cloudflare#9596)
  CC-5418: Set instance_type in wrangler (cloudflare#9633)
  remove warnings during config validations on `experimental_remote` fields (cloudflare#9678)
  add debug logs for workerd (cloudflare#9640)
  `wrangler containers apply` uses `observability` configuration (cloudflare#9558)
  Version Packages (cloudflare#9658)
  Temporarily skip Openapi C3 e2e tests (cloudflare#9691)
  Skip authed fixture on forks (cloudflare#9681)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-pr-description-validation Skip validation of the required PR description format

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

7 participants