wrangler containers apply uses observability configuration#9558
Conversation
🦋 Changeset detectedLatest commit: ba8af52 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
50cb2b0 to
62493cb
Compare
fe7a8b0 to
8ce46d6
Compare
packages/containers-shared/src/client/models/AccountDefaults.ts
Outdated
Show resolved
Hide resolved
packages/containers-shared/src/client/models/ApplicationConstraintPop.ts
Show resolved
Hide resolved
packages/containers-shared/src/client/models/ApplicationHealthInstances.ts
Show resolved
Hide resolved
vicb
left a comment
There was a problem hiding this comment.
The description of this PR is currently
Enable Observability logging for containers if it is enabled using the top-level field in a Wrangler configuration file.
Could you please expand?
There are many changes in this PR and it's not clear how they relate to the description
I apologize for it. Most of the changes is not relevant to the PR description. I had to update the autogenerated client code. The only relevant changes are in |
emily-shen
left a comment
There was a problem hiding this comment.
hey really sorry this is taking a while close to the release deadline, i'm just a bit confused by the changes. in the future would it be possible to break out separate api changes into separate PRs, or even just separate commits? also, when you make changes after pr feedback, could you add that as a separate commit instead of squashing? we squash merge into main anyway, and this just makes it possible for reviewers to know what's changed. thanks 🧡
5461567 to
e4ff5c0
Compare
No problem, only saying the PR description is what I read first before reviewing the code and it would be helpful to add more context there. |
1318dfd to
aadb8de
Compare
aadb8de to
9f238a2
Compare
a77660f to
10fcace
Compare
10fcace to
ba8af52
Compare
…seba/containers_scope_debug * 'main' of ssh://github.com/cloudflare/workers-sdk: Version Packages (cloudflare#9697) add remote bindings support to `getPlatformProxy` (cloudflare#9688) feat(containers): add support for handling images that link to the CF registry (cloudflare#9596) CC-5418: Set instance_type in wrangler (cloudflare#9633) remove warnings during config validations on `experimental_remote` fields (cloudflare#9678) add debug logs for workerd (cloudflare#9640) `wrangler containers apply` uses `observability` configuration (cloudflare#9558) Version Packages (cloudflare#9658) Temporarily skip Openapi C3 e2e tests (cloudflare#9691) Skip authed fixture on forks (cloudflare#9681)
…seba/containers_scope * 'main' of ssh://github.com/cloudflare/workers-sdk: Add CLAUDE.md for Claude Code guidance (cloudflare#9563) Version Packages (cloudflare#9697) add remote bindings support to `getPlatformProxy` (cloudflare#9688) feat(containers): add support for handling images that link to the CF registry (cloudflare#9596) CC-5418: Set instance_type in wrangler (cloudflare#9633) remove warnings during config validations on `experimental_remote` fields (cloudflare#9678) add debug logs for workerd (cloudflare#9640) `wrangler containers apply` uses `observability` configuration (cloudflare#9558) Version Packages (cloudflare#9658) Temporarily skip Openapi C3 e2e tests (cloudflare#9691) Skip authed fixture on forks (cloudflare#9681)
Enable Observability logging for containers if it is enabled using the top-level field in a Wrangler configuration file.