Skip to content

chore: Bump to version 0.45.0 to start release process#4088

Merged
Xuanwo merged 6 commits intoapache:mainfrom
morristai:bump-0.45.0
Jan 31, 2024
Merged

chore: Bump to version 0.45.0 to start release process#4088
Xuanwo merged 6 commits intoapache:mainfrom
morristai:bump-0.45.0

Conversation

@morristai
Copy link
Copy Markdown
Member

@morristai morristai commented Jan 29, 2024 •
edited
Loading

What's Changed

Added

Changed

Fixed

Docs

CI

Chore

New Contributors

@github-actions github-actions bot added the releases-note/chore The PR has a title that begins with "chore" or changes other small things that hard to tell label Jan 29, 2024
@github-actions github-actions bot requested review from oowl and silver-ymz January 29, 2024 17:29
@suyanhanx suyanhanx marked this pull request as ready for review January 30, 2024 02:30
@suyanhanx suyanhanx marked this pull request as draft January 30, 2024 02:31
@suyanhanx
Copy link
Copy Markdown
Member

suyanhanx commented Jan 30, 2024

Sorry for my misoperation😥

tisonkun
tisonkun reviewed Jan 30, 2024
View reviewed changes
bin/oay/DEPENDENCIES.rust.tsv
@@ -1,289 +0,0 @@
crate 0BSD Apache-2.0 Apache-2.0 WITH LLVM-exception BSD-2-Clause BSD-3-Clause BSL-1.0 CC0-1.0 ISC MIT MPL-2.0 OpenSSL Unicode-DFS-2016 Unlicense Zlib
Copy link
Copy Markdown
Member

@tisonkun tisonkun Jan 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks strange. Why this file is cleared?

Copy link
Copy Markdown
Member Author

@morristai morristai Jan 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. (My apologies, I overlooked the [workspace.dependencies] version in Cargo.toml. Since this version doesn't include the patch version, when I searched for the last version, which is 0.44.2, it didn't show up.)

opendal/Cargo.toml

Line 61 in ddca18b

opendal = { version = "0.45", path = "core" }

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Jan 30, 2024

Hi, @morristai, please only push tags from the main branch after the PR has been merged.

@morristai
Copy link
Copy Markdown
Member Author

morristai commented Jan 30, 2024

Hi, @morristai, please only push tags from the main branch after the PR has been merged.

Sorry, my mistake. Can it be reverted?

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Jan 30, 2024

Sorry, my mistake. Can it be reverted?

No, we cannot remove a tag that has already been pushed. Fortunately, our build for rc1 failed, so we now need to push an rc.2 tag which will not impact our subsequent steps.

Xuanwo
Xuanwo reviewed Jan 30, 2024
View reviewed changes
@morristai
Copy link
Copy Markdown
Member Author

morristai commented Jan 30, 2024

Just FYI: For the unfinished task - Update core/src/docs/upgrade.md if there are breaking changes in the core, I haven't looked into the breaking changes. Please give me some time.

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Jan 30, 2024

Just FYI: For the unfinished task - Update core/src/docs/upgrade.md if there are breaking changes in the core, I haven't looked into the breaking changes. Please give me some time.

Let me update it.

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Jan 30, 2024

Hi, there are many changes after this PR created. Would you like to re-generate the changelog? Thanks!

@Zheaoli
Copy link
Copy Markdown
Member

Zheaoli commented Jan 30, 2024

Hi, there are many changes after this PR created. Would you like to re-generate the changelog? Thanks!

Should we create a version branch to lock on the feature and bugfix we need

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Jan 30, 2024

Should we create a version branch to lock on the feature and bugfix we need

Too complex for our project, not interested.

@morristai
Copy link
Copy Markdown
Member Author

morristai commented Jan 30, 2024

Should we also update the Haskell binding version in Cargo.toml? (It seems so, but the guide only mentions updating the version and the tag field of the source-repository in bindings/haskell/opendal.cabal.)

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Jan 30, 2024 •
edited
Loading

Should we also update the Haskell binding version in Cargo.toml?

The haskell binding will have separate release processes. Let's pin 0.44.2 for haskell and remove the path in it.

@morristai
Copy link
Copy Markdown
Member Author

morristai commented Jan 31, 2024 •
edited
Loading

Hi, there are many changes after this PR created. Would you like to re-generate the changelog? Thanks!

Done!

The haskell binding will have separate release processes. Let's pin 0.44.2 for haskell and remove the path in it.

Addressed

@morristai morristai marked this pull request as ready for review January 31, 2024 04:01
Xuanwo
Xuanwo approved these changes Jan 31, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 7190c07 into apache:main Jan 31, 2024
@morristai
Copy link
Copy Markdown
Member Author

morristai commented Jan 31, 2024

@Xuanwo Now I can push v0.45.0-rc.2 tag, right?

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Jan 31, 2024

@Xuanwo Now I can push v0.45.0-rc.2 tag, right?

Yes! Please push a tag on main branch 🥰

@morristai morristai deleted the bump-0.45.0 branch January 31, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tisonkun tisonkun tisonkun left review comments

@Xuanwo Xuanwo Xuanwo approved these changes

@oowl oowl Awaiting requested review from oowl oowl is a code owner

@silver-ymz silver-ymz Awaiting requested review from silver-ymz silver-ymz is a code owner

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

@messense messense Awaiting requested review from messense messense is a code owner

@Zheaoli Zheaoli Awaiting requested review from Zheaoli Zheaoli is a code owner

@suyanhanx suyanhanx Awaiting requested review from suyanhanx suyanhanx is a code owner

@xyjixyjixyji xyjixyjixyji Awaiting requested review from xyjixyjixyji xyjixyjixyji is a code owner

Assignees

No one assigned

Labels

releases-note/chore The PR has a title that begins with "chore" or changes other small things that hard to tell

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@morristai @suyanhanx @Xuanwo @Zheaoli @tisonkun