Merged
Conversation
Member
|
Thanks a lot for the change and the try to package oli on nixos. Would you like run cargo check under those packages to make sure cargo.lock generated? |
Member
|
Or do you want me to help do this? |
Some bindings are not part of the source for tagged releases. They need to be excluded from the main cargo.toml to allow building from source for a release
c11fbf1 to
c69d541
Compare
Contributor
Author
|
@Xuanwo done, completely forgot, thank you for reminding me. |
Member
|
Since those bindings are not workspace members anymore, their cargo.toml and cargo.lock also need to be updated. 👀 |
Member
|
All CI passed so that's shouldn't be contributors work to update them. Let's update by ourselves. |
Contributor
Author
|
@Xuanwo thanks a lot for the prompt review and for the help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the source released on github doesn't include
several bindings. This removes them from the
Cargo.toml to allow building from source
without this change, building from source results in errors like
to give more context, I'm trying to package oli for nixpkgs, this seems like a very useful tool.
thank you for your work on opendal, this looks amazing!