fix: list path recursive should not return path itself#4067
Merged
Xuanwo merged 1 commit intoapache:mainfrom Jan 25, 2024
Merged
fix: list path recursive should not return path itself#4067Xuanwo merged 1 commit intoapache:mainfrom
Xuanwo merged 1 commit intoapache:mainfrom
Conversation
Xuanwo
reviewed
Jan 25, 2024
Member
Xuanwo
left a comment
There was a problem hiding this comment.
Others LGTM, thanks for your contribution,
core/tests/behavior/blocking_list.rs
Outdated
| Ok(()) | ||
| } | ||
|
|
||
| fn list_recursive_helper(op: &BlockingOperator, parent: &str, path: &str) -> Result<Vec<String>> { |
Contributor
Author
|
waiting for #4070 |
Member
|
#4070 has been merged, please try again. |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4066