Skip to content

chore(bindings/ocaml): pinning OCaml binding opendal version for release#4086

Merged
Xuanwo merged 1 commit intoapache:mainfrom
Ranxy:ocaml_build
Jan 28, 2024
Merged

chore(bindings/ocaml): pinning OCaml binding opendal version for release#4086
Xuanwo merged 1 commit intoapache:mainfrom
Ranxy:ocaml_build

Conversation

@Ranxy
Copy link
Copy Markdown
Contributor

@Ranxy Ranxy commented Jan 28, 2024

Ref #4057
In this issue we discussed the release issue of OCaml binding. One solution is the current PR.
In this PR, the version of opendal is fixed so that the core directory is not required when building, so that when releasing, we can package this binding code separately.
At the same time, this PR also tested the results of building different OCaml versions and modified the OCaml version restrictions.
After this PR is merged, release OCaml binding requires the following steps:

  1. During release, package bindings/ocaml separately into something similar to apache-opendal-$release_version-binding-ocaml-src.tar.gz, and create its sha512 hash.
  2. Copy the opendal.opam file in binding/ocaml and append the following code
url {
   src: "https://github.com/apache/opendal/path_to_ocaml_binding_code.tar.gz"
   checksum: [
"sha512=hash"
   ]
}
  1. Go to https://github.com/ocaml/opam-repository to submit a PR. The content is the opendal.opam file modified in the previous step.
  2. Wait for the PR to be merged after the ci of opam is passed.

@Ranxy Ranxy requested review from PsiACE and Xuanwo as code owners January 28, 2024 14:03
@github-actions github-actions bot added the releases-note/chore The PR has a title that begins with "chore" or changes other small things that hard to tell label Jan 28, 2024
@github-actions github-actions bot requested review from oowl and silver-ymz January 28, 2024 14:03
@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Jan 28, 2024

After this PR is merged, release OCaml binding requires the following steps:

How about starting another issue to discuss the ocaml release process? We need to find way to make it integrate well with our ASF release.

Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/chore The PR has a title that begins with "chore" or changes other small things that hard to tell

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants