Updates the Basic01 test case specification#1257
Merged
Merged
Conversation
Co-authored-by: Marc van der Wal <103426270+marc-vanderwal@users.noreply.github.com>
Contributor
Author
|
@marc-vanderwal, please re-review and mark as resolved what you considered to be resolved. |
Co-authored-by: Marc van der Wal <103426270+marc-vanderwal@users.noreply.github.com>
Contributor
Author
|
@marc-vanderwal, please re-review. |
Co-authored-by: Marc van der Wal <103426270+marc-vanderwal@users.noreply.github.com>
marc-vanderwal
previously approved these changes
May 13, 2024
Contributor
Author
|
@tgreenx, could you review? |
tgreenx
previously approved these changes
May 14, 2024
tgreenx
left a comment
Contributor
There was a problem hiding this comment.
LGTM but I suggest to wait that #1255 and zonemaster/zonemaster-engine#1345 are completed before merging this one.
Contributor
Author
#1255 and zonemaster/zonemaster-engine#1345 are complete. |
tgreenx
added a commit
to tgreenx/zonemaster-engine
that referenced
this pull request
Jun 4, 2024
Based on: - Updated test case specification from zonemaster/zonemaster#1257 - New test zones specification from zonemaster/zonemaster#1255
tgreenx
added a commit
to tgreenx/zonemaster-engine
that referenced
this pull request
Jun 4, 2024
Based on: - Updated test case specification from zonemaster/zonemaster#1257 - New test zones specification from zonemaster/zonemaster#1255
tgreenx
reviewed
Jun 10, 2024
… (fake delegation)
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
tgreenx
reviewed
Jun 10, 2024
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
tgreenx
approved these changes
Jun 11, 2024
Contributor
Author
|
@marc-vanderwal, could you re-review? |
matsduf
added a commit
to matsduf/zonemaster
that referenced
this pull request
Jun 11, 2024
tgreenx
added a commit
to tgreenx/zonemaster-engine
that referenced
this pull request
Jun 11, 2024
Based on: - Updated test case specification from zonemaster/zonemaster#1257 - New test zones specification from zonemaster/zonemaster#1255
tgreenx
added a commit
to tgreenx/zonemaster-engine
that referenced
this pull request
Jun 11, 2024
Based on: - Updated test case specification from zonemaster/zonemaster#1257 - New test zones specification from zonemaster/zonemaster#1255
marc-vanderwal
approved these changes
Jun 12, 2024
tgreenx
added a commit
to tgreenx/zonemaster-engine
that referenced
this pull request
Jun 12, 2024
Based on: - Updated test case specification from zonemaster/zonemaster#1257 - New test zones specification from zonemaster/zonemaster#1255
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
There are deficiencies in algorithm to find the parent zone in the current specification. This PR tries to improved the algorithm.
Changes
The steps to traverse the delegation tree.
How to test this PR
Review it.