Adds test scenarios for Basic01#1255
Merged
matsduf merged 17 commits intoJun 12, 2024
Merged
Conversation
e4e14d9 to
50651e6
Compare
bd8f02c to
2caef1b
Compare
2caef1b to
8236049
Compare
marc-vanderwal
left a comment
Contributor
There was a problem hiding this comment.
Looks fine to me. I just see a few typos.
Co-authored-by: Marc van der Wal <103426270+marc-vanderwal@users.noreply.github.com>
marc-vanderwal
previously approved these changes
May 24, 2024
Contributor
Author
|
@tgreenx, can you approve this? |
tgreenx
added a commit
to tgreenx/zonemaster-engine
that referenced
this pull request
Jun 4, 2024
Based on: - Updated test case specification from zonemaster/zonemaster#1257 - New test zones specification from zonemaster/zonemaster#1255
tgreenx
added a commit
to tgreenx/zonemaster-engine
that referenced
this pull request
Jun 4, 2024
Based on: - Updated test case specification from zonemaster/zonemaster#1257 - New test zones specification from zonemaster/zonemaster#1255
tgreenx
reviewed
Jun 6, 2024
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
tgreenx
added a commit
to tgreenx/zonemaster-engine
that referenced
this pull request
Jun 11, 2024
Based on: - Updated test case specification from zonemaster/zonemaster#1257 - New test zones specification from zonemaster/zonemaster#1255
tgreenx
reviewed
Jun 11, 2024
tgreenx
added a commit
to tgreenx/zonemaster-engine
that referenced
this pull request
Jun 11, 2024
Based on: - Updated test case specification from zonemaster/zonemaster#1257 - New test zones specification from zonemaster/zonemaster#1255
tgreenx
added a commit
to tgreenx/zonemaster-engine
that referenced
this pull request
Jun 12, 2024
Based on: - Updated test case specification from zonemaster/zonemaster#1257 - New test zones specification from zonemaster/zonemaster#1255
tgreenx
reviewed
Jun 12, 2024
Contributor
There was a problem hiding this comment.
If I understand the purpose of this specific profile, it is to change the levels of some message tags related to Basic01 (from DEBUG to INFO) for easier readability in the output of Zonemaster-CLI.
I suggest that it is simplified, i.e. remove all test modules in the test_levels property unrelated to Basic01, and specify the property test_cases with only Basic01: "test_cases": [ "basic01" ]
Contributor
Author
There was a problem hiding this comment.
I see this as a temporary solution. I want to have one shared profile under "COMMON", and in another PR I do add that, but while waiting for that to be merged I created this profile file to make it work.
I have reduced it, but kept all Basic related messages plus SYSTEM.
Contributor
Author
There was a problem hiding this comment.
Yes, the purpose is to raise any relevant message from DEBUG to INFO to make it possible to have all relevant messages printed out without have a lot of other messages. That is the only purpose of the profile here.
tgreenx
approved these changes
Jun 12, 2024
This was referenced Jun 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds test scenarios for Basic01. The scenarios are based on the expected outcome of #1257.