Skip to content

Adds unit tests for Basic01#1345

Merged
matsduf merged 7 commits into
zonemaster:developfrom
matsduf:unit-tests-basic01
Jun 12, 2024
Merged

Adds unit tests for Basic01#1345
matsduf merged 7 commits into
zonemaster:developfrom
matsduf:unit-tests-basic01

Conversation

@matsduf

@matsduf matsduf commented May 12, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Purpose

This PR adds unit tests for Basic01 based on scenarios defined in zonemaster/zonemaster#1255. It is based on updated specification zonemaster/zonemaster#1257

Alll defined scenarios have been implemented.

The following scenarios will not work with the current implementation:

	Scenario CHLD-FOUND-INCONSIST-9 cannot be tested.
	Scenario GOOD-MIXED-1 cannot be tested.
	Scenario GOOD-MIXED-UNDEL-1 cannot be tested.
	Scenario NO-CHLD-NO-PAR-1 cannot be tested.
	Scenario NO-DEL-MIXED-UNDEL-1 cannot be tested.
	Scenario NO-DEL-MIXED-UNDEL-2 cannot be tested.
	Scenario NO-DEL-UNDEL-1 cannot be tested.
	Scenario NO-DEL-UNDEL-NO-PAR-1 cannot be tested.
	Scenario NO-DEL-UNDEL-PAR-UND-1 cannot be tested.
	Scenario ZONE-ERR-GRANDPARENT-1 cannot be tested.
	Scenario ZONE-ERR-GRANDPARENT-2 cannot be tested.
	Scenario ZONE-ERR-GRANDPARENT-3 cannot be tested.

This PR depends on #1340

Changed files

Only the following files truely belong to this PR:

  • t/Test-basic01.data
  • t/Test-basic01.t

One minor update to t/TestUtil.pm has sneaked in.

How to test this PR

Review the scenarios.

@matsduf matsduf added the A-TestCase Area: Test case specification or implementation of test case label May 12, 2024
@matsduf matsduf added this to the v2024.1 milestone May 12, 2024
@matsduf matsduf force-pushed the unit-tests-basic01 branch 2 times, most recently from 80dce5b to 5d114c0 Compare May 14, 2024 12:28
@matsduf

matsduf commented May 14, 2024

Copy link
Copy Markdown
Contributor Author

@tgreenx, could you review this?

@tgreenx tgreenx mentioned this pull request May 14, 2024
Merged
@tgreenx tgreenx added the V-Minor Versioning: The change gives an update of minor in version. label May 14, 2024
tgreenx
tgreenx reviewed May 14, 2024
View reviewed changes

@tgreenx tgreenx left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far.

Comment thread t/Test-basic01.t Outdated
@matsduf matsduf force-pushed the unit-tests-basic01 branch 3 times, most recently from 0a927b2 to 6f49d4f Compare May 21, 2024 13:20
marc-vanderwal
marc-vanderwal previously approved these changes May 24, 2024
View reviewed changes
@matsduf matsduf dismissed marc-vanderwal’s stale review May 24, 2024 11:24

The merge-base changed after approval.

marc-vanderwal
marc-vanderwal previously approved these changes May 24, 2024
View reviewed changes
@matsduf matsduf dismissed marc-vanderwal’s stale review May 24, 2024 14:19

The merge-base changed after approval.

@matsduf matsduf force-pushed the unit-tests-basic01 branch from ae123e0 to ce01bb3 Compare May 24, 2024 14:25
@matsduf matsduf requested review from marc-vanderwal and tgreenx May 24, 2024 14:30
@matsduf

matsduf commented May 27, 2024

Copy link
Copy Markdown
Contributor Author

@tgreenx, can you re-review?

@matsduf

matsduf commented Jun 3, 2024

Copy link
Copy Markdown
Contributor Author

@tgreenx, can you approve this? And also zonemaster/zonemaster#1255?

tgreenx
tgreenx reviewed Jun 4, 2024
View reviewed changes
Comment thread t/Test-basic01.t
@tgreenx tgreenx mentioned this pull request Jun 4, 2024
Merged
@matsduf matsduf merged commit 16a0630 into zonemaster:develop Jun 12, 2024
@matsduf matsduf deleted the unit-tests-basic01 branch June 12, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgreenx tgreenx tgreenx left review comments
@marc-vanderwal marc-vanderwal marc-vanderwal approved these changes
@mattias-p mattias-p Awaiting requested review from mattias-p

Assignees

No one assigned

Labels

A-TestCase Area: Test case specification or implementation of test case V-Minor Versioning: The change gives an update of minor in version.

Projects

None yet

Milestone

v2024.1

Development

Successfully merging this pull request may close these issues.

3 participants

@matsduf @tgreenx @marc-vanderwal