Allow always_allow for nushell, elvish, and rc#48395
Merged
Conversation
This un-reverts commit 72b151e which reverted PR #47908. The original PR introduced ShellKind::Posix(PosixShell) with sub-variants (Sh, Bash, Zsh, etc.) but caused a regression where Python toolchains (like uv) weren't detected. The bug was that activation scripts were stored with Posix(Sh) as the HashMap key, but looked up with the user's actual shell (e.g., Posix(Bash)), causing the lookup to fail. The fix uses activation_script_key() to normalize POSIX shell variants to Posix(Sh) before HashMap lookups. Added test_activation_script_key_normalizes_posix_shells to verify: - Direct lookup fails for different POSIX variants (the bug) - Lookup with activation_script_key() succeeds (the fix) - Non-POSIX shells are not normalized Fixes #48047
brush-parser handles ';' (sequential execution) and '|' (piping) which all these shells use, so we can safely parse their commands for always_allow pattern matching. This is a targeted AI-only change: supports_posix_chaining() is only called by agent/thread.rs and agent/tool_permissions.rs.
adb-sh
pushed a commit
to adb-sh/zed
that referenced
this pull request
Feb 5, 2026
`brush-parser` handles `;` (sequential execution) and `|` (piping) which all these shells use, so we can safely parse their commands for `always_allow` pattern matching. (No release notes because granular tool permissions haven't been released yet.) Release Notes: - N/A
rtfeldman
added a commit
that referenced
this pull request
Feb 5, 2026
`brush-parser` handles `;` (sequential execution) and `|` (piping) which all these shells use, so we can safely parse their commands for `always_allow` pattern matching. (No release notes because granular tool permissions haven't been released yet.) Release Notes: - N/A
naaiyy
added a commit
to Glass-HQ/Glass
that referenced
this pull request
Feb 16, 2026
Key changes: - Semantic highlighting support (zed-industries#46356) - major new editor feature - Edit predictions via Ollama (zed-industries#48233) - local AI edit predictions - Side-by-side diff: staging/unstaging/restoring on LHS, hunk controls, gutter highlights - Branch diff fix when committing/changing branches (zed-industries#48388) - Settings UI: AI tool permissions page (zed-industries#48277) - Version bump to v0.224 (kept our v0.0.1) - Close toasts on middle mouse click (zed-industries#48208) - DAP settings made optional (zed-industries#43647) - REPL quality of life improvements (zed-industries#47533) - Mercury accept/reject tracking (zed-industries#48306) - Toolbar menu and EP menu telemetry (zed-industries#48225, zed-industries#48229) - lsp::Symbol now includes container_name (zed-industries#46822) - Nushell/Elvish/Rc always_allow patterns (zed-industries#48395) - Agent terminal security rules expanded (zed-industries#48399) Conflict resolution: - collab/rpc.rs, collab_ui, collab editor_tests: deleted (collab removed) - vim (yank, replace, test): deleted (vim removed) - util/shell.rs: deleted (extracted to Obsydian-HQ/gpui) - GPUI (app.rs, windows/platform.rs, platform_scheduler.rs): deleted (Obsydian) - editor/items.rs: merged imports (added ExcerptId, ExcerptRange, kept SearchWithinRange) - lsp_store.rs: added SemanticTokensData import, removed GlobalLogStore/LanguageServerKind - proto.rs: added SemanticTokens to entity_messages, removed JoinProject/LeaveProject - lsp_button.rs: kept empty server UI, added is_via_ssh check from upstream - edit_prediction_button.rs: kept TitleBarItemView import - vscode_import.rs: added semantic_token_rules, removed helix_mode (not in our struct) - zed/Cargo.toml: kept v0.0.1 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brush-parserhandles;(sequential execution) and|(piping) which all these shells use, so we can safely parse their commands foralways_allowpattern matching.(No release notes because granular tool permissions haven't been released yet.)
Release Notes: