repl: Add quality of life changes in Jupyter view#47533
Merged
miguelraz merged 7 commits intozed-industries:mainfrom Feb 4, 2026
Merged
repl: Add quality of life changes in Jupyter view#47533miguelraz merged 7 commits intozed-industries:mainfrom
miguelraz merged 7 commits intozed-industries:mainfrom
Conversation
- this was causing the kernel to go in a state where it's displayed as idle but was actually never ready to process. Henceforth this is a better indicator in UI. - Stands as TODO after we get kernel recommendation finished from repl on to start the recommended kernel
- focus the cell editor, and move the caret to the start or end of the editor. - Next step: when moving to markdown enabled it's editor/ or not? skip them
rgbkrk
approved these changes
Jan 24, 2026
Collaborator
|
Since notebook is still behind a feature flag and has much to finish, we probably don't want release notes for this right @maxdeviant? |
Member
Yea, if it's still feature-flagged then we should "- N/A" the release notes. |
rgbkrk
reviewed
Jan 28, 2026
| original_cell_order: cell_order.clone(), | ||
| cell_map: cell_map.clone(), | ||
| kernel: Kernel::StartingKernel(Task::ready(()).shared()), | ||
| kernel: Kernel::Shutdown, // TODO: use recommended kernel after the implementation is done in repl |
Collaborator
There was a problem hiding this comment.
Makes sense for now. I trust you'll be hacking on that anyways as you're moving along with #47891.
rgbkrk
approved these changes
Jan 28, 2026
Collaborator
rgbkrk
left a comment
There was a problem hiding this comment.
Looking good, especially since we're feature flagged anyhow.
keymaps - Add default keybindings for NotebookEditor across platforms. - Propagate kernel language and kernelspec info into notebook metadata and update code cell languages via a new CodeCell::set_language. - Refactor `try_open` to support new/empty files and implement fallback parsing to patch missing cell IDs. - Optimize editor initialization to avoid cloning the entire notebook and fix edge cases when inserting/moving cells in empty notebooks.
rgbkrk
reviewed
Jan 29, 2026
| }); | ||
| } | ||
| cx.notify(); | ||
| } |
Collaborator
There was a problem hiding this comment.
👍
There's more metadata I think we're supposed to set to have parity but I can't recall at this moment. Good to push forward with for the moment though.
Contributor
Author
There was a problem hiding this comment.
Yeah we need to add signature for security.. and later on other optional metadata as well like author, title etc.
Collaborator
There was a problem hiding this comment.
The security one is kind of interesting since Jupyter devs put that in place for html outputs, which Zed/GPUI doesn't support and if we did they'd be in isolated web views anyhow.
rgbkrk
approved these changes
Feb 3, 2026
adb-sh
pushed a commit
to adb-sh/zed
that referenced
this pull request
Feb 5, 2026
- Keyboard navigation where you can traverse through cells using up and down arrow - Jupyter Logo added - Initialize kernel as shutdown for more predictable behavior - Ability to create .ipynb files with bare essential metadata. - Optimize editor initialization to avoid cloning the entire notebook and shortcuts Release Notes: - N/A --------- Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
rtfeldman
pushed a commit
that referenced
this pull request
Feb 5, 2026
- Keyboard navigation where you can traverse through cells using up and down arrow - Jupyter Logo added - Initialize kernel as shutdown for more predictable behavior - Ability to create .ipynb files with bare essential metadata. - Optimize editor initialization to avoid cloning the entire notebook and shortcuts Release Notes: - N/A --------- Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
naaiyy
added a commit
to Glass-HQ/Glass
that referenced
this pull request
Feb 16, 2026
Key changes: - Semantic highlighting support (zed-industries#46356) - major new editor feature - Edit predictions via Ollama (zed-industries#48233) - local AI edit predictions - Side-by-side diff: staging/unstaging/restoring on LHS, hunk controls, gutter highlights - Branch diff fix when committing/changing branches (zed-industries#48388) - Settings UI: AI tool permissions page (zed-industries#48277) - Version bump to v0.224 (kept our v0.0.1) - Close toasts on middle mouse click (zed-industries#48208) - DAP settings made optional (zed-industries#43647) - REPL quality of life improvements (zed-industries#47533) - Mercury accept/reject tracking (zed-industries#48306) - Toolbar menu and EP menu telemetry (zed-industries#48225, zed-industries#48229) - lsp::Symbol now includes container_name (zed-industries#46822) - Nushell/Elvish/Rc always_allow patterns (zed-industries#48395) - Agent terminal security rules expanded (zed-industries#48399) Conflict resolution: - collab/rpc.rs, collab_ui, collab editor_tests: deleted (collab removed) - vim (yank, replace, test): deleted (vim removed) - util/shell.rs: deleted (extracted to Obsydian-HQ/gpui) - GPUI (app.rs, windows/platform.rs, platform_scheduler.rs): deleted (Obsydian) - editor/items.rs: merged imports (added ExcerptId, ExcerptRange, kept SearchWithinRange) - lsp_store.rs: added SemanticTokensData import, removed GlobalLogStore/LanguageServerKind - proto.rs: added SemanticTokens to entity_messages, removed JoinProject/LeaveProject - lsp_button.rs: kept empty server UI, added is_via_ssh check from upstream - edit_prediction_button.rs: kept TitleBarItemView import - vscode_import.rs: added semantic_token_rules, removed helix_mode (not in our struct) - zed/Cargo.toml: kept v0.0.1 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes: