Skip to content

project: Make individual DAP settings optional#43647

Merged
MrSubidubi merged 1 commit intozed-industries:mainfrom
fredr:optional-dap-settings
Feb 4, 2026
Merged

project: Make individual DAP settings optional#43647
MrSubidubi merged 1 commit intozed-industries:mainfrom
fredr:optional-dap-settings

Conversation

@fredr
Copy link
Contributor

@fredr fredr commented Nov 27, 2025

Currently, when overriding e.g a binary in dap settings, one have to override all settings, including args as it otherwise set it to empty string.

E.g this config will set args and env to their empty states, like empty string and empty map:

{
  "dap": {
    "Delve": {
      "binary": "/path/to/binary"
    }
  }
}

This PR changes so that it is instead possible to only override a single field. This is useful e.g on nixos where you don't want (or cant let) zed download binaries for you, but you want to use the default args, such as in Delve, you want zed to configure it with a random listening port.

Release Notes:

  • Improved dap settings so that it is possible to override individual fields, such as binary

@cla-bot
Copy link

cla-bot bot commented Nov 27, 2025

We require contributors to sign our Contributor License Agreement, and we don't have @fredr on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@fredr fredr changed the title dap: make individual dap settings optional dap: Make individual dap settings optional Nov 27, 2025
@fredr
Copy link
Contributor Author

fredr commented Nov 27, 2025

@cla-bot check

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Nov 27, 2025
@cla-bot
Copy link

cla-bot bot commented Nov 27, 2025

The cla-bot has been summoned, and re-checked this pull request!

@fredr
Copy link
Contributor Author

fredr commented Jan 30, 2026

@Anthony-Eid sorry to ping, hope that is ok (you were assigned). Just wanted to check if there is any feedback on this, or if this is not the approach you guys want in zed? or if there is any clarification needed

@MrSubidubi MrSubidubi changed the title dap: Make individual dap settings optional project: Make individual DAP settings optional Feb 4, 2026
@MrSubidubi MrSubidubi self-assigned this Feb 4, 2026
Copy link
Member

@MrSubidubi MrSubidubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, thanks! And congratulations to your first contribution! 🎉

@MrSubidubi MrSubidubi merged commit c43dba1 into zed-industries:main Feb 4, 2026
29 checks passed
@github-project-automation github-project-automation bot moved this from Community PRs to Done in Quality Week – December 2025 Feb 4, 2026
@fredr fredr deleted the optional-dap-settings branch February 4, 2026 20:56
adb-sh pushed a commit to adb-sh/zed that referenced this pull request Feb 5, 2026
Currently, when overriding e.g a `binary` in dap settings, one have to
override all settings, including `args` as it otherwise set it to empty
string.

E.g this config will set `args` and `env` to their empty states, like
empty string and empty map:
```json
{
  "dap": {
    "Delve": {
      "binary": "/path/to/binary"
    }
  }
}
```

This PR changes so that it is instead possible to only override a single
field. This is useful e.g on nixos where you don't want (or cant let)
zed download binaries for you, but you want to use the default args,
such as in Delve, you want zed to configure it with a random listening
port.

Release Notes:

- Improved dap settings so that it is possible to override individual
fields, such as `binary`
rtfeldman pushed a commit that referenced this pull request Feb 5, 2026
Currently, when overriding e.g a `binary` in dap settings, one have to
override all settings, including `args` as it otherwise set it to empty
string.

E.g this config will set `args` and `env` to their empty states, like
empty string and empty map:
```json
{
  "dap": {
    "Delve": {
      "binary": "/path/to/binary"
    }
  }
}
```

This PR changes so that it is instead possible to only override a single
field. This is useful e.g on nixos where you don't want (or cant let)
zed download binaries for you, but you want to use the default args,
such as in Delve, you want zed to configure it with a random listening
port.

Release Notes:

- Improved dap settings so that it is possible to override individual
fields, such as `binary`
naaiyy added a commit to Glass-HQ/Glass that referenced this pull request Feb 16, 2026
Key changes:
- Semantic highlighting support (zed-industries#46356) - major new editor feature
- Edit predictions via Ollama (zed-industries#48233) - local AI edit predictions
- Side-by-side diff: staging/unstaging/restoring on LHS, hunk controls, gutter highlights
- Branch diff fix when committing/changing branches (zed-industries#48388)
- Settings UI: AI tool permissions page (zed-industries#48277)
- Version bump to v0.224 (kept our v0.0.1)
- Close toasts on middle mouse click (zed-industries#48208)
- DAP settings made optional (zed-industries#43647)
- REPL quality of life improvements (zed-industries#47533)
- Mercury accept/reject tracking (zed-industries#48306)
- Toolbar menu and EP menu telemetry (zed-industries#48225, zed-industries#48229)
- lsp::Symbol now includes container_name (zed-industries#46822)
- Nushell/Elvish/Rc always_allow patterns (zed-industries#48395)
- Agent terminal security rules expanded (zed-industries#48399)

Conflict resolution:
- collab/rpc.rs, collab_ui, collab editor_tests: deleted (collab removed)
- vim (yank, replace, test): deleted (vim removed)
- util/shell.rs: deleted (extracted to Obsydian-HQ/gpui)
- GPUI (app.rs, windows/platform.rs, platform_scheduler.rs): deleted (Obsydian)
- editor/items.rs: merged imports (added ExcerptId, ExcerptRange, kept SearchWithinRange)
- lsp_store.rs: added SemanticTokensData import, removed GlobalLogStore/LanguageServerKind
- proto.rs: added SemanticTokens to entity_messages, removed JoinProject/LeaveProject
- lsp_button.rs: kept empty server UI, added is_via_ssh check from upstream
- edit_prediction_button.rs: kept TitleBarItemView import
- vscode_import.rs: added semantic_token_rules, removed helix_mode (not in our struct)
- zed/Cargo.toml: kept v0.0.1

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

Development

Successfully merging this pull request may close these issues.

3 participants