Use SharedString::new_static for string literals#47865
Merged
Anthony-Eid merged 1 commit intozed-industries:mainfrom Jan 28, 2026
Merged
Use SharedString::new_static for string literals#47865Anthony-Eid merged 1 commit intozed-industries:mainfrom
SharedString::new_static for string literals#47865Anthony-Eid merged 1 commit intozed-industries:mainfrom
Conversation
basically just replaced `SharedString::new("` with
`SharedShring::new_static("`
Contributor
|
Thank you for contributing! This looks good to me, waiting for tests to pass to merge |
naaiyy
added a commit
to Glass-HQ/Glass
that referenced
this pull request
Feb 16, 2026
Key changes: - Version bump v0.223 - Bold folder labels setting (zed-industries#47631) for project panel - min_size/max_size style methods in GPUI (zed-industries#47775) - Emoji typing fix (zed-industries#47835) - Heap allocation reductions in GPUI (zed-industries#47858) - Git graph: feature graph support (zed-industries#47861) - Editor: select to start/end of larger syntax node (zed-industries#47571) - Scroll position persistence moved to background with debounce (zed-industries#47834) - Markdown: improved double-click word selection (zed-industries#47844) - Language injections fix (zed-industries#46134) - SharedString::new_static for string literals (zed-industries#47865) - ACP registry improvements and agent deprecation banners Conflict resolutions: - Kept our version (0.0.1), not upstream's 0.223.0 - Removed vim settings from default.json, settings_content, settings_ui - Took upstream's bold_folder_labels in project panel - Removed deleted crate files (gpui, vim, util) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically just replaced
SharedString::new("withSharedShring::new_static("which removes the allocation toArc<str>.Unfortunately this can't be enforced at compile time without trait specialization which is only available on nightly. You could assert that
TypeId's differ, butTypeIdonly exists at runtime.Release Notes: