Skip to content

markdown: Improve double-click word selection using CharClassifier#47844

Merged
smitbarmase merged 1 commit intomainfrom
improve-markdown-word-selection
Jan 28, 2026
Merged

markdown: Improve double-click word selection using CharClassifier#47844
smitbarmase merged 1 commit intomainfrom
improve-markdown-word-selection

Conversation

@smitbarmase
Copy link
Member

@smitbarmase smitbarmase commented Jan 28, 2026

Previously, double-click word selection in markdown used simple space-based boundaries, so foo.bar() would be selected as a single word.

Now we use CharClassifier which properly handles word boundaries:

  • Regular markdown text: Punctuation (., (, ), etc.) now acts as word boundaries. Double-clicking on foo.bar() selects just foo or bar.
  • Code blocks: Uses the language's word characters. For example, in JavaScript, $foo and #bar are selected as whole words since $ and # are configured as word characters.

Release Notes:

  • Improved double-click word selection in Agent Panel to respect punctuation and language-specific word characters.

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jan 28, 2026
@smitbarmase smitbarmase merged commit 1c7fa87 into main Jan 28, 2026
30 checks passed
@smitbarmase smitbarmase deleted the improve-markdown-word-selection branch January 28, 2026 11:00
naaiyy added a commit to Glass-HQ/Glass that referenced this pull request Feb 16, 2026
Key changes:
- Version bump v0.223
- Bold folder labels setting (zed-industries#47631) for project panel
- min_size/max_size style methods in GPUI (zed-industries#47775)
- Emoji typing fix (zed-industries#47835)
- Heap allocation reductions in GPUI (zed-industries#47858)
- Git graph: feature graph support (zed-industries#47861)
- Editor: select to start/end of larger syntax node (zed-industries#47571)
- Scroll position persistence moved to background with debounce (zed-industries#47834)
- Markdown: improved double-click word selection (zed-industries#47844)
- Language injections fix (zed-industries#46134)
- SharedString::new_static for string literals (zed-industries#47865)
- ACP registry improvements and agent deprecation banners

Conflict resolutions:
- Kept our version (0.0.1), not upstream's 0.223.0
- Removed vim settings from default.json, settings_content, settings_ui
- Took upstream's bold_folder_labels in project panel
- Removed deleted crate files (gpui, vim, util)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant