extensions_ui: Fix duplicated button element IDs preventing uninstall#47745
Merged
maxdeviant merged 3 commits intozed-industries:mainfrom Jan 27, 2026
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
MrSubidubi
previously requested changes
Jan 27, 2026
Member
MrSubidubi
left a comment
There was a problem hiding this comment.
Nice find, thank you for looking into this! One comment and we are good to merge.
Contributor
Author
|
Can you review again for my update? |
This comment was marked as spam.
This comment was marked as spam.
Member
|
Please stop pinging employees - we will tale a look once we find the time to do so. Thank you. |
This review has been addressed.
Contributor
Author
|
Thank you for your review |
Member
|
Also, congratulations to your first contribution! 🎉 |
Merged
benbrandt
added a commit
that referenced
this pull request
Jan 28, 2026
- **extensions_ui: Fix duplicated button element IDs preventing uninstall (#47745)** - **acp: Add agent server extension deprecation banner (#47817)** - **acp: Add upsell banner for built-in agents in registry page (#47853)** Release Notes: - Fixed extension uninstall button not working when an upgrade is available. --------- Co-authored-by: Dream <42954461+eureka928@users.noreply.github.com> Co-authored-by: Marshall Bowers <git@maxdeviant.com> Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
naaiyy
added a commit
to Glass-HQ/Glass
that referenced
this pull request
Feb 16, 2026
Key changes: - Reopen with encoding (zed-industries#46553) - new encoding selector with reopen support - Relative line jumps in go-to-line (zed-industries#46932) - Terminal tab renaming (zed-industries#45800) - Project search spinner while search underway (zed-industries#47620) - Git: retain "since" diffs, avoid unwrap in panel, don't rebuild diff on repo change - Extensions: fix duplicate button IDs preventing uninstall (zed-industries#47745) - SendKeystrokes: don't use layout key equivalents (zed-industries#47061) - Collab tests extracted to integration crate (deleted in our fork) - Various CI, docs, and agent improvements Conflict resolutions: - Kept native_button style, adopted extension_button_id() for unique IDs - Added encoding_selector::init alongside browser::init - Fixed _cx → cx rename for new encoding selector render code Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #47656
Release Notes: