terminal_view: Add ability to rename terminal tabs#45800
Merged
Veykril merged 3 commits intozed-industries:mainfrom Jan 27, 2026
Merged
terminal_view: Add ability to rename terminal tabs#45800Veykril merged 3 commits intozed-industries:mainfrom
Veykril merged 3 commits intozed-industries:mainfrom
Conversation
Contributor
|
Original: #44527 |
|
Nice work ! |
# Conflicts: # crates/workspace/src/pane.rs
cd91ae0 to
58d6204
Compare
|
I've tested both this PR and #44527 locally. Vote for this PR (#45800). The UX here is significantly better:
Great work @tacshi! Hope the core team can review and merge this soon. |
This comment has been minimized.
This comment has been minimized.
Veykril
reviewed
Jan 23, 2026
crates/workspace/src/pane.rs
Outdated
| // instead of just activating the item. | ||
| pane.unpreview_item_if_preview(item_id); | ||
| let extra_actions = item_handle.tab_extra_context_menu_actions(window, cx); | ||
| if let Some((_, action)) = extra_actions.into_iter().next() { |
Member
There was a problem hiding this comment.
lets do a find for the rename action instead of implicitly picking the first for whatever for now
Comment on lines
+137
to
+138
| cwd_serialized: bool, | ||
| custom_title_serialized: bool, |
Member
There was a problem hiding this comment.
Lets fold this into one bool, we only need to track if we need to serialize or not, no need to go too fine grained here
Comment on lines
+150
to
+151
| rename_editor: Entity<Editor>, | ||
| is_renaming: bool, |
Member
There was a problem hiding this comment.
Suggested change
| rename_editor: Entity<Editor>, | |
| is_renaming: bool, | |
| rename_editor: Option<Entity<Editor>>, |
makes more sense as encoding the bool
| scroll_top: Pixels, | ||
| scroll_handle: TerminalScrollHandle, | ||
| ime_state: Option<ImeState>, | ||
| last_tab_bounds: Option<Bounds<Pixels>>, |
| #[derive(Clone, Debug, Default, Deserialize, JsonSchema, PartialEq, Action)] | ||
| pub struct RenameTerminal { | ||
| #[serde(skip)] | ||
| pub position: Option<Point<Pixels>>, |
Contributor
auto-merge was automatically disabled
January 27, 2026 04:09
Head branch was pushed to by a user without write access
6 tasks
|
finally :) |
naaiyy
added a commit
to Glass-HQ/Glass
that referenced
this pull request
Feb 16, 2026
Key changes: - Reopen with encoding (zed-industries#46553) - new encoding selector with reopen support - Relative line jumps in go-to-line (zed-industries#46932) - Terminal tab renaming (zed-industries#45800) - Project search spinner while search underway (zed-industries#47620) - Git: retain "since" diffs, avoid unwrap in panel, don't rebuild diff on repo change - Extensions: fix duplicate button IDs preventing uninstall (zed-industries#47745) - SendKeystrokes: don't use layout key equivalents (zed-industries#47061) - Collab tests extracted to integration crate (deleted in our fork) - Various CI, docs, and agent improvements Conflict resolutions: - Kept native_button style, adopted extension_button_id() for unique IDs - Added encoding_selector::init alongside browser::init - Fixed _cx → cx rename for new encoding selector render code Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #ISSUE
Release Notes:
Recording:
zed_rename_terminal.mp4