Skip to content

Make workspace::SendKeystrokes not use layout key equivalents#47061

Merged
ConradIrwin merged 3 commits intozed-industries:mainfrom
everdrone:46509
Jan 27, 2026
Merged

Make workspace::SendKeystrokes not use layout key equivalents#47061
ConradIrwin merged 3 commits intozed-industries:mainfrom
everdrone:46509

Conversation

@everdrone
Copy link
Contributor

Closes #46509

Release Notes:

  • Fixed: workspace::SendKeystrokes would not allow remapping keys in different keyboard layouts

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jan 17, 2026
@maxdeviant maxdeviant changed the title SendKeystrokes should not use layout key equivalents Make workspace::SendKeystrokes not use layout key equivalents Jan 19, 2026
@ConradIrwin ConradIrwin enabled auto-merge (squash) January 27, 2026 03:18
@ConradIrwin
Copy link
Member

Thanks!

@ConradIrwin ConradIrwin merged commit c93773c into zed-industries:main Jan 27, 2026
27 checks passed
@kilork
Copy link

kilork commented Feb 5, 2026

I do not know, maybe not related, but looks related: with version v0.222.2 if I press on external keyboard Option + Enter in search - it does not work. My external keyboard is not Apple, it is some other vendor, and I map Option to Win, and Command to Alt. Previously this worked just fine.

@kilork
Copy link

kilork commented Feb 5, 2026

I do not know, maybe not related, but looks related: with version v0.222.2 if I press on external keyboard Option + Enter in search - it does not work. My external keyboard is not Apple, it is some other vendor, and I map Option to Win, and Command to Alt. Previously this worked just fine.

No, it is not related, no worries. Was related to Fn mode locked.

naaiyy added a commit to Glass-HQ/Glass that referenced this pull request Feb 16, 2026
Key changes:
- Reopen with encoding (zed-industries#46553) - new encoding selector with reopen support
- Relative line jumps in go-to-line (zed-industries#46932)
- Terminal tab renaming (zed-industries#45800)
- Project search spinner while search underway (zed-industries#47620)
- Git: retain "since" diffs, avoid unwrap in panel, don't rebuild diff on repo change
- Extensions: fix duplicate button IDs preventing uninstall (zed-industries#47745)
- SendKeystrokes: don't use layout key equivalents (zed-industries#47061)
- Collab tests extracted to integration crate (deleted in our fork)
- Various CI, docs, and agent improvements

Conflict resolutions:
- Kept native_button style, adopted extension_button_id() for unique IDs
- Added encoding_selector::init alongside browser::init
- Fixed _cx → cx rename for new encoding selector render code

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keymap not working as expected after updating to Zed 0.218.6

3 participants