ui: Don't show tooltip when ButtonLike is selected#13857
Merged
Conversation
This fixes the issue of a tooltip covering the thing that the button has revealed. It also mirrors what other UI frameworks do. Chrome on Linux behaves the same, and Safari does the same thing on macOS.
ConradIrwin
pushed a commit
that referenced
this pull request
Jul 19, 2024
…ected (#14832) Release Notes: - Fixed sometime tooltip will continuously display when the button is selected. --- @mrnugget The #13857 This change has led into a bug, the selected item before tooltip will continuous display if there are no other tooltips. https://github.com/user-attachments/assets/06b4a9a4-dede-4c18-b020-e20b6090341f
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jul 19, 2024
…ected (#14832) Release Notes: - Fixed sometime tooltip will continuously display when the button is selected. --- @mrnugget The #13857 This change has led into a bug, the selected item before tooltip will continuous display if there are no other tooltips. https://github.com/user-attachments/assets/06b4a9a4-dede-4c18-b020-e20b6090341f
ConradIrwin
pushed a commit
that referenced
this pull request
Jul 19, 2024
…ected (cherry-pick #14832) (#14835) Cherry-picked Fix tooltips sometimes continuously displaying when the button is selected (#14832) Release Notes: - Fixed sometime tooltip will continuously display when the button is selected. --- @mrnugget The #13857 This change has led into a bug, the selected item before tooltip will continuous display if there are no other tooltips. https://github.com/user-attachments/assets/06b4a9a4-dede-4c18-b020-e20b6090341f Co-authored-by: Jason Lee <huacnlee@gmail.com>
This was referenced Sep 27, 2024
bennetbo
added a commit
that referenced
this pull request
Sep 27, 2024
Reverts #13857. Hiding tooltips for selected buttons prevents tooltips like "Close x dock" from showing up, see #14938 for an example. The intention of the original PR was to hide the "Show application menu" tooltip, while the context menu is open. In order to fix this without breaking other UI elements, we track the state of the context menu using `PopoverMenuHandle` now, which allows us to prevent the tooltip from showing up while the context menu is open. Closes #14938 Release Notes: - Fixed an issue where some tooltips would not show up
noaccOS
pushed a commit
to noaccOS/zed
that referenced
this pull request
Oct 19, 2024
Reverts zed-industries#13857. Hiding tooltips for selected buttons prevents tooltips like "Close x dock" from showing up, see zed-industries#14938 for an example. The intention of the original PR was to hide the "Show application menu" tooltip, while the context menu is open. In order to fix this without breaking other UI elements, we track the state of the context menu using `PopoverMenuHandle` now, which allows us to prevent the tooltip from showing up while the context menu is open. Closes zed-industries#14938 Release Notes: - Fixed an issue where some tooltips would not show up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue of a tooltip covering the thing that the button has revealed.
It also mirrors what other UI frameworks do. Chrome on Linux behaves the same, and Safari does the same thing on macOS.
It fixes this:
Release Notes: