Skip to content

Fix tooltips sometimes continuously displaying when the button is selected#14832

Merged
ConradIrwin merged 1 commit intozed-industries:mainfrom
huacnlee:fix-tooltip-leark
Jul 19, 2024
Merged

Fix tooltips sometimes continuously displaying when the button is selected#14832
ConradIrwin merged 1 commit intozed-industries:mainfrom
huacnlee:fix-tooltip-leark

Conversation

@huacnlee
Copy link
Copy Markdown
Contributor

Release Notes:

  • Fixed sometime tooltip will continuously display when the button is selected.

@mrnugget The #13857 This change has led into a bug, the selected item before tooltip will continuous display if there are no other tooltips.

Tooltip.Bug.2024-07-20.004815.mp4

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jul 19, 2024
@maxdeviant maxdeviant changed the title Fixed sometime tooltip will continuously display when the button is selected Fix tooltips sometimes continuously displaying when the button is selected Jul 19, 2024
@ConradIrwin
Copy link
Copy Markdown
Member

/cherry-pick v0.145.x

@ConradIrwin ConradIrwin merged commit 0a02691 into zed-industries:main Jul 19, 2024
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jul 19, 2024
…ected (#14832)

Release Notes:

- Fixed sometime tooltip will continuously display when the button is
selected.

---

@mrnugget The #13857 This change has led into a bug, the selected item
before tooltip will continuous display if there are no other tooltips.



https://github.com/user-attachments/assets/06b4a9a4-dede-4c18-b020-e20b6090341f
@huacnlee huacnlee deleted the fix-tooltip-leark branch July 19, 2024 19:02
ConradIrwin pushed a commit that referenced this pull request Jul 19, 2024
…ected (cherry-pick #14832) (#14835)

Cherry-picked Fix tooltips sometimes continuously displaying when the
button is selected (#14832)

Release Notes:

- Fixed sometime tooltip will continuously display when the button is
selected.

---

@mrnugget The #13857 This change has led into a bug, the selected item
before tooltip will continuous display if there are no other tooltips.




https://github.com/user-attachments/assets/06b4a9a4-dede-4c18-b020-e20b6090341f

Co-authored-by: Jason Lee <huacnlee@gmail.com>
@mrnugget
Copy link
Copy Markdown
Contributor

Thank you! And thanks @ConradIrwin for merging/shipping!

mgsloan added a commit that referenced this pull request Jan 4, 2025
It's easy to overshoot the bottom of the tooltip when cursoring to a
button, such as opening the commit from a blame tooltip. Before this
change the tooltip would immediately disappear, and now it sticks
around for a bit.

Also:

* Shares the implementation with `elements/text.rs`. This will
particularly be handy when it makes use of hoverable tooltips. Also
means that it will use the same handling for mouse down / mouse
wheel (it did not handle mouse wheel before).

* Improves the fix to #21657.

    - Now the element will no longer think it has an active tooltip
    that it registers with the window.

    - It will instead display the next available tooltip, whereas
    I believe before the next available tooltip would be suppressed.

* Fixes bug where `cx.refresh()` wasn't called when text tooltip is
hidden due to a mouse down event.

* Ports over fix in #14832 to `elements/text.rs`
mgsloan added a commit that referenced this pull request Jan 4, 2025
It's easy to overshoot the bottom of the tooltip when cursoring to a
button, such as opening the commit from a blame tooltip. Before this
change the tooltip would immediately disappear, and now it sticks
around for a bit.

Also:

* Shares the implementation with `elements/text.rs`. This will
particularly be handy when it makes use of hoverable tooltips. Also
means that it will use the same handling for mouse down / mouse
wheel (it did not handle mouse wheel before).

* Improves the fix to #21657.

    - Now the element will no longer think it has an active tooltip
    that it registers with the window.

    - It will instead display the next available tooltip, whereas
    I believe before the next available tooltip would be suppressed.

* Fixes bug where `cx.refresh()` wasn't called when text tooltip is
hidden due to a mouse down event.

* Ports over fix in #14832 to `elements/text.rs`
mgsloan added a commit that referenced this pull request Jan 18, 2025
It's easy to overshoot the bottom of the tooltip when cursoring to a
button, such as opening the commit from a blame tooltip. Before this
change the tooltip would immediately disappear, and now it sticks
around for a bit.

Also:

* Shares the implementation with `elements/text.rs`. This will
particularly be handy when it makes use of hoverable tooltips. Also
means that it will use the same handling for mouse down / mouse
wheel (it did not handle mouse wheel before).

* Improves the fix to #21657.

    - Now the element will no longer think it has an active tooltip
    that it registers with the window.

    - It will instead display the next available tooltip, whereas
    I believe before the next available tooltip would be suppressed.

* Fixes bug where `cx.refresh()` wasn't called when text tooltip is
hidden due to a mouse down event.

* Ports over fix in #14832 to `elements/text.rs`
mgsloan added a commit that referenced this pull request Jan 18, 2025
It's easy to overshoot the bottom of the tooltip when cursoring to a
button, such as opening the commit from a blame tooltip. Before this
change the tooltip would immediately disappear, and now it sticks around
for a bit.

Also:

* Shares the implementation with `elements/text.rs`. This will
particularly be handy when it makes use of hoverable tooltips.

* Improves the fix to #21657.

- Now the element will no longer think it has an active tooltip that it
registers with the window.

- It will instead display the next available tooltip, whereas I believe
before the next available tooltip would be suppressed.

* Fixes bug where `cx.refresh()` wasn't called when text tooltip is
hidden due to a mouse down event.

* Ports over fix in #14832 to
`elements/text.rs`

Release Notes:

- The tooltip for inline git blame now waits a bit before disappearing
when the mouse leaves it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants