Skip to content

Fix missing tooltips for selected buttons#18435

Merged
bennetbo merged 3 commits intomainfrom
fix-tooltips-for-selected-button
Sep 27, 2024
Merged

Fix missing tooltips for selected buttons#18435
bennetbo merged 3 commits intomainfrom
fix-tooltips-for-selected-button

Conversation

@bennetbo
Copy link
Copy Markdown
Member

@bennetbo bennetbo commented Sep 27, 2024

Reverts #13857. Hiding tooltips for selected buttons prevents tooltips like "Close x dock" from showing up, see #14938 for an example.
The intention of the original PR was to hide the "Show application menu" tooltip, while the context menu is open.
In order to fix this without breaking other UI elements, we track the state of the context menu using PopoverMenuHandle now, which allows us to prevent the tooltip from showing up while the context menu is open.

Closes #14938

Release Notes:

  • Fixed an issue where some tooltips would not show up

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Sep 27, 2024
@bennetbo bennetbo merged commit 73ff8c0 into main Sep 27, 2024
@bennetbo bennetbo deleted the fix-tooltips-for-selected-button branch September 27, 2024 12:16
schpet added a commit to schpet/zed that referenced this pull request Oct 3, 2024
* upstream/main: (33 commits)
  Fine-tune hunk control spacing (zed-industries#18463)
  Add tooltip for code actions icon button (zed-industries#18461)
  More git hunk highlighting fixes (zed-industries#18459)
  Move git hunk controls to the left side (zed-industries#18460)
  Capitalize tooltip labels on buffer search (zed-industries#18458)
  Install cargo-edito without extra features (zed-industries#18457)
  Fix bugs in diff hunk highlighting (zed-industries#18454)
  Remove Qwen2 model (zed-industries#18444)
  vim: Command selection fixes (zed-industries#18424)
  Add a `get-release-notes-since` script (zed-industries#18445)
  Fix GoToDefinition changing the viewport unnecessarily (zed-industries#18441)
  docs: Ollama api_url improvements (zed-industries#18440)
  Fix missing tooltips for selected buttons (zed-industries#18435)
  Add missing shortcuts in tooltips (zed-industries#18282)
  assistant: Fix copy/cut not working when selection is empty (zed-industries#18403)
  Fix the numeration in line wrap docs (zed-industries#18428)
  ssh remoting: Show error if opening connection timed out (zed-industries#18401)
  project: Fix worktree store event missing in remote projects (zed-industries#18376)
  Fix read timeout for ollama (zed-industries#18417)
  vim: Support za (zed-industries#18421)
  ...
noaccOS pushed a commit to noaccOS/zed that referenced this pull request Oct 19, 2024
Reverts zed-industries#13857. Hiding tooltips for selected buttons prevents tooltips
like "Close x dock" from showing up, see zed-industries#14938 for an example.
The intention of the original PR was to hide the "Show application menu"
tooltip, while the context menu is open.
In order to fix this without breaking other UI elements, we track the
state of the context menu using `PopoverMenuHandle` now, which allows us
to prevent the tooltip from showing up while the context menu is open.

Closes zed-industries#14938

Release Notes:

- Fixed an issue where some tooltips would not show up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Panel button hover tooltips not working properly

1 participant