fix(webui): Submit queries that failed ANTLR validation to Presto. by davemarco · Pull Request #1450 · y-scope/clp

davemarco · 2025-10-20T16:44:52Z

Description

Currently there is a bug where if the error failed ANTLR validation, the error isnt shown in the webui. This PR sends queries that fails validation to Presto, and let's their analyzer come up with error to show user.

The long term plan is to use the ANTLR validator to highlight syntax errors in monaco, but not to actually generate errors on the full query. So this PR is also setting up the ANTLR error highlighting.

Checklist

The PR satisfies the contribution guidelines.
This is a breaking change and that has been indicated in the PR title, OR this isn't a
breaking change.
Necessary docs have been updated, OR no docs need to be updated.

Validation performed

Parser errors are now caught by presto, and only logged by ANTLR

Summary by CodeRabbit

Bug Fixes
- Application now gracefully handles SQL validation failures by continuing execution instead of interrupting the process, improving overall stability and resilience during query operations.

coderabbitai · 2025-10-20T16:45:18Z

Walkthrough

The SQL parser error handling behaviour has been modified to log validation failures instead of throwing errors. When SQL validity checks fail, the code now logs the error via console.error and returns the constructed query string, removing SyntaxError propagation from buildSearchQuery and buildTimelineQuery.

Changes

Cohort / File(s)	Change Summary
SQL Parser Error Handling `components/webui/client/src/sql-parser/index.ts`	Modified error handling to log validation failures via `console.error` instead of throwing `SyntaxError`, allowing query construction to continue and return results regardless of SQL validity

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant Parser as SQL Parser
    participant Console
    
    Caller->>Parser: buildSearchQuery/buildTimelineQuery
    Parser->>Parser: Construct query
    Parser->>Parser: Validate SQL
    
    rect rgb(200, 220, 255)
    Note over Parser: Previous Behavior
    Parser-->>Caller: ❌ throw SyntaxError
    end
    
    rect rgb(200, 255, 220)
    Note over Parser: New Behavior
    Parser->>Console: console.error(validation error)
    Parser->>Caller: ✓ return query string
    end

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

The change involves a single file with altered error handling semantics. Review should focus on understanding the implications of suppressing errors and ensuring this graceful degradation is intentional and won't mask critical issues in downstream consumers of this parser.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The PR title "fix(webui): Submit queries that failed ANTLR validation to Presto" directly aligns with the core change in the changeset. The raw summary shows that the primary modification removes error propagation on SQL validation failures and continues execution, allowing queries to be submitted to Presto regardless of ANTLR validation status. The title is concise, specific, and clearly conveys the technical change and its purpose without vague language or unnecessary details. A developer scanning the commit history would immediately understand that this fix allows previously-blocked queries to reach Presto for validation and error handling.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 11d73fb and 7cf59f8.

📒 Files selected for processing (1)

components/webui/client/src/sql-parser/index.ts (2 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

**/*.{cpp,hpp,java,js,jsx,tpp,ts,tsx}

⚙️ CodeRabbit configuration file

Prefer false == <expression> rather than !<expression>.

Files:

components/webui/client/src/sql-parser/index.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

GitHub Check: package-image
GitHub Check: rust-checks (macos-15)
GitHub Check: rust-checks (ubuntu-22.04)
GitHub Check: rust-checks (ubuntu-24.04)

🔇 Additional comments (1)

components/webui/client/src/sql-parser/index.ts (1)

17-18: SyntaxError export is required and correctly maintained.

Verification confirms that SyntaxError is not imported or used by any other code within the codebase itself. However, it remains necessary as an export because the validate function (also exported) throws this error and documents it in its JSDoc. External consumers calling validate need access to this class to handle the exception appropriately. The export is intentional for the public API contract, particularly for Monaco editor integration mentioned in the PR description.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

junhaoliao

deferring to @hoophalab 's review

* feat(webui): Add drawer to display guided query and errors. (y-scope#1421) * docs: Add Slack community invite badge to home page README. (y-scope#1418) * refactor(clp-package): Simplify StrEnum and Path serialization via Annotated serializers. (y-scope#1417) Co-authored-by: Junhao Liao <junhao@junhao.ca> Co-authored-by: Junhao Liao <junhao.liao@yscope.com> * build(clp-package): Adopt uv + hatchling as the build and packaging backend for Python components (resolves y-scope#1396); Upgrade dependencies for Python components. (y-scope#1405) * chore(docker): Add `--link` flags to COPY/ADD operations for improved build performance (fixes y-scope#1408). (y-scope#1411) * fix(ci): Correctly update and restore cache of `lint:check-cpp-lint-static-full`'s generated files (fixes y-scope#1419): (y-scope#1430) - Save cache entries using unique key per entry. - Restore latest entries using key prefix. - Avoid using outputs from optionally-run `restore` task. * fix(clp-rust-utils): Use AWS SDK default configuration with latest behavior version for S3 client. (y-scope#1445) Co-authored-by: Junhao Liao <junhao.liao@yscope.com> * refactor(clp-package): Remove unused `python-dotenv` dependency and related imports (fixes y-scope#1443). (y-scope#1444) * fix(webui): Submit queries that failed ANTLR validation to Presto. (y-scope#1450) * feat(clp-s): Explicitly reject unstructured log inputs during compression. (y-scope#1434) * feat(webui): Show query speed in native search status. (y-scope#1429) * fix(job-orchestration): Make `tag_ids` a required `list[int]` for compatibility with Spider compressor. (y-scope#1453) * feat(clp-mcp-server): Add log viewer links to query results for displaying in LLM output. (y-scope#1454) Co-authored-by: Junhao Liao <junhao.liao@yscope.com> * feat(ci): Add tasks for checking and updating Rust lock file (`Cargo.lock`); Add check to GH workflow. (y-scope#1448) * feat(webui): Trigger submit action when pressing Enter on Monaco single line editor. (y-scope#1459) * Add filters. * Update cargo lock. --------- Co-authored-by: davemarco <83603688+davemarco@users.noreply.github.com> Co-authored-by: Abigail Matthews <abigail.v.matthews@gmail.com> Co-authored-by: sitaowang1998 <sitaowang1998@outlook.com> Co-authored-by: Junhao Liao <junhao@junhao.ca> Co-authored-by: Junhao Liao <junhao.liao@yscope.com> Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com> Co-authored-by: Devin Gibson <gibber9809@users.noreply.github.com> Co-authored-by: hoophalab <200652805+hoophalab@users.noreply.github.com> Co-authored-by: Huangshi Tian <All-less@users.noreply.github.com>

* feat(webui): Add drawer to display guided query and errors. (y-scope#1421) * docs: Add Slack community invite badge to home page README. (y-scope#1418) * refactor(clp-package): Simplify StrEnum and Path serialization via Annotated serializers. (y-scope#1417) Co-authored-by: Junhao Liao <junhao@junhao.ca> Co-authored-by: Junhao Liao <junhao.liao@yscope.com> * build(clp-package): Adopt uv + hatchling as the build and packaging backend for Python components (resolves y-scope#1396); Upgrade dependencies for Python components. (y-scope#1405) * chore(docker): Add `--link` flags to COPY/ADD operations for improved build performance (fixes y-scope#1408). (y-scope#1411) * fix(ci): Correctly update and restore cache of `lint:check-cpp-lint-static-full`'s generated files (fixes y-scope#1419): (y-scope#1430) - Save cache entries using unique key per entry. - Restore latest entries using key prefix. - Avoid using outputs from optionally-run `restore` task. * fix(clp-rust-utils): Use AWS SDK default configuration with latest behavior version for S3 client. (y-scope#1445) Co-authored-by: Junhao Liao <junhao.liao@yscope.com> * refactor(clp-package): Remove unused `python-dotenv` dependency and related imports (fixes y-scope#1443). (y-scope#1444) * fix(webui): Submit queries that failed ANTLR validation to Presto. (y-scope#1450) * feat(clp-s): Explicitly reject unstructured log inputs during compression. (y-scope#1434) * feat(webui): Show query speed in native search status. (y-scope#1429) * fix(job-orchestration): Make `tag_ids` a required `list[int]` for compatibility with Spider compressor. (y-scope#1453) * feat(clp-mcp-server): Add log viewer links to query results for displaying in LLM output. (y-scope#1454) Co-authored-by: Junhao Liao <junhao.liao@yscope.com> * feat(ci): Add tasks for checking and updating Rust lock file (`Cargo.lock`); Add check to GH workflow. (y-scope#1448) * feat(webui): Trigger submit action when pressing Enter on Monaco single line editor. (y-scope#1459) * Add filters. * Update cargo lock. * Stupid fix --------- Co-authored-by: davemarco <83603688+davemarco@users.noreply.github.com> Co-authored-by: Abigail Matthews <abigail.v.matthews@gmail.com> Co-authored-by: sitaowang1998 <sitaowang1998@outlook.com> Co-authored-by: Junhao Liao <junhao@junhao.ca> Co-authored-by: Junhao Liao <junhao.liao@yscope.com> Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com> Co-authored-by: Devin Gibson <gibber9809@users.noreply.github.com> Co-authored-by: hoophalab <200652805+hoophalab@users.noreply.github.com> Co-authored-by: Huangshi Tian <All-less@users.noreply.github.com>

…-scope#1450)

marco added 2 commits October 20, 2025 12:23

latest

2de49bd

Merge branch 'main' into rm_val

7cf59f8

davemarco requested a review from hoophalab October 20, 2025 16:45

davemarco marked this pull request as ready for review October 20, 2025 16:47

davemarco requested a review from a team as a code owner October 20, 2025 16:47

hoophalab approved these changes Oct 20, 2025

View reviewed changes

junhaoliao approved these changes Oct 20, 2025

View reviewed changes

davemarco added 3 commits October 20, 2025 16:39

Merge branch 'main' into rm_val

0180ef4

Merge branch 'main' into rm_val

cdfe653

Merge branch 'main' into rm_val

09fd4c0

davemarco merged commit a0005c0 into y-scope:main Oct 21, 2025
22 checks passed

junhaoliao pushed a commit to junhaoliao/clp that referenced this pull request May 17, 2026

fix(webui): Submit queries that failed ANTLR validation to Presto. (y…

d291b96

…-scope#1450)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(webui): Submit queries that failed ANTLR validation to Presto. #1450

fix(webui): Submit queries that failed ANTLR validation to Presto. #1450
davemarco merged 5 commits into
y-scope:mainfrom
davemarco:rm_val

davemarco commented Oct 20, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Oct 20, 2025 •

edited

Loading

Uh oh!

junhaoliao left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

davemarco commented Oct 20, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Validation performed

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Pre-merge checks and finishing touches

Uh oh!

junhaoliao left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

davemarco commented Oct 20, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Oct 20, 2025 •

edited

Loading