feat(ci): Add tasks for checking and updating Rust lock file (`Cargo.lock`); Add check to GH workflow. by LinZhihao-723 · Pull Request #1448 · y-scope/clp

LinZhihao-723 · 2025-10-20T15:26:12Z

Description

NOTE: This PR depends on #1445.

This PR adds tasks to update and check Rust's dependency lock file (Cargo.lock):

deps:lock:check-rust for checking whether the lock file is up-to-date
deps:lock:update-rust for refreshing the lock file.

This PR also adds the check task into the Rust check workflow.

Checklist

The PR satisfies the contribution guidelines.
This is a breaking change and that has been indicated in the PR title, OR this isn't a
breaking change.
Necessary docs have been updated, OR no docs need to be updated.

Validation performed

Ensure all workflows pass.
Manually tested the task can report errors properly when the lock file is outdated.
Manually tested the task can update the lock file.

Summary by CodeRabbit

Chores
- Added a CI step to validate Rust dependency lock files before linting to ensure lock consistency.
- Added tasks to check and update Rust workspace dependency locks and integrated the lock task configuration into the repository task setup.

coderabbitai · 2025-10-20T15:26:42Z

Walkthrough

Adds a pre-lint CI step that validates Rust cargo lock files and introduces taskfiles to check or update cargo workspace locks; the CI workflow runs the new lock validation before the existing lint step.

Changes

Cohort / File(s)	Change Summary
CI workflow `.github/workflows/clp-rust-checks.yaml`	Inserts a new step named `Validate lock files` that runs `task deps:lock:check-rust` before the existing `Lint` step in the `rust-checks` job.
Rust dependency tasks `taskfiles/deps/lock.yaml`	New taskfile added defining tasks: `check-rust` (delegates to `cargo-workspace-update` with `CARGO_UPDATE_FLAGS="--locked"`), `update-rust` (delegates with empty flags), and internal `cargo-workspace-update` (sources cargo env, runs `cargo update` with provided flags in repo root).
Task includes `taskfiles/deps/main.yaml`	Adds `lock: "./lock.yaml"` to the includes mapping to incorporate the new lock taskfile.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant GH as GitHub Actions runner
  participant Job as rust-checks job
  participant Task as Task runner\n(`task deps:lock:check-rust`)
  participant CWU as cargo-workspace-update
  participant Cargo as `cargo update --locked`
  participant Lint as Lint step

  GH->>Job: start rust-checks
  Job->>Task: run "Validate lock files"
  Task->>CWU: invoke cargo-workspace-update\nwith CARGO_UPDATE_FLAGS="--locked"
  CWU->>Cargo: source $HOME/.cargo/env\nrun cargo update --locked
  Cargo-->>CWU: exit (success/failure)
  CWU-->>Task: return status
  alt success
    Task-->>Job: step success
    Job->>Lint: proceed to Lint step
  else failure
    Task-->>Job: step failure -> job fails
  end

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The pull request title "feat(ci): Add tasks for checking and updating Rust lock file (`Cargo.lock`); Add check to GH workflow." is fully related to the main changes in the changeset. It accurately describes the two primary objectives: the addition of Taskfile tasks (check-rust and update-rust) for managing Cargo.lock, and the integration of the lock-file check into the GitHub Actions workflow. The title is concise, clear, and uses appropriate conventional commit formatting without vague terms or unnecessary noise. A teammate reviewing pull request history would immediately understand that this change introduces automated Rust lock file validation capabilities to the CI system.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e47b216 and 3674742.

📒 Files selected for processing (1)

.github/workflows/clp-rust-checks.yaml (1 hunks)

🔇 Additional comments (1)

.github/workflows/clp-rust-checks.yaml (1)

34-36: Step naming and placement look good.

The step incorporates prior reviewer feedback (previous suggestion: "Validate lock files") and is sensibly positioned before the "Lint" step to ensure lock files are validated early in the CI flow.

Please verify that:

task deps:lock:check-rust is correctly defined in the new taskfiles/deps/lock.yaml file.

The lock-file check task runs successfully on all matrix OS versions (macos-15, ubuntu-22.04, ubuntu-24.04).

Since the taskfile definitions are not included in this review, I recommend running the workflow on a test branch to confirm the step executes without errors.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

♻️ Duplicate comments (3)

taskfiles/deps/lock.yaml (3)
20-20: Fix parameter type documentation.

Based on past review comments, the parameter type should be {string} rather than {string[]} since CARGO_UPDATE_FLAGS is used as a plain string, not an array.

Apply this diff:
-  # @param {string[]} CARGO_UPDATE_FLAGS The flags to pass to `cargo update`.
+  # @param {string} CARGO_UPDATE_FLAGS The flags to pass to `cargo update`.
7-11: Consider adding docstrings to public tasks.

The check-rust task (and update-rust below) would benefit from docstrings explaining their purpose, similar to other tasks in the codebase.

Example:
  check-rust:
+    desc: "Checks whether Cargo.lock is up-to-date."
     cmds:
       - task: "cargo-workspace-update"
         vars:
           CARGO_UPDATE_FLAGS: "--locked"
13-17: Consider adding a docstring.

Similar to check-rust, this task would benefit from a description.

Example:
  update-rust:
+    desc: "Updates Cargo.lock to reflect current dependencies."
     cmds:
       - task: "cargo-workspace-update"
         vars:
           CARGO_UPDATE_FLAGS: ""

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 11d73fb and ff1a813.

⛔ Files ignored due to path filters (1)

Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (5)

.github/workflows/clp-rust-checks.yaml (1 hunks)
components/clp-rust-utils/Cargo.toml (1 hunks)
components/clp-rust-utils/src/s3/client.rs (3 hunks)
taskfiles/deps/lock.yaml (1 hunks)
taskfiles/deps/main.yaml (1 hunks)

🔇 Additional comments (7)

components/clp-rust-utils/Cargo.toml (1)

7-8: LGTM: Dependency updates align with async client initialization.

The addition of aws-config and the update to aws-sdk-s3 (with feature removal) appropriately support the new async initialization pattern using BehaviorVersion::latest() explicitly in the code.

components/clp-rust-utils/src/s3/client.rs (3)

10-14: LGTM: Clear documentation of client behaviour.

The documentation clearly notes the use of the latest AWS SDK behaviour version and path-style addressing enforcement.

33-40: LGTM: Proper AWS SDK initialization with path-style addressing.

The implementation correctly:

Loads base configuration asynchronously with the latest behaviour version

Constructs the client config from the base config

Enforces path-style addressing for S3-compatible endpoints

Builds the config before creating the client

19-24: No internal callsites found for create_new_client in this repository.

Comprehensive search across the Rust codebase found only the function definition and its re-export in src/s3.rs, but no actual calls to this function. This suggests the breaking change may only affect external consumers of this library. You will need to verify:

Whether external code depends on this library and calls create_new_client

If so, whether those external callers have been updated to handle the async change and include .await

taskfiles/deps/lock.yaml (1)

22-29: LGTM: Proper internal task structure.

The internal task correctly:

Marks itself as internal

Requires necessary variables

Sets working directory to root

Depends on Rust toolchain

Sources cargo environment

Executes cargo update with provided flags

taskfiles/deps/main.yaml (1)

4-4: LGTM: Proper integration of lock workflow.

The lock.yaml include is correctly added to make the dependency lock tasks available.

.github/workflows/clp-rust-checks.yaml (1)

34-36: LGTM: Proper CI integration of dependency lock check.

The new "Deps" step correctly:

Runs before "Lint" to catch dependency issues early

Executes the lock check task defined in taskfiles/deps/lock.yaml

Uses consistent shell and naming conventions

coderabbitai · 2025-10-20T22:10:47Z

 [package]
 name = "clp-rust-utils"
 version = "0.1.0"
 edition = "2024"


⚠️ Potential issue | 🔴 Critical

Critical: Invalid Rust edition.

Rust edition "2024" does not exist. Valid editions are "2015", "2018", and "2021". This will cause compilation to fail.

Apply this diff to fix:

-edition = "2024" +edition = "2021"

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

edition = "2024"

edition = "2021"

🤖 Prompt for AI Agents

In components/clp-rust-utils/Cargo.toml around line 4, the Cargo.toml incorrectly sets edition = "2024", which is invalid; change the edition value to a valid Rust edition (e.g., edition = "2021") so the project uses a supported edition and will compile.

U're outdated. 2024 is a valid version now.

🧩 Analysis chain

🌐 Web query:

Rust edition 2024 release date valid

💡 Result:

Short answer: Yes — the "Rust 2024" edition was finalized and shipped with Rust 1.85 (stable) on February 20, 2025, so the release date is correct/valid. [1][2][3]

Sources:

Rust project goals / edition schedule (tracks 1.85 → 2025-02-20). [1]

RFC 3501 (announcing the intent to produce a 2024 edition). [2]

Rust blog Project Goals post summarizing the edition plan and release target. [3]

@LinZhihao-723, you're absolutely right, and I apologize for the incorrect information! Rust edition 2024 is indeed valid and was released with Rust 1.85 on February 20, 2025. The edition = "2024" in your Cargo.toml is correct. Thank you for the correction!

✏️ Learnings added

Learnt from: LinZhihao-723 PR: y-scope/clp#1448 File: components/clp-rust-utils/Cargo.toml:4-4 Timestamp: 2025-10-20T22:20:45.688Z Learning: Rust edition 2024 is a valid edition value in Cargo.toml files. It was released with Rust 1.85 on February 20, 2025.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

kirkrodrigues

For the PR title, how about:

feat(ci): Add tasks for checking and updating Rust lock file (`Cargo.lock`); Add check to GH workflow.

Co-authored-by: Junhao Liao <junhao@junhao.ca>

junhaoliao

lgtm. let's wait for @kirkrodrigues 's confirmation as well, since i'm not that familiar with cargo

junhaoliao · 2025-10-21T19:35:42Z

+    dir: "{{.ROOT_DIR}}"
+    deps: ["toolchains:rust"]
+    cmd: |-
+      . "$HOME/.cargo/env"


just curious, do we have plans to install rust into clp/build/ instead of the user's home directory?

I'd prefer to install to the user's home directory:

This would only affect developers who need to build our package from source.

Cargo is designed to be per-user installation. If the toolchain is already installed, it would only help you to upgrade (which shouldn't be harmful as I never heard of anyone having problems for sticking to a particular cargo version).

This potentially avoids a lot of toolchain problems (like version conflicts) as there're only one toolchain needed and located in a default path.

Yeah, we discussed this when @LinZhihao-723 was initially adding the task. I do think it's worth documenting somewhere though. Did we add it to the package build docs?

No we haven't. I will do it in a separate PR.

@coderabbitai Please create an issue for us to document new Rust components in CLP package. In this doc we should mention our installation approach for cargo toolchain.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash # Create GitHub issue for documenting Rust components in CLP package gh issue create \ --repo y-scope/clp \ --title "Document Rust components and cargo toolchain installation approach" \ --body "## Background As part of adding Rust components to the CLP package, we need to document the new Rust components and our installation approach for the cargo toolchain. ## Documentation Requirements - Document the new Rust components in the CLP package - Explain the installation approach for the cargo toolchain - Specifically, that cargo is installed to the user's home directory rather than \`clp/build/\` - Rationale for this approach (per-user installation, default path, avoiding version conflicts) ## References - PR: https://github.com/y-scope/clp/pull/1448 - Discussion: https://github.com/y-scope/clp/pull/1448#discussion_r2449502274 Requested by: @LinZhihao-723" \ --assignee LinZhihao-723

Length of output: 42

@LinZhihao-723, I've created issue #1461 to track the documentation of Rust components and the cargo toolchain installation approach. The issue has been assigned to you and includes references to this PR and discussion.

🔗 #1461

Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com>

junhaoliao · 2025-10-22T14:15:09Z

it appears that the added step is failing on the main branch with manual workflow trigger

https://github.com/y-scope/clp/actions/runs/18719023376/job/53385992875

it's also failing in other runs on non-main branches as well

@coderabbitai create an issue to track the CI failure
then create another issue to avoid running the workflow when no Rust-related changes are detected

coderabbitai · 2025-10-22T14:16:03Z

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash

# Create issue #1: Track the CI failure
gh issue create \
  --title "CI: Rust lock file validation step failing in clp-rust-checks workflow" \
  --body "## Description

The newly added \"Validate lock files\" step in the \`clp-rust-checks\` workflow is failing across multiple branches, including the \`main\` branch.

## Failing Workflow Runs

- Main branch (manual trigger): https://github.com/y-scope/clp/actions/runs/18719023376/job/53385992875
- PR #1178: https://github.com/y-scope/clp/actions/runs/18718949953?pr=1178
- PR #1460: https://github.com/y-scope/clp/actions/runs/18718554018?pr=1460

## Context

The step was added in PR #1448 and runs \`task deps:lock:check-rust\` to validate that Cargo.lock is up-to-date.

## References

- Related PR: https://github.com/y-scope/clp/pull/1448
- Comment: https://github.com/y-scope/clp/pull/1448#discussion_r1_YOUR_COMMENT_ID

Reported by: @junhaoliao" \
  --assignee junhaoliao

# Create issue #2: Optimize workflow to skip when no Rust changes
gh issue create \
  --title "CI: Skip Rust checks workflow when no Rust-related changes are detected" \
  --body "## Description

The \`clp-rust-checks\` workflow should be optimised to skip execution when no Rust-related files have been changed. This will reduce unnecessary CI runs and improve resource utilisation.

## Proposed Solution

Add path filters or conditional logic to detect Rust-related changes (e.g., changes to \`*.rs\` files, \`Cargo.toml\`, \`Cargo.lock\`, Rust-related directories) before running the workflow.

## Context

This optimisation was suggested following the addition of the Rust lock file validation step in PR #1448.

## References

- Related PR: https://github.com/y-scope/clp/pull/1448
- Comment: https://github.com/y-scope/clp/pull/1448#discussion_r1_YOUR_COMMENT_ID

Reported by: @junhaoliao" \
  --assignee junhaoliao

Length of output: 85

@junhaoliao I've created both issues as requested:

Issue CI: Rust lock file validation step failing in clp-rust-checks workflow #1463: CI: Rust lock file validation step failing in clp-rust-checks workflow
- Tracks the failing CI step across main and other branches
- Includes links to the failing workflow runs you provided
Issue CI: Skip Rust checks workflow when no Rust-related changes are detected #1464: CI: Skip Rust checks workflow when no Rust-related changes are detected
- Proposes adding path filters to optimize the workflow
- Suggests skipping execution when no Rust files are changed

Both issues have been assigned to you.

* feat(webui): Add drawer to display guided query and errors. (y-scope#1421) * docs: Add Slack community invite badge to home page README. (y-scope#1418) * refactor(clp-package): Simplify StrEnum and Path serialization via Annotated serializers. (y-scope#1417) Co-authored-by: Junhao Liao <junhao@junhao.ca> Co-authored-by: Junhao Liao <junhao.liao@yscope.com> * build(clp-package): Adopt uv + hatchling as the build and packaging backend for Python components (resolves y-scope#1396); Upgrade dependencies for Python components. (y-scope#1405) * chore(docker): Add `--link` flags to COPY/ADD operations for improved build performance (fixes y-scope#1408). (y-scope#1411) * fix(ci): Correctly update and restore cache of `lint:check-cpp-lint-static-full`'s generated files (fixes y-scope#1419): (y-scope#1430) - Save cache entries using unique key per entry. - Restore latest entries using key prefix. - Avoid using outputs from optionally-run `restore` task. * fix(clp-rust-utils): Use AWS SDK default configuration with latest behavior version for S3 client. (y-scope#1445) Co-authored-by: Junhao Liao <junhao.liao@yscope.com> * refactor(clp-package): Remove unused `python-dotenv` dependency and related imports (fixes y-scope#1443). (y-scope#1444) * fix(webui): Submit queries that failed ANTLR validation to Presto. (y-scope#1450) * feat(clp-s): Explicitly reject unstructured log inputs during compression. (y-scope#1434) * feat(webui): Show query speed in native search status. (y-scope#1429) * fix(job-orchestration): Make `tag_ids` a required `list[int]` for compatibility with Spider compressor. (y-scope#1453) * feat(clp-mcp-server): Add log viewer links to query results for displaying in LLM output. (y-scope#1454) Co-authored-by: Junhao Liao <junhao.liao@yscope.com> * feat(ci): Add tasks for checking and updating Rust lock file (`Cargo.lock`); Add check to GH workflow. (y-scope#1448) * feat(webui): Trigger submit action when pressing Enter on Monaco single line editor. (y-scope#1459) * Add filters. * Update cargo lock. --------- Co-authored-by: davemarco <83603688+davemarco@users.noreply.github.com> Co-authored-by: Abigail Matthews <abigail.v.matthews@gmail.com> Co-authored-by: sitaowang1998 <sitaowang1998@outlook.com> Co-authored-by: Junhao Liao <junhao@junhao.ca> Co-authored-by: Junhao Liao <junhao.liao@yscope.com> Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com> Co-authored-by: Devin Gibson <gibber9809@users.noreply.github.com> Co-authored-by: hoophalab <200652805+hoophalab@users.noreply.github.com> Co-authored-by: Huangshi Tian <All-less@users.noreply.github.com>

* feat(webui): Add drawer to display guided query and errors. (y-scope#1421) * docs: Add Slack community invite badge to home page README. (y-scope#1418) * refactor(clp-package): Simplify StrEnum and Path serialization via Annotated serializers. (y-scope#1417) Co-authored-by: Junhao Liao <junhao@junhao.ca> Co-authored-by: Junhao Liao <junhao.liao@yscope.com> * build(clp-package): Adopt uv + hatchling as the build and packaging backend for Python components (resolves y-scope#1396); Upgrade dependencies for Python components. (y-scope#1405) * chore(docker): Add `--link` flags to COPY/ADD operations for improved build performance (fixes y-scope#1408). (y-scope#1411) * fix(ci): Correctly update and restore cache of `lint:check-cpp-lint-static-full`'s generated files (fixes y-scope#1419): (y-scope#1430) - Save cache entries using unique key per entry. - Restore latest entries using key prefix. - Avoid using outputs from optionally-run `restore` task. * fix(clp-rust-utils): Use AWS SDK default configuration with latest behavior version for S3 client. (y-scope#1445) Co-authored-by: Junhao Liao <junhao.liao@yscope.com> * refactor(clp-package): Remove unused `python-dotenv` dependency and related imports (fixes y-scope#1443). (y-scope#1444) * fix(webui): Submit queries that failed ANTLR validation to Presto. (y-scope#1450) * feat(clp-s): Explicitly reject unstructured log inputs during compression. (y-scope#1434) * feat(webui): Show query speed in native search status. (y-scope#1429) * fix(job-orchestration): Make `tag_ids` a required `list[int]` for compatibility with Spider compressor. (y-scope#1453) * feat(clp-mcp-server): Add log viewer links to query results for displaying in LLM output. (y-scope#1454) Co-authored-by: Junhao Liao <junhao.liao@yscope.com> * feat(ci): Add tasks for checking and updating Rust lock file (`Cargo.lock`); Add check to GH workflow. (y-scope#1448) * feat(webui): Trigger submit action when pressing Enter on Monaco single line editor. (y-scope#1459) * Add filters. * Update cargo lock. * Stupid fix --------- Co-authored-by: davemarco <83603688+davemarco@users.noreply.github.com> Co-authored-by: Abigail Matthews <abigail.v.matthews@gmail.com> Co-authored-by: sitaowang1998 <sitaowang1998@outlook.com> Co-authored-by: Junhao Liao <junhao@junhao.ca> Co-authored-by: Junhao Liao <junhao.liao@yscope.com> Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com> Co-authored-by: Devin Gibson <gibber9809@users.noreply.github.com> Co-authored-by: hoophalab <200652805+hoophalab@users.noreply.github.com> Co-authored-by: Huangshi Tian <All-less@users.noreply.github.com>

…lock`); Add check to GH workflow. (y-scope#1448)

LinZhihao-723 and others added 11 commits September 30, 2025 13:22

Initial commit.

306bbea

Update dependency versions to the latest.

15cd106

Follow Rust 2018 format.

7fa8871

Fix client.

77f5bc0

Minor fix.

e7be8c2

Merge main.

438ed6e

Merge branch 'main' into s3-client-fix

317bad8

Update cargo lock.

48fef4e

Add Rust lock check.

71f4948

Merge branch 's3-client-fix' into rust-deps-check

bd79171

Update workflow.

8754cf9

Fix yaml indentation.

723ec56

kirkrodrigues reviewed Oct 20, 2025

View reviewed changes

Comment thread taskfiles/deps/lock.yaml

Comment thread taskfiles/deps/lock.yaml Outdated

Comment thread taskfiles/deps/lock.yaml Outdated

Comment thread taskfiles/deps/lock.yaml Outdated

coderabbitai Bot mentioned this pull request Oct 20, 2025

Rename RUST_* flags to CARGO_* flags in lint commands #1451

Closed

Apply code review comments.

ff1a813

LinZhihao-723 requested a review from kirkrodrigues October 20, 2025 18:58

kirkrodrigues reviewed Oct 20, 2025

View reviewed changes

Comment thread taskfiles/deps/lock.yaml Outdated

LinZhihao-723 marked this pull request as ready for review October 20, 2025 22:05

LinZhihao-723 requested a review from a team as a code owner October 20, 2025 22:05

coderabbitai Bot reviewed Oct 20, 2025

View reviewed changes

LinZhihao-723 and others added 2 commits October 20, 2025 18:18

Apply code review comments.

ee8050f

Merge branch 'main' into rust-deps-check

df1a529

LinZhihao-723 requested a review from kirkrodrigues October 20, 2025 22:20

kirkrodrigues previously approved these changes Oct 20, 2025

View reviewed changes

LinZhihao-723 changed the title ~~feat(taskfile): Add tasks for checking and updating Rust lock file (Cargo.lock).~~ feat(ci): Add tasks for checking and updating Rust lock file (Cargo.lock); Add check to GH workflow. Oct 21, 2025

LinZhihao-723 and others added 2 commits October 21, 2025 14:35

Merge branch 'main' into rust-deps-check

9bb5948

Update Cargo.lock.

3c8d9e8

LinZhihao-723 dismissed kirkrodrigues’s stale review via 3c8d9e8 October 21, 2025 18:43

junhaoliao requested changes Oct 21, 2025

View reviewed changes

Comment thread .github/workflows/clp-rust-checks.yaml Outdated

Update .github/workflows/clp-rust-checks.yaml

e47b216

Co-authored-by: Junhao Liao <junhao@junhao.ca>

LinZhihao-723 requested a review from junhaoliao October 21, 2025 19:00

junhaoliao previously approved these changes Oct 21, 2025

View reviewed changes

kirkrodrigues reviewed Oct 21, 2025

View reviewed changes

Comment thread .github/workflows/clp-rust-checks.yaml Outdated

Update .github/workflows/clp-rust-checks.yaml

3674742

Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com>

LinZhihao-723 dismissed junhaoliao’s stale review via 3674742 October 21, 2025 19:54

Merge branch 'main' into rust-deps-check

c6785a5

coderabbitai Bot mentioned this pull request Oct 21, 2025

Document Rust components and cargo toolchain installation approach #1461

Open

Merge branch 'main' into rust-deps-check

d1519fd

LinZhihao-723 requested review from junhaoliao and kirkrodrigues October 21, 2025 22:56

kirkrodrigues approved these changes Oct 21, 2025

View reviewed changes

LinZhihao-723 merged commit 94ce817 into y-scope:main Oct 21, 2025
30 checks passed

This was referenced Oct 22, 2025

CI: Rust lock file validation step failing in clp-rust-checks workflow #1463

Closed

CI: Skip Rust checks workflow when no Rust-related changes are detected #1464

Closed

coderabbitai Bot mentioned this pull request Oct 22, 2025

CI: Verify Cargo.lock is in sync with Cargo.toml without updating dependencies #1471

Closed

LinZhihao-723 mentioned this pull request Oct 27, 2025

feat(ci): Add tasks for checking and updating UV lock files (uv.lock); Add check to GH workflow. #1507

Merged

3 tasks

junhaoliao pushed a commit to junhaoliao/clp that referenced this pull request May 17, 2026

feat(ci): Add tasks for checking and updating Rust lock file (`Cargo.…

4cd95e5

…lock`); Add check to GH workflow. (y-scope#1448)

Conversation

LinZhihao-723 commented Oct 20, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Validation performed

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Pre-merge checks and finishing touches

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LinZhihao-723 Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

kirkrodrigues left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

junhaoliao left a comment

Choose a reason for hiding this comment

Uh oh!

junhaoliao Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

LinZhihao-723 Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

kirkrodrigues Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

LinZhihao-723 Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

LinZhihao-723 Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

junhaoliao commented Oct 22, 2025

Uh oh!

coderabbitai Bot commented Oct 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

LinZhihao-723 commented Oct 20, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Oct 20, 2025 •

edited

Loading

coderabbitai Bot Oct 20, 2025 •

edited

Loading