refactor(clp-package): Remove unused `python-dotenv` dependency and related imports (fixes #1443). by junhaoliao · Pull Request #1444 · y-scope/clp

junhaoliao · 2025-10-18T14:38:32Z

Description

Remove references of python-dotenv from the clp-py-utils package.

Checklist

The PR satisfies the contribution guidelines.
This is a breaking change and that has been indicated in the PR title, OR this isn't a
breaking change.
Necessary docs have been updated, OR no docs need to be updated.

Validation performed

task to build the package.
cd build/clp-package; ./sbin/start-clp.sh to start the package and observed no error.

Summary by CodeRabbit

Chores
- Removed an unused dependency (python-dotenv) from the project.
- Cleaned up a related unused import to tidy the codebase and reduce unnecessary dependencies.

…ated imports.

coderabbitai · 2025-10-18T14:38:42Z

Walkthrough

Removed the unused dotenv_values import from components/clp-py-utils/clp_py_utils/clp_config.py and removed the python-dotenv dependency from components/clp-py-utils/pyproject.toml. No other code or public API changes detected.

Changes

Cohort / File(s)	Summary
Config import cleanup `components/clp-py-utils/clp_py_utils/clp_config.py`	Removed `from dotenv import dotenv_values` import (unused).
Dependency manifest `components/clp-py-utils/pyproject.toml`	Removed `python-dotenv` (`python-dotenv>=1.1.1`) from `[tool.poetry.dependencies]`.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related issues

Remove unused python-dotenv dependency from clp-py-utils #1443 — Matches the same removals: the unused dotenv_values import and the python-dotenv dependency removal.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The pull request title "refactor(clp-package): Remove unused `python-dotenv` dependency and related imports (fixes #1443)" directly and accurately describes the main changes in the changeset. The changes demonstrate exact alignment with the title: the import of dotenv_values was removed from clp_config.py, and the python-dotenv dependency was removed from pyproject.toml. The title is specific, clear, and concise—a developer scanning the repository history would immediately understand that python-dotenv was removed because it was unused. The title avoids vague terminology and accurately conveys the primary purpose of the changeset.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e42c081 and 5ef3e6a.

⛔ Files ignored due to path filters (1)

components/clp-py-utils/uv.lock is excluded by !**/*.lock

📒 Files selected for processing (2)

components/clp-py-utils/clp_py_utils/clp_config.py (0 hunks)
components/clp-py-utils/pyproject.toml (0 hunks)

💤 Files with no reviewable changes (2)

components/clp-py-utils/clp_py_utils/clp_config.py
components/clp-py-utils/pyproject.toml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

GitHub Check: package-image
GitHub Check: rust-checks (ubuntu-24.04)
GitHub Check: rust-checks (ubuntu-22.04)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

kirkrodrigues

Looks reasonable. Can you resolve the conflicts?

# Conflicts: # components/clp-py-utils/poetry.lock # components/clp-py-utils/pyproject.toml

* feat(webui): Add drawer to display guided query and errors. (y-scope#1421) * docs: Add Slack community invite badge to home page README. (y-scope#1418) * refactor(clp-package): Simplify StrEnum and Path serialization via Annotated serializers. (y-scope#1417) Co-authored-by: Junhao Liao <junhao@junhao.ca> Co-authored-by: Junhao Liao <junhao.liao@yscope.com> * build(clp-package): Adopt uv + hatchling as the build and packaging backend for Python components (resolves y-scope#1396); Upgrade dependencies for Python components. (y-scope#1405) * chore(docker): Add `--link` flags to COPY/ADD operations for improved build performance (fixes y-scope#1408). (y-scope#1411) * fix(ci): Correctly update and restore cache of `lint:check-cpp-lint-static-full`'s generated files (fixes y-scope#1419): (y-scope#1430) - Save cache entries using unique key per entry. - Restore latest entries using key prefix. - Avoid using outputs from optionally-run `restore` task. * fix(clp-rust-utils): Use AWS SDK default configuration with latest behavior version for S3 client. (y-scope#1445) Co-authored-by: Junhao Liao <junhao.liao@yscope.com> * refactor(clp-package): Remove unused `python-dotenv` dependency and related imports (fixes y-scope#1443). (y-scope#1444) * fix(webui): Submit queries that failed ANTLR validation to Presto. (y-scope#1450) * feat(clp-s): Explicitly reject unstructured log inputs during compression. (y-scope#1434) * feat(webui): Show query speed in native search status. (y-scope#1429) * fix(job-orchestration): Make `tag_ids` a required `list[int]` for compatibility with Spider compressor. (y-scope#1453) * feat(clp-mcp-server): Add log viewer links to query results for displaying in LLM output. (y-scope#1454) Co-authored-by: Junhao Liao <junhao.liao@yscope.com> * feat(ci): Add tasks for checking and updating Rust lock file (`Cargo.lock`); Add check to GH workflow. (y-scope#1448) * feat(webui): Trigger submit action when pressing Enter on Monaco single line editor. (y-scope#1459) * Add filters. * Update cargo lock. --------- Co-authored-by: davemarco <83603688+davemarco@users.noreply.github.com> Co-authored-by: Abigail Matthews <abigail.v.matthews@gmail.com> Co-authored-by: sitaowang1998 <sitaowang1998@outlook.com> Co-authored-by: Junhao Liao <junhao@junhao.ca> Co-authored-by: Junhao Liao <junhao.liao@yscope.com> Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com> Co-authored-by: Devin Gibson <gibber9809@users.noreply.github.com> Co-authored-by: hoophalab <200652805+hoophalab@users.noreply.github.com> Co-authored-by: Huangshi Tian <All-less@users.noreply.github.com>

* feat(webui): Add drawer to display guided query and errors. (y-scope#1421) * docs: Add Slack community invite badge to home page README. (y-scope#1418) * refactor(clp-package): Simplify StrEnum and Path serialization via Annotated serializers. (y-scope#1417) Co-authored-by: Junhao Liao <junhao@junhao.ca> Co-authored-by: Junhao Liao <junhao.liao@yscope.com> * build(clp-package): Adopt uv + hatchling as the build and packaging backend for Python components (resolves y-scope#1396); Upgrade dependencies for Python components. (y-scope#1405) * chore(docker): Add `--link` flags to COPY/ADD operations for improved build performance (fixes y-scope#1408). (y-scope#1411) * fix(ci): Correctly update and restore cache of `lint:check-cpp-lint-static-full`'s generated files (fixes y-scope#1419): (y-scope#1430) - Save cache entries using unique key per entry. - Restore latest entries using key prefix. - Avoid using outputs from optionally-run `restore` task. * fix(clp-rust-utils): Use AWS SDK default configuration with latest behavior version for S3 client. (y-scope#1445) Co-authored-by: Junhao Liao <junhao.liao@yscope.com> * refactor(clp-package): Remove unused `python-dotenv` dependency and related imports (fixes y-scope#1443). (y-scope#1444) * fix(webui): Submit queries that failed ANTLR validation to Presto. (y-scope#1450) * feat(clp-s): Explicitly reject unstructured log inputs during compression. (y-scope#1434) * feat(webui): Show query speed in native search status. (y-scope#1429) * fix(job-orchestration): Make `tag_ids` a required `list[int]` for compatibility with Spider compressor. (y-scope#1453) * feat(clp-mcp-server): Add log viewer links to query results for displaying in LLM output. (y-scope#1454) Co-authored-by: Junhao Liao <junhao.liao@yscope.com> * feat(ci): Add tasks for checking and updating Rust lock file (`Cargo.lock`); Add check to GH workflow. (y-scope#1448) * feat(webui): Trigger submit action when pressing Enter on Monaco single line editor. (y-scope#1459) * Add filters. * Update cargo lock. * Stupid fix --------- Co-authored-by: davemarco <83603688+davemarco@users.noreply.github.com> Co-authored-by: Abigail Matthews <abigail.v.matthews@gmail.com> Co-authored-by: sitaowang1998 <sitaowang1998@outlook.com> Co-authored-by: Junhao Liao <junhao@junhao.ca> Co-authored-by: Junhao Liao <junhao.liao@yscope.com> Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com> Co-authored-by: Devin Gibson <gibber9809@users.noreply.github.com> Co-authored-by: hoophalab <200652805+hoophalab@users.noreply.github.com> Co-authored-by: Huangshi Tian <All-less@users.noreply.github.com>

…elated imports (fixes y-scope#1443). (y-scope#1444)

refactor(clp-package): Remove unused python-dotenv dependency and rel…

e42c081

…ated imports.

junhaoliao requested a review from a team as a code owner October 18, 2025 14:38

junhaoliao requested a review from kirkrodrigues October 18, 2025 14:38

kirkrodrigues reviewed Oct 20, 2025

View reviewed changes

junhaoliao added 2 commits October 20, 2025 03:30

Merge remote-tracking branch 'origin/main' into remove-dotenv

e3e693a

# Conflicts: # components/clp-py-utils/poetry.lock # components/clp-py-utils/pyproject.toml

update uv.lock

5ef3e6a

junhaoliao requested a review from kirkrodrigues October 20, 2025 07:32

kirkrodrigues approved these changes Oct 20, 2025

View reviewed changes

Merge branch 'main' into remove-dotenv

811ea5d

junhaoliao merged commit 25067b6 into y-scope:main Oct 21, 2025
22 checks passed

junhaoliao deleted the remove-dotenv branch May 7, 2026 19:46

junhaoliao added a commit to junhaoliao/clp that referenced this pull request May 17, 2026

refactor(clp-package): Remove unused python-dotenv dependency and r…

63bc228

…elated imports (fixes y-scope#1443). (y-scope#1444)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(clp-package): Remove unused `python-dotenv` dependency and related imports (fixes #1443).#1444

refactor(clp-package): Remove unused `python-dotenv` dependency and related imports (fixes #1443).#1444
junhaoliao merged 4 commits into
y-scope:mainfrom
junhaoliao:remove-dotenv

junhaoliao commented Oct 18, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Oct 18, 2025 •

edited

Loading

Uh oh!

kirkrodrigues left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

junhaoliao commented Oct 18, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Validation performed

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Oct 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related issues

Pre-merge checks and finishing touches

Uh oh!

kirkrodrigues left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

junhaoliao commented Oct 18, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Oct 18, 2025 •

edited

Loading