Feat: cover cross platform RangeControl#1342
Merged
Conversation
5 tasks
Contributor
|
@iamthomasbishop could you take a look at the screen captures in the gutenberg side PR and give feedback about color, style etc. ? Thanks! |
Contributor
|
Feedback given, done and done! ✅ |
Contributor
|
Hi @jbinda 👋 I have been checking out this PR on the Android demo app, and it's looking mostly pretty good 👍 . I did notice one issue with the numerical input, where the numbers seem to be invisible:
Can you take a look at my example usage, and let me know if I'm missing anything? These are the changes I used to test the component on the image block:diff --git a/packages/block-library/src/image/edit.native.js b/packages/block-library/src/image/edit.native.js
index eb84652..015c603 100644
--- a/packages/block-library/src/image/edit.native.js
+++ b/packages/block-library/src/image/edit.native.js
@@ -250,6 +250,15 @@ class ImageEdit extends React.Component {
separatorType={ 'fullWidth' }
onChangeValue={ this.updateAlt }
/>
+ <BottomSheet.RangeCell
+ icon={ 'admin-settings' }
+ label={ __( 'Slider' ) }
+ value={ 1 }
+ minimumValue={ 1 }
+ maximumValue={ 8 }
+ separatorType={ 'fullWidth' }
+ onChangeValue={ () => {} }
+ />
<BottomSheet.Cell
label={ __( 'Clear All Settings' ) }
labelStyle={ styles.clearSettingsButton }
Another issue, maybe related, is that the slider didn't update when I manually edited the numerical input field. |
Contributor
Author
|
Hi @mkevins Thanks for testing RangeCell components. I currently change the implementation according to @iamthomasbishop notes from here I will also take a look what cause the issue you mentioned and back to you soon. |
mkevins
approved these changes
Oct 17, 2019
Contributor
mkevins
left a comment
There was a problem hiding this comment.
Tested via: WordPress/gutenberg#17282.
Since these issues can be addressed in a separate PR:
#1448
#1449
LGTM! 🎉
daniloercoli
added a commit
that referenced
this pull request
Oct 21, 2019
…rg-mobile into issue/wp-android-8828-Aztec-crash-Android-8 * 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile: (24 commits) Feat: cover cross platform RangeControl (#1342) Introduce grouping in the block settings inspector (#1397) Fix native test of image block (#1456) Update RELEASE notes with iOS11 and Swift 5 update Expose WordPressUtils for consumption by gutenberg-bridge Update Aztec-Android ref to v1.3.33 Update bundles revert missing toggle editor mode call (#1444) Update Aztec-iOS ref to 1.11.0 Update Aztec-Android ref to v1.3.32 Update Aztec-iOS ref Update bundles Bump version to 1.15.0 Update Gutenberg Add Media & Text block to initial HTML Update Gutenberg Updated bundles Update Gutenberg Update Gutenberg Update gutenberg ... # Conflicts: # react-native-aztec/android/build.gradle
daniloercoli
added a commit
that referenced
this pull request
Oct 23, 2019
…rg-mobile into issue/wp-android-9832-IndexOutOfBoundsException-setSpan * 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile: Bump version to 1.15.1 Update bundles Update Aztec to the new tagged version v1.3.34 Feat: cover cross platform RangeControl (#1342) Introduce grouping in the block settings inspector (#1397) Fix native test of image block (#1456) # Conflicts: # react-native-aztec/android/build.gradle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is a part of #1300
Gutenberg related PR
Update release notes:
RELEASE-NOTES.txt.