[Android] Revert missing toggle editor mode call#1444
Merged
marecar3 merged 1 commit intorelease/1.15.0from Oct 15, 2019
Merged
[Android] Revert missing toggle editor mode call#1444marecar3 merged 1 commit intorelease/1.15.0from
marecar3 merged 1 commit intorelease/1.15.0from
Conversation
Contributor
|
Moved this PR to the milestone If this need to ship on v1.15, please feel free to change back the milestone and reference the release branch. |
Contributor
|
Yes, this should be shipped in 1.15, since it does fix a new "ugly" bug. |
daniloercoli
approved these changes
Oct 15, 2019
daniloercoli
added a commit
that referenced
this pull request
Oct 21, 2019
…rg-mobile into issue/wp-android-8828-Aztec-crash-Android-8 * 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile: (24 commits) Feat: cover cross platform RangeControl (#1342) Introduce grouping in the block settings inspector (#1397) Fix native test of image block (#1456) Update RELEASE notes with iOS11 and Swift 5 update Expose WordPressUtils for consumption by gutenberg-bridge Update Aztec-Android ref to v1.3.33 Update bundles revert missing toggle editor mode call (#1444) Update Aztec-iOS ref to 1.11.0 Update Aztec-Android ref to v1.3.32 Update Aztec-iOS ref Update bundles Bump version to 1.15.0 Update Gutenberg Add Media & Text block to initial HTML Update Gutenberg Updated bundles Update Gutenberg Update Gutenberg Update gutenberg ... # Conflicts: # react-native-aztec/android/build.gradle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: For some unexpected reason, the line of the code which toggles editor mode is missing in this PR: https://github.com/wordpress-mobile/gutenberg-mobile/pull/1410/files#diff-f2e1dfe800569dfb4ee4830f88779890R540
To test:
Toggle editor mode (Html -> Visual and Visual -> Html) should work as expected.
Hey, @hypest since you will probably wrangle release
1.15.0, just to let you know that this PR must be included in the1.15.0release.Update release notes:
RELEASE-NOTES.txt.