Conversation
…otice Quick Start: Dismiss Reader tour notice when navigating away from Reader screen
This was referenced May 24, 2022
Contributor
You can test the changes in Jetpack from this Pull Request by:
|
Contributor
You can test the changes in WordPress from this Pull Request by:
|
AliSoftware
approved these changes
May 24, 2022
Contributor
AliSoftware
left a comment
There was a problem hiding this comment.
- Changes from bugfix PRs which landed in the release branch
- As you mentioned in the PR description, changes from only one PR is visible in the diff as the other one was already merged in
trunkearlier
- As you mentioned in the PR description, changes from only one PR is visible in the diff as the other one was already merged in
- Version bump in
.xcconfigfiles - Latest app and metadata translations pulled from Glotpress
- Apparently you got the rate limiting issue again, on
en-CAandnl-NL… not a big deal since this is just a beta so those will be restored during next beta on Wednesday and/or during final release… but still yet another reminder to be extra mindful about those still happening (and being especially very easy to miss for the metadata ones) and double-checking them when you'll get to the final release on your Friday.
- Apparently you got the rate limiting issue again, on
| @@ -1 +0,0 @@ | |||
| WordPress – Website Builder | |||
Contributor
There was a problem hiding this comment.
Another case of 429 Too Many Requests on gp_downloadmetadata I guess… — which sadly, as mentioned in some P2 comments, [does swallow any error under UI.message "No translation available for #{target_locale}" regardless of the response's HTTP error code], making it so easy to miss… 😞
| @@ -1 +0,0 @@ | |||
| WordPress – Website bouwer | |||
Contributor
There was a problem hiding this comment.
Same likely 429 Too Many Requests rate limiting issue…
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.stringsand Fastlane metadata) automatically pulled for the new translations that have already been approved in GlotPress.xcconfigIncludes:
trunkwith Merge changes from beta 19.9.0.3 #18699, but was not part of beta 3.Nothing to test, if CI Shows green, we're good.
Regression Notes
Potential unintended areas of impact
N.A.
What I did to test those areas of impact (or what existing automated tests I relied on)
N.A.
What automated tests I added (or what prevented me from doing so)
N.A.
RELEASE-NOTES.txtif necessary. N.A.