Skip to content

Quick Start: Dismiss Reader tour notice when navigating away from Reader screen#18702

Merged
momo-ozawa merged 2 commits intorelease/19.9from
fix/18700-qs-reader-notice
May 23, 2022
Merged

Quick Start: Dismiss Reader tour notice when navigating away from Reader screen#18702
momo-ozawa merged 2 commits intorelease/19.9from
fix/18700-qs-reader-notice

Conversation

@momo-ozawa
Copy link
Copy Markdown
Contributor

@momo-ozawa momo-ozawa commented May 23, 2022

Fixes #18700
Fixes #18698

Ref: p5T066-3dZ-p2#comment-12413

Description

  • Fixed a bug where the Reader tour notice wasn't being dismissed when navigating away from the Reader tab screen
  • Updated the Quick Start title label to adjust the font scale so it doesn't get truncated

How to test

Navigating away from Reader screen

  1. Enable Quick Start for Existing Users via the debug menu
  2. Start the "Connect with other sites" tour
  3. Switch to the Reader tab
  4. Navigate away from ReaderTabViewController (i.e. switch to different tabs, tap on the search icon, tap on a post)
  5. ✅ Verify: The Quick Start notice is dismissed
Simulator.Screen.Recording.-.iPhone.13.-.2022-05-23.at.11.49.56.mp4

Completing the Reader task (regression testing)

  1. Enable Quick Start for Existing Users via the debug menu
  2. Start the "Connect with other sites" tour
  3. Switch to the Reader tab
  4. Complete the tour by tapping on the cog icon
  5. Go back to My Site
  6. ✅ Verify: The Reader tour is marked as completed
Simulator.Screen.Recording.-.iPhone.13.-.2022-05-23.at.11.52.14.mp4

Title shouldn't be truncated

  1. Run the app on a smaller device, like the iPhone SE
  2. Enable Quick Start for Existing Users via the debug menu
  3. ✅ Verify: "Get to know the WordPress app" isn't truncated

Regression Notes

  1. Potential unintended areas of impact
  • Completing the Reader task
  1. What I did to test those areas of impact (or what existing automated tests I relied on)
  • Tested the steps above
  1. What automated tests I added (or what prevented me from doing so)
  • n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link
Copy Markdown

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented May 23, 2022

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18702-4aeb2c2 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented May 23, 2022

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18702-4aeb2c2 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@momo-ozawa momo-ozawa merged commit ce15322 into release/19.9 May 23, 2022
@momo-ozawa momo-ozawa deleted the fix/18700-qs-reader-notice branch May 23, 2022 16:11
@momo-ozawa
Copy link
Copy Markdown
Contributor Author

FYI @mokagio 🙇‍♀️

@mokagio mokagio mentioned this pull request May 24, 2022
7 tasks
@mokagio
Copy link
Copy Markdown
Contributor

mokagio commented May 24, 2022

@momo-ozawa this has been bundled as part of 19.9 beta 4 (19.9.0.4).

Thanks for your work 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants