Skip to content

Merge changes from beta 19.9.0.3#18699

Merged
mokagio merged 7 commits intotrunkfrom
release/19.9
May 23, 2022
Merged

Merge changes from beta 19.9.0.3#18699
mokagio merged 7 commits intotrunkfrom
release/19.9

Conversation

@mokagio
Copy link
Copy Markdown
Contributor

@mokagio mokagio commented May 23, 2022

  • Updates to the localization files (.strings and Fastlane metadata) automatically pulled for the new translations that have already been approved in GlotPress
  • Version update in .xcconfig
  • Diffs from the PRs that made it into this beta

Regarding the localization updates. You'll notice the es-MX files have been deleted by our automation. That is consistent with the data returned by GlotPress locally:

[13:54:17]: ---------------------------------
[13:54:17]: --- Step: gp_downloadmetadata ---
[13:54:17]: ---------------------------------
[13:54:17]: Project URL: https://translate.wordpress.org/projects/apps/ios/release-notes/
[13:54:17]: Locales: {"ar"=>"ar-SA", "da"=>"da", "de"=>"de-DE", "en-au"=>"en-AU", "en-ca"=>"en-CA", "en-gb"=>"en-GB", "es"=>"es-ES", "es-mx"=>"es-MX", "fr"=>"fr-FR", "he"=>"he", "id"=>"id", "it"=>"it", "ja"=>"ja", "ko"=>"ko", "nl"=>"nl-NL", "nb"=>"no", "pt-br"=>"pt-BR", "pt"=>"pt-PT", "ru"=>"ru", "sv"=>"sv", "th"=>"th", "tr"=>"tr", "zh-cn"=>"zh-Hans", "zh-tw"=>"zh-Hant"}
[13:54:17]: Source locale: -
[13:54:17]: Path: /Users/gio/Developer/a8c/wpios/fastlane/metadata
Downloading language: ar-SA
Downloading language: da
Downloading language: de-DE
Downloading language: en-AU
Downloading language: en-CA
Downloading language: en-GB
Downloading language: es-ES
Downloading language: es-MX
[13:54:31]: No translation available for es-MX 👈👈👈
Downloading language: fr-FR

Also, for the record, I got a couple of 429 when updating the .strings files

[...]
[13:53:47]: Error downloading locale `ko` — 429 Too Many Requests (https://translate.wordpress.org/projects/apps/ios/dev/ko/default/export-translations/?filters%5Bstatus%5D=current&format=strings)
[...]
[13:54:05]: Error downloading locale `sq` — 429 Too Many Requests (https://translate.wordpress.org/projects/apps/ios/dev/sq/default/export-translations/?filters%5Bstatus%5D=current&format=strings)
[13:54:05]: Downloading translations for 'sv' from GlotPress (sv) [{:status=>"current"}]...

Includes:

Nothing to test, if CI Shows green, we're good.

Regression Notes

  1. Potential unintended areas of impact
    N.A.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N.A.

  3. What automated tests I added (or what prevented me from doing so)
    N.A.

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes. N.A.
  • I have considered adding accessibility improvements for my changes. N.A.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary. N.A.

Paul Von Schrottky and others added 6 commits May 19, 2022 15:57
Change default WP app icon to Spectrum 2022
4232dec 
This is a temporary change to make Spectrum the default WP app icon. This is a seasonal change, so we expect to revert this change in an upcoming app version.
@leandroalonso
add: track when "first post" and "next post" prompt is tapped
edec2cc
Merge pull request #18638 from wordpress-mobile/update/app-icon-to-sp…
47d9e74 
…ectrum

Change default app icon to spectrum
@mokagio
Update app translations – Localizable.strings
0c5b8ee
@mokagio
Update WordPress metadata translations
7f87b47
@mokagio
Bump version number
59b8f7a
@mokagio mokagio enabled auto-merge May 23, 2022 04:04
@mokagio mokagio added this to the 19.9 ❄️ milestone May 23, 2022
@mokagio mokagio requested a review from a team May 23, 2022 04:04
@mokagio mokagio mentioned this pull request May 23, 2022
Merged
1 task
@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented May 23, 2022

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18699-59b8f7a on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@mokagio mokagio mentioned this pull request May 23, 2022
Merged
4 tasks
@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented May 23, 2022

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18699-59b8f7a on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@leandroalonso
Merge pull request #18691 from wordpress-mobile/issue/track_first_nex…
313d4bd 
…t_post_tap

My Site Dashboard: track tap on "Write first post" and "Write next post" prompts
@mokagio mokagio merged commit 26ee906 into trunk May 23, 2022
@mokagio mokagio mentioned this pull request May 24, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oguzkocer oguzkocer oguzkocer approved these changes

Assignees

No one assigned

Labels

Releases

Projects

None yet

Milestone

19.9

Development

Successfully merging this pull request may close these issues.

4 participants

@mokagio @wpmobilebot @oguzkocer @leandroalonso