Skip to content

My Site Dashboard: track tap on "Write first post" and "Write next post" prompts#18691

Merged
leandroalonso merged 1 commit intorelease/19.9from
issue/track_first_next_post_tap
May 23, 2022
Merged

My Site Dashboard: track tap on "Write first post" and "Write next post" prompts#18691
leandroalonso merged 1 commit intorelease/19.9from
issue/track_first_next_post_tap

Conversation

@leandroalonso
Copy link
Copy Markdown
Contributor

This PR adds two missing tracks:

  • When tapping "Write your first post": 🔵 Tracked: my_site_dashboard_card_item_tapped <default_tab_experiment: site_menu, sub_type: create_first, type: post>
  • When tapping "Write your next post": 🔵 Tracked: my_site_dashboard_card_item_tapped <default_tab_experiment: site_menu, sub_type: create_next, type: post>

To test

  1. Run the app
  2. For a site without any posts, tap the "Write your first post" card
  3. ✅ Make sure my_site_dashboard_card_item_tapped is fired with sub_type: create_first prop
  4. Publish a post
  5. Tap the "Write your next post" card
  6. ✅ Make sure my_site_dashboard_card_item_tapped is fired with sub_type: create_next prop

Regression Notes

  1. Potential unintended areas of impact
    n/a

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    n/a

  3. What automated tests I added (or what prevented me from doing so)
    n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link
Copy Markdown

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@leandroalonso
Copy link
Copy Markdown
Contributor Author

@ashiagr @AjeshRPai could please one of you add the same tracking to Android? Thank you so much! :)

@wpmobilebot
Copy link
Copy Markdown
Contributor

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18691-edec2cc on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Copy Markdown
Contributor

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18691-edec2cc on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Copy link
Copy Markdown
Contributor

@hassaanelgarem hassaanelgarem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described 🚀

Copy link
Copy Markdown
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described!

@leandroalonso
Copy link
Copy Markdown
Contributor Author

@mokagio FYI

@leandroalonso leandroalonso merged commit 313d4bd into release/19.9 May 23, 2022
@leandroalonso leandroalonso deleted the issue/track_first_next_post_tap branch May 23, 2022 13:50
@mokagio mokagio mentioned this pull request May 24, 2022
7 tasks
@mokagio
Copy link
Copy Markdown
Contributor

mokagio commented May 24, 2022

@leandroalonso this has been bundled as part of 19.9 beta 4 (19.9.0.4).

Thanks for your work 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants