[Gutenberg] - Remove tooltip flag and modal layout feature flag#13665
Merged
[Gutenberg] - Remove tooltip flag and modal layout feature flag#13665
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
This was referenced Dec 23, 2020
[Gutenberg] - Remove tooltip flag and modal layout feature flag
wordpress-mobile/WordPress-iOS#15550
Merged
|
You can test the changes on this Pull Request by downloading the APK here. |
added 4 commits
December 23, 2020 12:32
# Conflicts: # WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java # libs/editor/WordPressEditor/src/main/java/org/wordpress/android/editor/EditorFragmentAbstract.java # libs/editor/WordPressEditor/src/main/java/org/wordpress/android/editor/gutenberg/GutenbergContainerFragment.java # libs/editor/WordPressEditor/src/main/java/org/wordpress/android/editor/gutenberg/GutenbergEditorFragment.java # libs/gutenberg-mobile
antonis
approved these changes
Dec 29, 2020
Contributor
antonis
left a comment
There was a problem hiding this comment.
Great work @geriux 👍
I tested the app on a Pixel 2XL with Android 11 and behaves as expected.
The code changes are consistent and remove the unneeded configurability introduced with Modal Layout Picker and the Starter Page Templates Tooltip code 🎉
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gutenberg PR-> WordPress/gutenberg#27640Gutenberg Mobile PR-> wordpress-mobile/gutenberg-mobile#2921WordPress iOS PR-> wordpress-mobile/WordPress-iOS#15550Removes unused code of the old page layout picker.
To test check the Gutenberg PR description.
PR submission checklist:
RELEASE-NOTES.txtif necessary.