Merged
Conversation
…moved to the mobile components directory.
|
Size Change: 0 B Total Size: 1.3 MB ℹ️ View Unchanged
|
This was referenced Dec 21, 2020
3 tasks
added 2 commits
December 28, 2020 13:37
# Conflicts: # packages/react-native-bridge/android/src/main/java/org/wordpress/mobile/ReactNativeGutenbergBridge/GutenbergBridgeJS2Parent.java # packages/react-native-bridge/android/src/main/java/org/wordpress/mobile/WPAndroidGlue/WPAndroidGlueCode.java # packages/react-native-bridge/ios/GutenbergBridgeDelegate.swift # packages/react-native-bridge/ios/RNReactNativeGutenbergBridge.m # packages/react-native-editor/ios/GutenbergDemo/GutenbergViewController.swift
antonis
approved these changes
Dec 29, 2020
Member
antonis
left a comment
There was a problem hiding this comment.
Great work @geriux 👍
I tested the app on a Pixel 2XL with Android 11 and behaves as expected.
The code changes are consistent and as described remove:
- The whole old Page Template Picker (
page-template-pickerfolder) functionality exceptBlockPreviewthat has been moved - The
ModalHeaderBar(modal-header-barfolder) - The Modal Layout Picker flag for Android
- The Starter Page Template Tooltip code
This was referenced Jan 4, 2021
chipsnyder
reviewed
Jan 4, 2021
Contributor
chipsnyder
left a comment
There was a problem hiding this comment.
Thanks for taking this on @geriux!
There's an enum case for modalLayoutPicker under capabilities that I think we can remove now too. Could we include that deletion in this PR as well?
added 2 commits
January 7, 2021 16:32
# Conflicts: # packages/components/src/index.native.js
chipsnyder
reviewed
Jan 7, 2021
chipsnyder
approved these changes
Jan 7, 2021
Contributor
chipsnyder
left a comment
There was a problem hiding this comment.
Thanks for taking care of this! Tested with wordpress-mobile/WordPress-iOS#15550 (review)
This was referenced Mar 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/gutenberg-mobile#2936
Gutenberg Mobile PR-> wordpress-mobile/gutenberg-mobile#2921WordPress iOS PR-> wordpress-mobile/WordPress-iOS#15550WordPress Android PR-> wordpress-mobile/WordPress-Android#13665Description
Removes unused code of the page layout picker. A native layout picker was implemented in the WordPress apps so this is no longer being used.
Removes:
It also fixes some tests issues related to the recently introduced
alignmentHelpersHow has this been tested?
On the WordPress app (builds available in each PR)
Case 1
Case 2
Screenshots
Types of changes
Checklist: