[Gutenberg] - Remove tooltip flag and modal layout feature flag#15550
Merged
[Gutenberg] - Remove tooltip flag and modal layout feature flag#15550
Conversation
|
You can trigger an installable build for these changes by visiting CircleCI here. |
This was referenced Dec 21, 2020
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
3 tasks
added 3 commits
December 28, 2020 14:34
# Conflicts: # Podfile # Podfile.lock # WordPress/Classes/Utility/BuildInformation/FeatureFlag.swift # WordPress/Classes/ViewRelated/Gutenberg/GutenbergViewController.swift
chipsnyder
reviewed
Jan 4, 2021
Contributor
chipsnyder
left a comment
There was a problem hiding this comment.
Thank you for taking on this cleanup @geriux! I had one concern RE: classic editor but the rest looks good to me :)
houndci-bot
reviewed
Jan 7, 2021
chipsnyder
approved these changes
Jan 7, 2021
# Conflicts: # Podfile # Podfile.lock
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gutenberg PR-> WordPress/gutenberg#27640Gutenberg Mobile PR-> wordpress-mobile/gutenberg-mobile#2921WordPress Android PR-> wordpress-mobile/WordPress-Android#13665Removes unused code of the old page layout picker.
To test check the Gutenberg PR description.
PR submission checklist:
RELEASE-NOTES.txtif necessary.