Skip to content

Update Gutenberg to version 1.32.0#12384

Merged
mchowning merged 24 commits intodevelopfrom
gutenberg/release_1.32_integration
Jul 10, 2020
Merged

Update Gutenberg to version 1.32.0#12384
mchowning merged 24 commits intodevelopfrom
gutenberg/release_1.32_integration

Conversation

@SergioEstevao
Copy link
Copy Markdown
Contributor

@SergioEstevao SergioEstevao commented Jul 8, 2020

Update Gutenberg to version 1.32.0

To test:

  • Smoke test the block editor writing flow.
  • Test Copy, Cut, Paste, and Duplicate functionality to blocks
  • Test mentions insertion ( this will be under a feature flag and it's only for internal testing)
  • Improved editor loading experience with Ghost Effect.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@SergioEstevao SergioEstevao added the Gutenberg Editing and display of Gutenberg blocks. label Jul 8, 2020
@SergioEstevao SergioEstevao added this to the 15.3 milestone Jul 8, 2020
@SergioEstevao SergioEstevao requested a review from mchowning July 8, 2020 13:11
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jul 8, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jul 8, 2020

You can test the changes on this Pull Request by downloading the APK here.

@dratwas
Copy link
Copy Markdown
Contributor

dratwas commented Jul 8, 2020

Tested with all cases below. Everything seems to work correctly 🎉

DarkMode-2

  • Spacer Block - Check if in DarkMode all components gets proper colors
  • Button Block - Check if in DarkMode all components gets proper colors
  • Group Block - Check if in DarkMode all components gets proper colors
  • Columns Block - Check if in DarkMode all components gets proper colors

Group-2

  • Navigation up button works as expected
  • Navigation down works according to parent-first approach
  • Cross navigation between blocks works as expected
  • Ungroup button works as expected
  • Check if in DarkMode all components gets proper colors
  • Check if nested Placeholder block can be replaced

Spacer-2

  • Settings: Available height range is correct
  • Settings: Height range extends if Spacer comes from the web is higher than 500px
    NOTE: I can not set more than 500px on the web as well, seems like something has changed. However, I was able to check that by changing the height of the spacer in the code editor mode
  • Spacer in horizontal layout works as expected

Buttons-4

  • Render custom text color
  • Render custom background color
  • Render gradient background color
  • Check if selection / caret color matches font color
  • The newly created Buttons has set background color to the theme-default color in preview

Button-5

  • Edit text styles
  • Render theme colors
    NOTE: It is even better now. Themes colors are supported so we do not expect a gray button with white text.
  • Settings: Change Button border radius

Button-7

  • Link from the clipboard is automatically added into the empty URL field in link settings and button options
  • Toolbar link button is active when Button has link

@cameronvoell
Copy link
Copy Markdown
Contributor

cameronvoell commented Jul 8, 2020

Image Block:

  • TC001 Insert image from device, fail and retry
  • TC002 Insert image from device, stop upload
  • TC003 Add Caption
  • TC004 Close/Re-open post with an ongoing image upload
  • TC005 Close post with an ongoing image upload
  • TC006 Switch to classic editor with an image block in page

Copy, Cut, Paste

  • Test Steps from PR and random smoke tests

Everything here looks good! Also the Cut, Copy, Paste, Duplicate features are super cool!

@guarani
Copy link
Copy Markdown
Contributor

guarani commented Jul 8, 2020

Tested build 60308 a Samsung Galaxy S10 with Android 10.

Unsupported blocks

@mchowning @SergioEstevao The "WP.com Business (Atomic) sites are supported" case above is not working, issue filed here: wordpress-mobile/gutenberg-mobile#2470

@hypest
Copy link
Copy Markdown
Contributor

hypest commented Jul 9, 2020

Block Editor: The block editor now gives users the ability to individually edit unsupported blocks found in posts or pages.

Headsup, that's from the release notes but, note that the feature is not available on Jetpack (non Atomic) sites. We held it back since it's not working correctly in that case. Mentioning the exception will kinda be too much detail but, it could also be a useful mention to avoid frustration. Let's add the mention and we can discuss it as part of the overall changelog in the main apps. So, suggestion:
Block Editor: Users can now individually edit unsupported blocks found in posts or pages. Not available on Jetpack connected self-hosted sites.

@mchowning
Copy link
Copy Markdown
Contributor

Thanks for the heads up about unsupported blocks not working on Jetpack sites @hypest! I made the suggested update in f9992e7. I updated the iOS release PR as well: wordpress-mobile/WordPress-iOS@16b7e07.

@mchowning
Copy link
Copy Markdown
Contributor

Since I just merged in the feature flag for the @-mentions feature, I did a quick VanillaRelease build locally and verified that @-mentions was turned off in it. 👍 . Note that @-mentions will still show up in the Installable Builds on this PR because that is a Jalapeno build and @-mentions is only turned off in Vanilla builds.

@mchowning
Copy link
Copy Markdown
Contributor

Tested:

  • WP.com site: unsupported editing available and working
  • Atomic site: unsupported editing available and working
  • ⚠️ ❗ Self-hosted no-jetpack-connection (pressable): mSite.getWebEditor() is null, so the app is crashing. I put a fix for that in this PR, and with that fix, the unsupported block did not allow editing, which I believe is the desired behavior.

⚠️ I did not have a chance to test a username/password authenticated site that was subsequently connected to Jetpack.

One other small thing I noticed is that when returning from editing an unsupported block, the keyboard would be presented, without a text field being highlighted (i.e., typing on the keyboard did nothing). This was on a post that only had a single unsupported block.

@hypest
Copy link
Copy Markdown
Contributor

hypest commented Jul 10, 2020

One other small thing I noticed is that when returning from editing an unsupported block, the keyboard would be presented, without a text field being highlighted (i.e., typing on the keyboard did nothing). This was on a post that only had a single unsupported block.

@guarani , please add that to the list of follow-up issues to address, thanks!

Copy link
Copy Markdown
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working well! :shipit:

@mchowning mchowning merged commit 9e4344b into develop Jul 10, 2020
@mchowning mchowning deleted the gutenberg/release_1.32_integration branch July 10, 2020 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Gutenberg Editing and display of Gutenberg blocks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants