Avoid NPE when webeditor is null#12419
Merged
mchowning merged 6 commits intogutenberg/release_1.32_integrationfrom Jul 10, 2020
Merged
Avoid NPE when webeditor is null#12419mchowning merged 6 commits intogutenberg/release_1.32_integrationfrom
mchowning merged 6 commits intogutenberg/release_1.32_integrationfrom
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
3 tasks
|
You can test the changes on this Pull Request by downloading the APK here. |
Contributor
Author
|
Tested and I am seeing that
I believe this is the expected behavior at this time, so I think this PR is good to merge. |
Contributor
Author
|
We realized that it is possible for wp.com sites to have the block editor disabled as well, UPDATE: Decision was made to go ahead with the feature. |
67e0c0f to
33a07cb
Compare
…on' into avoid_npe_when_webeditor_null
Contributor
|
Tested build 60897 on Galaxy S10 with Android 10. |
guarani
approved these changes
Jul 10, 2020
26 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When testing unsupported block editing for the gutengerg 1.32 release, I observed that on my pressable site the webEditor was null and this was crashing the app. This addresses that by reversing the.equals()check to avoid the NPE.UPDATE: This PR was originally fixing a NPE, but it grew to address a newly discovered bug on self-hosted sites,
and then eventually to just disable the feature for the time being to allow for more testing.To test:
Load the gutenberg editor on a site where the webeditor value is null (a Pressable non-jetpack connected site is what I used), and confirm that the app does not crash.
PR submission checklist:
RELEASE-NOTES.txtif necessary.