Skip to content
This repository was archived by the owner on Mar 7, 2025. It is now read-only.

Update unsupported block editor test cases #42

Merged
guarani merged 6 commits into from
Jul 9, 2020
Merged

Update unsupported block editor test cases #42

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c996dcf
Fixed broken jetpack markdown example
Jul 8, 2020
faf4dfe
Update unsupported-block-editing.md
Jul 9, 2020
be7b463
Clarified support for Jetpack connected sites
Jul 9, 2020
a8ab978
Fix formatting error
Jul 9, 2020
8f6d698
Fix formatting
Jul 9, 2020
7ede796
Clarified and corrected test cases
Jul 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 24 additions & 14 deletions test-cases/gutenberg/unsupported-block-editing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,18 @@

##### TC001

### New edits are persisted
### User can edit unsupported blocks on regular WP.com sites

1. Add a block that's not yet supported on mobile (e.g. the Jetpack Markdown `jetpack/markdown` block) — this can be done by switching to HTML mode and pasting in the raw content
1. On a regular WP.com site (i.e. not Atomic), add a block that's not yet supported on mobile (e.g. the Jetpack Markdown `jetpack/markdown` block). This can be done by switching to HTML mode and pasting in the raw content (or by adding it via WordPress.com, where it is supported)

Example HTML:
```
<!-- wp:jetpack/markdown {\"source\":\"Hello\\nWorld\"} -->\n<div class=\"wp-block-jetpack-markdown\"><p>Hello\nWorld</p>\n</div>\n<!-- /wp:jetpack/markdown -->
```
```
<!-- wp:jetpack/markdown {"source":"This is a \nnew line"} -->
<div class="wp-block-jetpack-markdown"><p>This is a
new line</p>
</div>
<!-- /wp:jetpack/markdown -->
```
2. Switch back to Visual mode if needed
3. Expect to see the block rendered as a placeholder with the text "Unsupported"
4. Tap the `(?)` icon and expect the option to edit the block in a web browser to be shown
Expand All @@ -24,27 +28,33 @@
##### TC002

**Known Issues**
- **[Android]** The update button is not greyed-out when changes are discarded
- **[Android-only]** The update button is not greyed-out when changes are discarded

### Discarded edits are not persisted
### Ensure discarded edits are not persisted

1. Repeat steps 1 to 5 above
1. Repeat steps 1 to 5 from TC001 above
2. Edit the block content (e.g. update its text)
3. Tap the Cancel button to discard changes and expect to be taken back to the block editor
4. Expect the Update button to be greyed-out
5. Inspect the HTML content of the post and expect it to **not** contain any of the changes
5. Using HTML mode in the editor, view the HTML content of the post and expect it to **not** contain any of the changes

##### TC003

### WP.com Business (Atomic) sites are supported
### User can edit unsupported blocks on regular WP.com Business (Atomic) sites

Repeat steps from TC001 using a post on a WP.com site with a Business Plan (i.e. Atomic site)
Repeat TC001 and TC002 using a post on a WP.com site with a Business Plan (i.e. Atomic site)

##### TC004

**Known Issues**
This feature is disabled for Jetpack connected sites.
- The Unsupported Block Editor is currently [not available on Jetpack connected self-hosted sites](https://github.com/wordpress-mobile/gutenberg-mobile/issues/2471)

### Self-hosted sites are supported
### Self-hosted sites are supported (if they are not connected to WordPress via Jetpack)
Copy link
Copy Markdown
Contributor

@hypest hypest Jul 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @guarani , when logging in the Jetpack .org site using username and password, does it matter if Jetpack is connected or not? The testcase makes it look like "not connected" is supported, but unsure about when connected.

Can we add a new testcase to cover the connected case, or rephrase that bit in the current testcase (say, by removing the mention to connected or not)?

Copy link
Copy Markdown
Contributor Author

@guarani guarani Jul 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point. Now we've disabled self-hosted sites I'm going to go ahead and remove the test case entirely. (I think self-hosted sites were supported when the user used their username/password to log in.)

Copy link
Copy Markdown
Contributor

@hypest hypest Jul 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think self-hosted sites were supported when the user used their username/password to log in.

They were (before we found the issue with Classic editor popping up if Gutenberg is disabled) but I might be misunderstanding the testcase: when logging in with username/password the feature should actually have worked regardless of the Jetpack state (uninstalled, installed but not-connected, connected), right? 🤔


Repeat steps from TC001 using a post on a .org site (self-hosted)
Repeat TC001 and TC002 using a post on a .org (self-hosted) site that does not have Jetpack connected (it can be installed, just not connected to WordPress.com). You can test with any .org core block that is not currently supported on Gutenberg Mobile, such as the Audio block:

```
<!-- wp:audio -->
<figure class="wp-block-audio"><audio controls src="https://www2.cs.uic.edu/~i101/SoundFiles/StarWars60.wav"></audio></figure>
<!-- /wp:audio -->
```