Hide @-mentions feature on Gutenberg for Vanilla builds#12391
Merged
mchowning merged 4 commits intogutenberg/release_1.32_integrationfrom Jul 9, 2020
Merged
Hide @-mentions feature on Gutenberg for Vanilla builds#12391mchowning merged 4 commits intogutenberg/release_1.32_integrationfrom
mchowning merged 4 commits intogutenberg/release_1.32_integrationfrom
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
2 tasks
|
You can test the changes on this Pull Request by downloading the APK here. |
6 tasks
57ef869 to
88e0893
Compare
cameronvoell
approved these changes
Jul 9, 2020
Contributor
cameronvoell
left a comment
There was a problem hiding this comment.
Verify that @-mentions exist in the following builds:
- WasabiDebug build
- ZalphaRelease build
Verify that @-mentions does not exist in a
- VanillaRelease build
Looks good!
…oN' into put_mentions_behind_feature_flag
…oN' into put_mentions_behind_feature_flag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the @-mentions feature in the gutenberg editor to only be present on dev and internal builds, but not on the build that is released to the public. I am accomplishing that by creating a feature flag that is true for any build other than a
Vanillabuild.Related PRs:
To Test
@-mentions includes both (1) an
@button in the format bar for RichText blocks in gutenberg (you'll probably need to scroll the format bar to see it), and (2) a response anytime an "@" is typed following a space in such a block.WasabiDebugbuildZalphaReleasebuildVanillaReleasebuildPR submission checklist:
RELEASE-NOTES.txtif necessary.