Check @-mentions feature flag on Android#23804
Merged
mchowning merged 2 commits intornmobile/release_1.32.0from Jul 9, 2020
Merged
Check @-mentions feature flag on Android#23804mchowning merged 2 commits intornmobile/release_1.32.0from
mchowning merged 2 commits intornmobile/release_1.32.0from
Conversation
Merged
3 tasks
|
Size Change: 0 B Total Size: 1.14 MB ℹ️ View Unchanged
|
cameronvoell
approved these changes
Jul 9, 2020
Member
cameronvoell
left a comment
There was a problem hiding this comment.
Looks good. functionality checked via wordpress-mobile/WordPress-Android#12391
…t_mentions_behind_feature_flag_on_android
SergioEstevao
added a commit
that referenced
this pull request
Jul 13, 2020
* Update react-native-editor version to: 1.32.0 * Update podfile. * Enable unsupported block editor on Atomic sites (#23830) * Check feature flag for mentions feature on Android (#23804) * Update release notes order. * Update release notes for 1.32.0 react-native-editor. * Update podfile * Fix release notes order of releases. Co-authored-by: Sergio Estevao <sergioestevao@gmail.com> Co-authored-by: Marko Savic <savicmarko1985@gmail.com>
mkevins
pushed a commit
that referenced
this pull request
Jul 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the @-mentions capability so that it is only
trueif the mentions feature-flag is set totrueon Android. Please see the related WPAndroid PR for more information and testing steps: wordpress-mobile/WordPress-Android#12391.Checklist: