Feature/material theme and Dark Theme support Try. 2#11498
Closed
Feature/material theme and Dark Theme support Try. 2#11498
Conversation
…sharing-settings Issue/10638 material sharing settings
…ress-mobile/WordPress-Android into issue/11267-aztec-dark-mode
…web-preview Issue/10648 material web preview
…id into feature/material-theme # Conflicts: # WordPress/src/main/java/org/wordpress/android/ui/reader/subfilter/viewholders/SubfilterListItemViewHolder.kt # WordPress/src/main/res/layout/filtered_list_component.xml
…WordPress-Android into issue/10650-material-me-screen # Conflicts: # WordPress/src/main/java/org/wordpress/android/ui/main/MeFragment.java
…WordPress-Android into issue/10649-material-reader-post # Conflicts: # WordPress/src/main/res/values/dimens.xml
…WordPress-Android into issue/10646-material-login-flow # Conflicts: # WordPress/src/main/res/values/styles.xml
…reader-post Issue/10649 material reader post
…WordPress-Android into issue/fix-lifecycle-crash-with-appcompat-1-1-0
3 tasks
…ert-dialog Issue/use material alert dialog
…-mobile/WordPress-Android into issue/nuke-calypso-styles
…yles Issue/nuke calypso styles
This reverts commit fd2d16f.
Contributor
|
FWIW, I managed to pinpoint a commit that seems to be the first to introduce the editor scrolling issue (wordpress-mobile/gutenberg-mobile#2056) and looks to be 5e4f3b0. The one before it (94871fe) doesn't manifest the issue. Note, both commits fail to build on their own. I had to add the |
…ss-Android into issue/fix-material-theme-conflicts # Conflicts: # WordPress/src/main/java/org/wordpress/android/ui/pages/PageItemViewHolder.kt # WordPress/src/main/java/org/wordpress/android/ui/pages/PagesFragment.kt # WordPress/src/main/res/layout/edit_post_settings_fragment.xml # WordPress/src/main/res/layout/page_list_item.xml # WordPress/src/main/res/values-ar/strings.xml # WordPress/src/main/res/values-cs/strings.xml # WordPress/src/main/res/values-de/strings.xml # WordPress/src/main/res/values-en-rGB/strings.xml # WordPress/src/main/res/values-es-rCL/strings.xml # WordPress/src/main/res/values-es-rMX/strings.xml # WordPress/src/main/res/values-es-rVE/strings.xml # WordPress/src/main/res/values-es/strings.xml # WordPress/src/main/res/values-fr/strings.xml # WordPress/src/main/res/values-he/strings.xml # WordPress/src/main/res/values-id/strings.xml # WordPress/src/main/res/values-it/strings.xml # WordPress/src/main/res/values-ja/strings.xml # WordPress/src/main/res/values-ko/strings.xml # WordPress/src/main/res/values-nl/strings.xml # WordPress/src/main/res/values-pl/strings.xml # WordPress/src/main/res/values-ro/strings.xml # WordPress/src/main/res/values-ru/strings.xml # WordPress/src/main/res/values-sq/strings.xml # WordPress/src/main/res/values-sv/strings.xml # WordPress/src/main/res/values-tr/strings.xml # WordPress/src/main/res/values-zh-rCN/strings.xml # WordPress/src/main/res/values-zh-rHK/strings.xml # WordPress/src/main/res/values-zh-rTW/strings.xml # fastlane/metadata/android/release_notes.xml
…replaced with develop version).
…eme-conflicts Issue/fix material theme conflicts
3 tasks
…ss-Android into feature/material-theme
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
Contributor
|
In the effort to try to merge this work to the block editor release (1.25.0, ongoing at the time of writing), we'll stop working on this PR and instead focus on the PR that is targeting the release: #11580 |
Contributor
|
Closing in favor: #11580 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of the issue in block editor we postponed merging this into develop. Trying to do it again :)
This PR moves app to the material theme and adds Dark Theme support.
This is a feature branch and most of the commits were reviewed.
Gutenberg PR: [RNMobile] - WordPress/gutenberg#21139
Gutenberg Mobile PR: wordpress-mobile/gutenberg-mobile#2061
PR submission checklist:
RELEASE-NOTES.txtif necessary.