Feature/1675 dark mode android integration#2061
Closed
Conversation
6 tasks
Closed
3 tasks
Contributor
Author
|
Marking this one with DO NOT MERGE flag until we don't resolve this blocker: #2056 |
…n_new # Conflicts: # gutenberg
…n_new # Conflicts: # gutenberg
Contributor
|
@marecar3 I'm moving this to 1.26, feel free to move it back to 1.25 if this is something that can be considered a regression. |
2 tasks
Contributor
|
We'll try to target 1.25 with this after all so, changing the milestone accordingly. |
Contributor
Author
|
Closing in favor: #2098 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1675
Gutenberg PR: WordPress/gutenberg#21139
WordPress-Android PR: wordpress-mobile/WordPress-Android#11498
To test:
On devices with API <=28:
Set by Battery Saver.Darkand confirm that the app switches to Dark Theme.Lightand confirm that the app switches to Light Theme.Set by Battery Saverand enable Battery Saver on the device.On devices with API 29+:
System Default.Darkand confirm that the app switches to Dark Theme.Lightand confirm that the app switches to Light Theme.System Defaultand close the app.Note for API 29+: At this moment we aren't able to get the app theme to switch automatically when the Dark Theme is toggled. For now, you need to restart the app for new theme to take effect. @khaykov has created a separate issue for this at wordpress-mobile/WordPress-Android#10748
PR submission checklist:
RELEASE-NOTES.txtif necessary.