Issue/10638 material sharing settings#10970
Issue/10638 material sharing settings#10970oguzkocer merged 25 commits intofeature/material-themefrom
Conversation
|
You can test the changes on this Pull Request by downloading the APK here. |
Generated by 🚫 dangerJS |
…WordPress-Android into issue/10638-material-sharing-settings
…WordPress-Android into issue/10638-material-sharing-settings # Conflicts: # WordPress/src/main/res/values/styles.xml
…WordPress-Android into issue/10638-material-sharing-settings
…WordPress-Android into issue/10638-material-sharing-settings
|
I'm moving this PR to 14.1 since we're code freezing today. |
…WordPress-Android into issue/10638-material-sharing-settings # Conflicts: # WordPress/src/main/res/values-night/styles.xml # WordPress/src/main/res/values/dimens.xml
mattmiklic
left a comment
There was a problem hiding this comment.
Just seeing this one; sorry for the delay. @khaykov could we remove the cards used on these screens as we have elsewhere? I think it'd look significantly better in dark mode.
|
@mattmiklic Sure! I moved everything out of cards. Had to adjust margins a bit :)
|
|
That's a nice improvement; thanks for doing that! |
…WordPress-Android into issue/10638-material-sharing-settings
…WordPress-Android into issue/10638-material-sharing-settings
…WordPress-Android into issue/10638-material-sharing-settings
…WordPress-Android into issue/10638-material-sharing-settings
oguzkocer
left a comment
There was a problem hiding this comment.
@khaykov I am done with my first pass. It looks like the UI matches the screenshots, so testing went well. I left a few questions/suggestions. Let me know what you think!
P.S: It's kind of tricky to go over all the layout changes. I did a read-over and aside from one issue I didn't find anything. If there is one, hopefully it would have surfaced in the testing 🤞
WordPress/src/main/java/org/wordpress/android/ui/publicize/ConnectButton.java
Outdated
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/publicize/ConnectButton.java
Outdated
Show resolved
Hide resolved
...ess/src/main/java/org/wordpress/android/ui/publicize/PublicizeAccountChooserListAdapter.java
Outdated
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/widgets/WPPrefView.java
Outdated
Show resolved
Hide resolved
|
@oguzkocer thank you so much for checking Dark Mode PR's! Really appreciate that 🙇 I hope I addressed your concerns. Regarding layout changes, I agree! I don't think there is a good way to approach this apart from looking at the layout. |
oguzkocer
left a comment
There was a problem hiding this comment.
Looks good! 
@oguzkocer thank you so much for checking Dark Mode PR's! Really appreciate that 🙇
I am happy to help!
Fixes #10638
This PR moves Publicize screen to Material Theme and adds Dark Theme support. There are some code changes for cosmetic reasons.
While refactoring is not in the scope of this PR, since I touched those files, I cleaned up/optimized some of the redundant code as suggested by AS, so do not be alarmed by the size of the PR. I suggest turning on "Hide whitespace changes" option during the review.
There is a huge amount of PRs in this feature that covers all the screens within the app, so I'm requesting reviews from a wide variety of people.
To test:
PR submission checklist:
I have considered adding unit tests where possible.
I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.